[Bug 22827] New: Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Bug ID: 22827 Summary: Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: black23@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Some libraries needs automatic modification based on other date that dateaccessioned. For example: copyright rules allow start borrow some kind of materials x months after release date. In this case must be age modification based on other field than dateaccessioned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com, | |rbit@rbit.cz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Current date columns of items table which could apply for this enhancement: replacementpricedate datelastborrowed datelastseen damaged_on itemlost_on withdrawn_on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was about to file a new bug for this as we discussed the use of this tool in context of 'quarantining' books. I think having the option to use datelastseeen (updated on checkin) would be very helpful to enable us to make the necessary status change. But the other columns listed also create ideas for use cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1, we definitely have libraries that would make use of this if it could key off of dates other than dateaccessioned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |alexbuckley@catalyst.net.nz Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 129371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129371&action=edit Bug 22827: Add age dependency on other fields than dateaccessioned A new agefield has been added to the 'Automatic item modifications by age' tool. The options for the agefield are: replacementpricedate, datelastborrowed, datelastseen, damaged_on, itemlost_on, withdrawn_on If no option is selected then Koha will default to using dateaccessioned. Test plan: 1. Go to: Tools > Catalog > Automatic item modifications by age 2. Observe there is a new 'Age field' dropdown in the rule form. 3. Create a rule, set the values: - 'Age in days' = 20 - 'Substitutions': 'items.barcode' = 'test' fields - 'Age field' = 'items.datelastseen' - Save the rule 4. Confirm the 'List of rules' page displays 'items.datelastseen' in the 'Age field' column 5. Add another rule: - 'Age in days' = 1 - 'Substitutions': 'items.barcode' = 'test2' - Leave 'Age field' = 'Choose an age field' - Save the rule 6. Confirm the 'List of rules' page displays 'items.dateaccesioned' in the 'Age field' column for that second rule 7. Confirm you can delete rules 8. Edit a record: - Make the items.dateaccessioned less than 20 days ago (so rule 1 is false) - Make the items.datelastseen more than 1 day ago (so rule 2 is true) 9. Run the automatic_items_modification_by_age.pl: - sudo koha-shell <instance> - cd misc/cronjobs - ./automatic_item_modification_by_age.pl -v 10. Confirm the item has it's barcode set to 'test2' 11. Run unit tests: - sudo koha-shell <instance> - cd t - prove db_dependent/Item/AutomaticItemModificationByAge.t -v Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|ASSIGNED |Needs Signoff --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Ready for testing. In my patchset the fields in comment #1 are hardcoded. Please let me know if there is a way to fetch datetime items columns without having to hardcode them? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've not read the patch here yet.. but to answer your question.. you can introspect the Koha::Object.. see https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Ob... for an example. But.. I'm not sure if it's worth the overhead/extra code lines here if I'm honest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I followed the test plan successfully except: - your directions are inconsistent. To make step 8 work, the rule in step 3 should use dateaccessioned and the rule in step 5 should use datelastseen - I get a messy error on the test at the end. I don't have a clue what this means, so it could be my error: Cannot detect source of 't/db_dependent/Item/AutomaticItemModificationByAge'! at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256. TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x55d2dc3c5c48), TAP::Parser::Source=HASH(0x55d2dc292438)) called at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 211 TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x55d2dc3c5c48), TAP::Parser::Source=HASH(0x55d2dc292438)) called at /usr/share/perl/5.32/TAP/Parser.pm line 472 TAP::Parser::_initialize(TAP::Parser=HASH(0x55d2dc030148), HASH(0x55d2dc03fee0)) called at /usr/share/perl/5.32/TAP/Object.pm line 55 TAP::Object::new("TAP::Parser", HASH(0x55d2dc03fee0)) called at /usr/share/perl/5.32/TAP/Object.pm line 130 TAP::Object::_construct(TAP::Harness=HASH(0x55d2dbad1678), "TAP::Parser", HASH(0x55d2dc03fee0)) called at /usr/share/perl/5.32/TAP/Harness.pm line 852 TAP::Harness::make_parser(TAP::Harness=HASH(0x55d2dbad1678), TAP::Parser::Scheduler::Job=HASH(0x55d2dc268728)) called at /usr/share/perl/5.32/TAP/Harness.pm line 651 TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x55d2dbad1678), TAP::Parser::Aggregator=HASH(0x55d2dbad2128), TAP::Parser::Scheduler=HASH(0x55d2dc2686f8)) called at /usr/share/perl/5.32/TAP/Harness.pm line 743 TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x55d2dbad1678), TAP::Parser::Aggregator=HASH(0x55d2dbad2128), "t/db_dependent/Item/AutomaticItemModificationByAge.t") called at /usr/share/perl/5.32/TAP/Harness.pm line 558 TAP::Harness::__ANON__() called at /usr/share/perl/5.32/TAP/Harness.pm line 571 TAP::Harness::runtests(TAP::Harness=HASH(0x55d2dbad1678), "t/db_dependent/Item/AutomaticItemModificationByAge.t") called at /usr/share/perl/5.32/App/Prove.pm line 548 App::Prove::_runtests(App::Prove=HASH(0x55d2dba9c538), HASH(0x55d2dbf17978), "t/db_dependent/Item/AutomaticItemModificationByAge.t") called at /usr/share/perl/5.32/App/Prove.pm line 506 App::Prove::run(App::Prove=HASH(0x55d2dba9c538)) called at /usr/bin/prove line 13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- That said, I'm super excited to see a patch here and am eager to test again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Andrew Fuerste-Henry from comment #8)
That said, I'm super excited to see a patch here and am eager to test again!
Thanks Andrew. Hmm I'll fix up those 2 problems and attach a new patch to this ASAP! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 129460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129460&action=edit Bug 22827: Add age dependency on other fields than dateaccessioned A new agefield has been added to the 'Automatic item modifications by age' tool. The options for the agefield are: replacementpricedate, datelastborrowed, datelastseen, damaged_on, itemlost_on, withdrawn_on If no option is selected then Koha will default to saving 'agefield' = items.dateaccessioned Similarly, if a Koha instance has an old item rule without 'agefield' defined then Koha will default to using 'items.dateaccessioned'. This is confirmed by the AutomaticItemModificationByAge.t unit test. Test plan: 1. Go to: Tools > Catalog > Automatic item modifications by age 2. Observe there is a new 'Age field' dropdown in the rule form. 3. Create a rule, set the values: - 'Age in days' = 20 - Leave 'Age field' = 'Choose an age field' - 'Substitutions': 'items.barcode' = 'test' - Save the rule 4. Confirm the 'List of rules' page displays 'items.dateaccessioned in the 'Age field' column 5. Add another rule: - 'Age in days' = 2 - 'Age field' = 'items.datelastseen' - 'Substitutions': 'items.barcode' = 'test2' - Save the rule 6. Confirm the 'List of rules' page displays 'items.datelastseen' in the 'Age field' column for that second rule 7. Add some more rules and confirm you can delete them 8. Edit a record: - Make the items.dateaccessioned = 3 day ago (so rule 1 is false) - Make the items.datelastseen = 3 days ago (so rule 2 is true) 9. Run the automatic_items_modification_by_age.pl: - sudo koha-shell <instance> - cd misc/cronjobs - ./automatic_item_modification_by_age.pl -v -c 10. Confirm the item has it's barcode set to 'test2' 11. Run unit tests: - sudo koha-shell <instance> - prove t/db_dependent/Items/AutomaticItemModificationByAge.t -v Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Andrew and Martin, Martin: Thank you for your reply in comment #6. My concerns with hard coding were: 1. Everytime a datetime column is added to the items table then the community would have to remember to update this hardcoded list of columns. 2. If an existing datetime column is removed/renamed then the hardcoded list would have to be updated otherwise my alterations to C4::Items->ToggleNewStatus() would throw an error. As the hardcoded list determines what column is queried. But as you say doing an introspect of the koha::Object may not be worthwhile. So I have left the hardcoded list for now. I'm happy to add it later though if that is what QA wants. Andrew: I have corrected the test plan. That error you encountered was because my test plan noted an incorrect unit test filepath. So it was not your error :) Could you please re-test now? Many thanks! Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129460|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129481&action=edit Bug 22827: Add age dependency on other fields than dateaccessioned A new agefield has been added to the 'Automatic item modifications by age' tool. The options for the agefield are: replacementpricedate, datelastborrowed, datelastseen, damaged_on, itemlost_on, withdrawn_on If no option is selected then Koha will default to saving 'agefield' = items.dateaccessioned Similarly, if a Koha instance has an old item rule without 'agefield' defined then Koha will default to using 'items.dateaccessioned'. This is confirmed by the AutomaticItemModificationByAge.t unit test. Test plan: 1. Go to: Tools > Catalog > Automatic item modifications by age 2. Observe there is a new 'Age field' dropdown in the rule form. 3. Create a rule, set the values: - 'Age in days' = 20 - Leave 'Age field' = 'Choose an age field' - 'Substitutions': 'items.barcode' = 'test' - Save the rule 4. Confirm the 'List of rules' page displays 'items.dateaccessioned in the 'Age field' column 5. Add another rule: - 'Age in days' = 2 - 'Age field' = 'items.datelastseen' - 'Substitutions': 'items.barcode' = 'test2' - Save the rule 6. Confirm the 'List of rules' page displays 'items.datelastseen' in the 'Age field' column for that second rule 7. Add some more rules and confirm you can delete them 8. Edit a record: - Make the items.dateaccessioned = 3 day ago (so rule 1 is false) - Make the items.datelastseen = 3 days ago (so rule 2 is true) 9. Run the automatic_items_modification_by_age.pl: - sudo koha-shell <instance> - cd misc/cronjobs - ./automatic_item_modification_by_age.pl -v -c 10. Confirm the item has it's barcode set to 'test2' 11. Run unit tests: - sudo koha-shell <instance> - prove t/db_dependent/Items/AutomaticItemModificationByAge.t -v Sponsored-By: Catalyst IT Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was wondering about the fallback instead of updating the rules, until I realized that the rules are stored in a system preference: automatic_item_modification_by_age_configuration Also filed a new bug for a warning that exists before and after the patches are applied: Bug 30366 - Warn when running automatic_item_modification_by_age.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129481|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132265&action=edit Bug 22827: Add age dependency on other fields than dateaccessioned A new agefield has been added to the 'Automatic item modifications by age' tool. The options for the agefield are: replacementpricedate, datelastborrowed, datelastseen, damaged_on, itemlost_on, withdrawn_on If no option is selected then Koha will default to saving 'agefield' = items.dateaccessioned Similarly, if a Koha instance has an old item rule without 'agefield' defined then Koha will default to using 'items.dateaccessioned'. This is confirmed by the AutomaticItemModificationByAge.t unit test. Test plan: 1. Go to: Tools > Catalog > Automatic item modifications by age 2. Observe there is a new 'Age field' dropdown in the rule form. 3. Create a rule, set the values: - 'Age in days' = 20 - Leave 'Age field' = 'Choose an age field' - 'Substitutions': 'items.barcode' = 'test' - Save the rule 4. Confirm the 'List of rules' page displays 'items.dateaccessioned in the 'Age field' column 5. Add another rule: - 'Age in days' = 2 - 'Age field' = 'items.datelastseen' - 'Substitutions': 'items.barcode' = 'test2' - Save the rule 6. Confirm the 'List of rules' page displays 'items.datelastseen' in the 'Age field' column for that second rule 7. Add some more rules and confirm you can delete them 8. Edit a record: - Make the items.dateaccessioned = 3 day ago (so rule 1 is false) - Make the items.datelastseen = 3 days ago (so rule 2 is true) 9. Run the automatic_items_modification_by_age.pl: - sudo koha-shell <instance> - cd misc/cronjobs - ./automatic_item_modification_by_age.pl -v -c 10. Confirm the item has it's barcode set to 'test2' 11. Run unit tests: - sudo koha-shell <instance> - prove t/db_dependent/Items/AutomaticItemModificationByAge.t -v Sponsored-By: Catalyst IT Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks for testing and QA Andrew and Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Nice enhancement. Please add a release notes to explain this new option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |librarians to automatically | |modify items based on date | |fields other than | |items.dateaccessioned. | | | |The 'Automatic item | |modifications by age' tool | |can now key rules off any | |one the following: | |items.dateaccessioned, | |items.replacementpricedate, | |items.datelastborrowed, | |items.datelastseen, | |items.damaged_on, | |items.itemlost_on, | |items.withdrawn_on. | | | |Existing rules will | |continue to key off the | |items.dateaccessioned | |field. Keywords|release-notes-needed | --- Comment #18 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Fridolin Somers from comment #16)
Nice enhancement. Please add a release notes to explain this new option
Thanks, Fridolin! I've added release notes, I hope they adequately explain this enhancement. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- <span class="hint">If not set then items.dateaccessioned will be used</span> Instead of this we could just select this value in the dropdown list if none exist, and remove the empty option to make it mandatory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #19)
<span class="hint">If not set then items.dateaccessioned will be used</span>
Instead of this we could just select this value in the dropdown list if none exist, and remove the empty option to make it mandatory.
Note: We'd also need a database update for the old entries. I can try to file that later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #20)
(In reply to Jonathan Druart from comment #19)
<span class="hint">If not set then items.dateaccessioned will be used</span>
Instead of this we could just select this value in the dropdown list if none exist, and remove the empty option to make it mandatory.
Note: We'd also need a database update for the old entries. I can try to file that later.
Not necessarily but yes that will be better ofc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #21)
(In reply to Katrin Fischer from comment #20)
(In reply to Jonathan Druart from comment #19)
<span class="hint">If not set then items.dateaccessioned will be used</span>
Instead of this we could just select this value in the dropdown list if none exist, and remove the empty option to make it mandatory.
Note: We'd also need a database update for the old entries. I can try to file that later.
Not necessarily but yes that will be better ofc.
Filed as: Bug 33979 - Improve behaviour of source list on 'item modifications by age' tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33979 [Bug 33979] Improve behaviour of source list on 'item modifications by age' tool -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org