[Bug 22118] New: Format hold fee when placing holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Bug ID: 22118 Summary: Format hold fee when placing holds in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Blocks: 22112 Target Milestone: --- Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 [Bug 22112] Omnibus: Use Price filter everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83838&action=edit Bug 22118: Format hold fee when placing holds in OPAC When Koha charges for holds, a message with the fee is shown before the patron places the hold. The amount needs to be formatted according to CurrencyFormat system preference. To test: - Add a hold fee to your patron category - Log into the OPAC - Search for a record to place a hold on - Click Place hold - Verify there is a note showing about the hold fee - Toggle CurrencyFormat and HoldFeeMode and verify that the formatting is always correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Jack Kelliher <jke0429@stacmail.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 83920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83920&action=edit Bug 22118: Format hold fee when placing holds in OPAC When Koha charges for holds, a message with the fee is shown before the patron places the hold. The amount needs to be formatted according to CurrencyFormat system preference. To test: - Add a hold fee to your patron category - Log into the OPAC - Search for a record to place a hold on - Click Place hold - Verify there is a note showing about the hold fee - Toggle CurrencyFormat and HoldFeeMode and verify that the formatting is always correct Signed-off-by: Jack Kelliher <jke0429@stacmail.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83920|0 |1 is obsolete| | --- Comment #5 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84231&action=edit Bug 22118: Format hold fee when placing holds in OPAC When Koha charges for holds, a message with the fee is shown before the patron places the hold. The amount needs to be formatted according to CurrencyFormat system preference. To test: - Add a hold fee to your patron category - Log into the OPAC - Search for a record to place a hold on - Click Place hold - Verify there is a note showing about the hold fee - Toggle CurrencyFormat and HoldFeeMode and verify that the formatting is always correct Signed-off-by: Jack Kelliher <jke0429@stacmail.net> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84231|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84267&action=edit Bug 22118: Format hold fee when placing holds in OPAC When Koha charges for holds, a message with the fee is shown before the patron places the hold. The amount needs to be formatted according to CurrencyFormat system preference. To test: - Add a hold fee to your patron category - Log into the OPAC - Search for a record to place a hold on - Click Place hold - Verify there is a note showing about the hold fee - Toggle CurrencyFormat and HoldFeeMode and verify that the formatting is always correct Signed-off-by: Jack Kelliher <jke0429@stacmail.net> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22118 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org