[Bug 13229] New: Suggestion date filters have a style problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Bug ID: 13229 Summary: Suggestion date filters have a style problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Created attachment 33444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33444&action=edit Screenshot The date related filters on the suggestion page don't look quite right/as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33456&action=edit Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33456|0 |1 is obsolete| | --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- Created attachment 33458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33458&action=edit Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. Signed-off-by: Blou <philippe.blouin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- Looks good on Firefox 28, at least. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 --- Comment #4 from Blou <philippe.blouin@inlibro.com> --- Looks good on Firefox 28, at least. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33458|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33466&action=edit [PASSED QA] Bug 13229 - Suggestion date filters have a style problem The suggestion date filters appear to be picking up a style change which wasn't anticipated for the suggestions page markup. This patch solves the problem by simplifying and standardizing the markup, including simplifications to the label structure. To test, apply the patch and view the suggestions management page in the staff client. Expand the "suggestion information" filter section and confirm that the label/input structure looks correct and works correctly. Signed-off-by: Blou <philippe.blouin@inlibro.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, looking better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13229 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|philippe.blouin@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org