https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 157507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157507&action=edit Bug 35115: Prefix biblio hash with table name It seems TransformKohaToMarc requires the input to be prefixed with the table name, like this: { 'biblio.abstract' => undef, 'biblio.subtitle' => undef, 'biblio.frameworkcode' => 'BKS', 'biblio.medium' => undef, 'biblio.part_name' => undef, 'biblio.copyrightdate' => 2008, 'biblio.seriestitle' => undef, 'biblio.notes' => 'Originally published: 2008.', 'biblio.biblionumber' => 299, 'biblio.serial' => undef, 'biblio.title' => 'Kluge :', 'biblio.datecreated' => '2014-05-07', 'biblio.part_number' => undef, 'biblio.author' => 'Marcus, Gary F.', 'biblio.timestamp' => '2020-04-21 09:38:26', 'biblio.unititle' => undef }; but we were using this: { 'abstract' => undef, 'notes' => 'Originally published: 2008.', 'medium' => undef, 'subtitle' => undef, 'title' => 'Kluge :', 'author' => 'Marcus, Gary F.', 'serial' => undef, 'timestamp' => '2020-04-21 09:38:26', 'biblionumber' => 299, 'part_name' => undef, 'datecreated' => '2014-05-07', 'part_number' => undef, 'seriestitle' => undef, 'unititle' => undef, 'frameworkcode' => 'BKS', 'copyrightdate' => 2008 }; ATTENTION: This does not solve the whole issue, i.e. MARC fields not mapped to Koha fields will still be stripped. More work required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This should depend on bug 35095 or vice-versa, whichever moves first. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |pedro.amorim@ptfs-europe.co |com |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #4)

ok for me, please provide tests.

Also you can replace the loop with

$biblio = { map { ( "biblio.$_" => $biblio->{$_} ) } keys %$biblio };

Thank you for taking a look Jonathan, this is great. I'm not sure when I'll be able to get back to this, but there is still the matter of: ATTENTION: This does not solve the whole issue, i.e. MARC fields not mapped to Koha fields will still be stripped. More work required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158085&action=edit Bug 35115 [Alternative]: Skip Resource store logic if resource was imported from list This patch fixes the data loss issue when importing titles from a list of biblios. It does NOT fix the data loss issue when saving a title that is linked to a biblio, that will still caused data loss on the biblio. I believe store in Resource.pm is trying to do a couple things: 1) Updating Biblio when a title is saved, or 2) Adding a biblio when a title is created The problem is that it's updating the biblio when the title is created from an import list, as if new changes were made to the title and need to be reflected to the biblio. This is not the case, a title created from an imported list of biblios should have no business updating their respective biblio's MARC at that time. ---- The biblio MARC being updated when the title is saved through the edit form should perhaps be a different bug. Should all possible fields be updated on the biblio when saving the title? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157507|0 |1 is obsolete| | Attachment #158085|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158672&action=edit Bug 35115: Move store routine from Resource to Title and update code These patches move the store routine from Koha::ERM::EHoldings::Resource to Koha::ERM::EHoldings::Title as the code deals exclusively with title fields. It updates the code to ensure that records are created when a title is not attched to a biblio, and that only the biblio title field is updated when updating an eholdings title. To test: 1 - Enable ERMModule sys pref 2 - Create a new public list, visit: /cgi-bin/koha/virtualshelves/shelves.pl 3 - Click "New list" enter name, set public -> public 4 - Click "Add items", enter 112\n113\n114 (new line for each), in "Biblio numbers" 5 - Notice that all added biblios have quite a few MARC fields 6 - Go to packages, visit: /cgi-bin/koha/erm/eholdings/local/packages 7 - Create a new package, add a name and hit 'Submit' 8 - Go to titles, visit: /cgi-bin/koha/erm/eholdings/local/titles 9 - Click "import from list" 10 - Pick the package created in 7) 11 - On the row of the list created in 2), click "Import" 12 - Go back to the list, visit: /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 13 - Notice all the biblios have been stripped of their MARC data, and only title remains. 14 - Go to details page for one of the bibs 15 - Edit -> Replace record via Z39.50 16 - You can search for anything, just make sure to import a mostly full record 17 - Go back to ERM - eHoldings - Local - Titles 18 - Edit the title for the record that was replaced 19 - Save 20 - Go to record details - note the record is gone again 21 - Apply patches 22 - Search the catalog 23 - Check some titles 24 - Add to a new list 25 - repeat 8 - 11 with the new list 26 - View and confirm records are intact 27 - Edit the eholdings title for one of the records, changing the title field 28 - Save and view record details 29 - Confirm record is intact and title updated Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158672|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158748&action=edit Bug 35115: Move store routine from Resource to Title and update code These patches move the store routine from Koha::ERM::EHoldings::Resource to Koha::ERM::EHoldings::Title as the code deals exclusively with title fields. It updates the code to ensure that records are created when a title is not attched to a biblio, and that only the biblio title field is updated when updating an eholdings title. To test: 1 - Enable ERMModule sys pref 2 - Create a new public list, visit: /cgi-bin/koha/virtualshelves/shelves.pl 3 - Click "New list" enter name, set public -> public 4 - Click "Add items", enter 112\n113\n114 (new line for each), in "Biblio numbers" 5 - Notice that all added biblios have quite a few MARC fields 6 - Go to packages, visit: /cgi-bin/koha/erm/eholdings/local/packages 7 - Create a new package, add a name and hit 'Submit' 8 - Go to titles, visit: /cgi-bin/koha/erm/eholdings/local/titles 9 - Click "import from list" 10 - Pick the package created in 7) 11 - On the row of the list created in 2), click "Import" 12 - Go back to the list, visit: /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 13 - Notice all the biblios have been stripped of their MARC data, and only title remains. 14 - Go to details page for one of the bibs 15 - Edit -> Replace record via Z39.50 16 - You can search for anything, just make sure to import a mostly full record 17 - Go back to ERM - eHoldings - Local - Titles 18 - Edit the title for the record that was replaced 19 - Save 20 - Go to record details - note the record is gone again 21 - Apply patches 22 - Search the catalog 23 - Check some titles 24 - Add to a new list 25 - repeat 8 - 11 with the new list 26 - View and confirm records are intact 27 - Edit the eholdings title for one of the records, changing the title field 28 - Save and view record details 29 - Confirm record is intact and title updated Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158748|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158806&action=edit Bug 35115: Move store routine from Resource to Title and update code These patches move the store routine from Koha::ERM::EHoldings::Resource to Koha::ERM::EHoldings::Title as the code deals exclusively with title fields. It updates the code to ensure that records are created when a title is not attched to a biblio, and that only the biblio title field is updated when updating an eholdings title. To test: 1 - Enable ERMModule sys pref 2 - Create a new public list, visit: /cgi-bin/koha/virtualshelves/shelves.pl 3 - Click "New list" enter name, set public -> public 4 - Click "Add items", enter 112\n113\n114 (new line for each), in "Biblio numbers" 5 - Notice that all added biblios have quite a few MARC fields 6 - Go to packages, visit: /cgi-bin/koha/erm/eholdings/local/packages 7 - Create a new package, add a name and hit 'Submit' 8 - Go to titles, visit: /cgi-bin/koha/erm/eholdings/local/titles 9 - Click "import from list" 10 - Pick the package created in 7) 11 - On the row of the list created in 2), click "Import" 12 - Go back to the list, visit: /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 13 - Notice all the biblios have been stripped of their MARC data, and only title remains. 14 - Go to details page for one of the bibs 15 - Edit -> Replace record via Z39.50 16 - You can search for anything, just make sure to import a mostly full record 17 - Go back to ERM - eHoldings - Local - Titles 18 - Edit the title for the record that was replaced 19 - Save 20 - Go to record details - note the record is gone again 21 - Apply patches 22 - Search the catalog 23 - Check some titles 24 - Add to a new list 25 - repeat 8 - 11 with the new list 26 - View and confirm records are intact 27 - Edit the eholdings title for one of the records, changing the title field 28 - Save and view record details 29 - Confirm record is intact and title updated Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Is comment 6 still valid?

ATTENTION: This does not solve the whole issue, i.e. MARC fields not mapped to Koha fields will still be stripped.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Great :D "important" tag removed then. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158806|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159254&action=edit Bug 35115: Move store routine from Resource to Title and update code These patches move the store routine from Koha::ERM::EHoldings::Resource to Koha::ERM::EHoldings::Title as the code deals exclusively with title fields. It updates the code to ensure that records are created when a title is not attched to a biblio, and that only the biblio title field is updated when updating an eholdings title. To test: 1 - Enable ERMModule sys pref 2 - Create a new public list, visit: /cgi-bin/koha/virtualshelves/shelves.pl 3 - Click "New list" enter name, set public -> public 4 - Click "Add items", enter 112\n113\n114 (new line for each), in "Biblio numbers" 5 - Notice that all added biblios have quite a few MARC fields 6 - Go to packages, visit: /cgi-bin/koha/erm/eholdings/local/packages 7 - Create a new package, add a name and hit 'Submit' 8 - Go to titles, visit: /cgi-bin/koha/erm/eholdings/local/titles 9 - Click "import from list" 10 - Pick the package created in 7) 11 - On the row of the list created in 2), click "Import" 12 - Go back to the list, visit: /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 13 - Notice all the biblios have been stripped of their MARC data, and only title remains. 14 - Go to details page for one of the bibs 15 - Edit -> Replace record via Z39.50 16 - You can search for anything, just make sure to import a mostly full record 17 - Go back to ERM - eHoldings - Local - Titles 18 - Edit the title for the record that was replaced 19 - Save 20 - Go to record details - note the record is gone again 21 - Apply patches 22 - Search the catalog 23 - Check some titles 24 - Add to a new list 25 - repeat 8 - 11 with the new list 26 - View and confirm records are intact 27 - Edit the eholdings title for one of the records, changing the title field 28 - Save and view record details 29 - Confirm record is intact and title updated Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- In the hope to help, here is a 2nd signoff. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Pedro Amorim from comment #21)

(In reply to Victor Grousset/tuxayo from comment #17)

...

...

27 - Edit the eholdings title for one of the records, changing the title field 28 - Save and view record details 29 - Confirm record is intact and title updated

Just to be sure, title update should only be from eholding to record, right? And not from record to eholding.

Correct, yes.

Great, no issues then.

I'm converting my SO to PQA here.

Perfect, that was the plan :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #24 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Maybe a bit late to be asking, but shouldn't this be backported to 23.05 since it causes data loss? I just tested on that version, and I was able to duplicate the bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We just had a case of data loss in 22.11 LTS :( -- You are receiving this mail because: You are watching all bug changes.