[Bug 21989] New: JS error in "Add orders from MARC file" - addorderiso2709.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Bug ID: 21989 Summary: JS error in "Add orders from MARC file" - addorderiso2709.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 19753 On addorderiso2709.pl there is a JS error "ReferenceError: $ is not defined" It comes from commit 1a132440766277d6d94246a86ec671b79de7a442 Bug 19753: Move template JavaScript to the footer: Acquisitions
From Owen on #koha: """ That's just poor testing on my part, and the change to that file should be undone. There's currently no good way to handle cataloging plugin JS with all other JS in the footer """
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 [Bug 19753] Move template JavaScript to the footer: Acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, could you have a look maybe? Is this an urgent one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|jonathan.druart@bugs.koha-c |oleonard@myacpl.org |ommunity.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83889&action=edit Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl This patch undoes the changes to addorderiso2709.tt introduced by Bug 19753. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83889|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 84440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84440&action=edit Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl This patch undoes the changes to addorderiso2709.tt introduced by Bug 19753. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84440|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84445&action=edit Bug 21989: JS error in "Add orders from MARC file" - addorderiso2709.pl This patch undoes the changes to addorderiso2709.tt introduced by Bug 19753. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ignoring the QA script fail as invalid in this case (see commit message): FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt OK filters OK forbidden patterns OK git manipulation FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- doesnt cleanly apply to 18.05.x needs rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84815&action=edit Bug 21989: [18.05.x] JS error in "Add orders from MARC file" - addorderiso2709.pl This patch undoes the changes to addorderiso2709.tt introduced by Bug 19753. The item information tab can include embedded JavaScript for cataloging plugins, and these don't currently work with JS in the footer. To test, apply the patch and test the JavaScript driven features of the "Add to basket from a staged file" page: - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - MARC and Card previews, select all/clear all - Item information tab: Cataloging plugins for fields like date acquired, barcode - Default accounting details tab: Show inactive control -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org