[Bug 19608] New: Move admin templates JavaScript to the footer: The rest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Bug ID: 19608 Summary: Move admin templates JavaScript to the footer: The rest Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, nick@bywatersolutions.com, simon.pouchol@biblibre.com, testopia@bugs.koha-community.org Depends on: 19594 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for administration templates not already converted in other patches. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 [Bug 19594] Move admin templates JavaScript to the footer: MARC-related -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19607, 19560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 [Bug 19560] Unable to delete library when branchcode contains special characters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607 [Bug 19607] Move admin templates JavaScript to the footer: Basic parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69144&action=edit Bug 19608 - Move admin templates JavaScript to the footer: The rest This patch modifies the staff client administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. To test the changes to localization.tt you must have more than one translation installed. Go to admin/itemtypes.pl, edit an itemtype, and click the 'Translate into other languages' link. To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl and create a new SRU server. Click the 'Modify' button next to 'SRU Search fields mapping' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 [Bug 19623] Move admin templates JavaScript to the footer: Cataloging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19594 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 [Bug 19594] Move admin templates JavaScript to the footer: MARC-related -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19560 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 [Bug 19560] Unable to delete library when branchcode contains special characters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19641 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69144|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69308&action=edit Bug 19608 - Move admin templates JavaScript to the footer: The rest This patch modifies the staff client administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. To test the changes to localization.tt you must have more than one translation installed. Go to admin/itemtypes.pl, edit an itemtype, and click the 'Translate into other languages' link. To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl and create a new SRU server. Click the 'Modify' button next to 'SRU Search fields mapping' Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19709 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |josef.moravec@gmail.com --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- The item types translation popup dialog does not work for me - it opens when I click "Translate into other languages" but then I am redirected straight to localization.pl as if would click on normal link... look like going to href on that anchor is not prevented... I tried it in firefox 57 and chromium 62 Also on clone rules page the "Circulation and fines rules" menu item should be styled in bold. Sorry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69802&action=edit Bug 19608 (QA follow-up) Fix redirect on localization modal This patch makes two minor corrections: 1. The item types localization modal redirect problem has been fixed by excluding the anti-clickjack code from executing in the footer. 2. The sidebar menu highlighting script has been modified to correctly handle the clone-rules page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Bug 19608 depends on bug 19607, which changed state. Bug 19607 Summary: Move admin templates JavaScript to the footer: Basic parameters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69308|0 |1 is obsolete| | Attachment #69802|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70141&action=edit Bug 19608: Move admin templates JavaScript to the footer: The rest This patch modifies the staff client administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. To test the changes to localization.tt you must have more than one translation installed. Go to admin/itemtypes.pl, edit an itemtype, and click the 'Translate into other languages' link. To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl and create a new SRU server. Click the 'Modify' button next to 'SRU Search fields mapping' Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70142&action=edit Bug 19608: (QA follow-up) Fix redirect on localization modal This patch makes two minor corrections: 1. The item types localization modal redirect problem has been fixed by excluding the anti-clickjack code from executing in the footer. 2. The sidebar menu highlighting script has been modified to correctly handle the clone-rules page. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70143&action=edit Bug 19608: (QA follow-up) Fix menu item styling for clone-rules Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Problem with sru_modmapping while replacing intranet-bottom by popup-bottom -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #10)
Problem with sru_modmapping while replacing intranet-bottom by popup-bottom
Will be fixed on 19436 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19436 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11297 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org