[Bug 12525] New: Patron Lists aren't added to list pulldown when created from Patron search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Bug ID: 12525 Summary: Patron Lists aren't added to list pulldown when created from Patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The new ajax patron search needs to add newly created patron lists to the pulldown dynamically since the page is no longer reloaded. In addition, the notice should fade out after a given amount of time so another addition of patrons to a list is more prominent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- It also appears that existing patron lists don't always show in the pulldown. Increasing severity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41007&action=edit Bug 12525: FIX patron lists dropdown is empty On the patrons home page, the dropdown list is not populated. Test plan: 1/ Go on the patrons home page (members/members-home.pl) 2/ Launch a search 3/ The dropdown list close to "Add selected patrons to" should contain all your patron lists -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41008&action=edit Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41007|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 41084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41084&action=edit Bug 12525: FIX patron lists dropdown is empty On the patrons home page, the dropdown list is not populated. Test plan: 1/ Go on the patrons home page (members/members-home.pl) 2/ Launch a search 3/ The dropdown list close to "Add selected patrons to" should contain all your patron lists NOTE: Initially tested with both which created lists. git reset --hard origin/master And then dropdown list was missing them. Applied just this one, and they were listed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41008|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 41085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41085&action=edit Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created NOTE: And the single list doesn't duplicate patrons that were saved both times. Both patches needed to make the list functionality work more sanely. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is something going wrong here: 1) Go to patron search home page 2) Launch a search (I used "d") 3) Check one patron, say [New list] from pull down 4) Name the list, hit the save button behind it 5) Check another patron, pull down list still shows newly created list - hit save again 6) Another list with the same name is added It will always create a new list - even if you switch the pull down to another preexisting list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm interesting: It doesn't really add a new list, but it adds another entry to the drop down every time you hit 'save'. Once you reload the page the double ups in the pull down are gone. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41085|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42193&action=edit Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Katrin, thanks for the catch! Weird, I was sure I had tested this one correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com --- Comment #10 from Joonas Kylmälä <j.kylmala@gmail.com> --- I cannot even test this because in the latest master it doesn't show any lists which I have created. But if I click the button "Patron lists" there it shows the lists I have created. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #10)
I cannot even test this because in the latest master it doesn't show any lists which I have created. But if I click the button "Patron lists" there it shows the lists I have created.
This is fixed by the first patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41084|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 42257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42257&action=edit Bug 12525: FIX patron lists dropdown is empty On the patrons home page, the dropdown list is not populated. Test plan: 1/ Go on the patrons home page (members/members-home.pl) 2/ Launch a search 3/ The dropdown list close to "Add selected patrons to" should contain all your patron lists NOTE: Initially tested with both which created lists. git reset --hard origin/master And then dropdown list was missing them. Applied just this one, and they were listed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42193|0 |1 is obsolete| | --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 42258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42258&action=edit Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42257|0 |1 is obsolete| | Attachment #42258|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42370&action=edit [PASSED QA] Bug 12525: FIX patron lists dropdown is empty On the patrons home page, the dropdown list is not populated. Test plan: 1/ Go on the patrons home page (members/members-home.pl) 2/ Launch a search 3/ The dropdown list close to "Add selected patrons to" should contain all your patron lists NOTE: Initially tested with both which created lists. git reset --hard origin/master And then dropdown list was missing them. Applied just this one, and they were listed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42371&action=edit [PASSED QA] Bug 12525: Prevent adding several patron lists with the same name If you add patron to a patron list, from the patron search result, a list is created when you click on "Save". The list is considered as new each time. To reproduce: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' 3/ Select another patron and click Save again 2 lists are created Test plan: 1/ Launch a patron search 2/ Select 1 patron, and create a new list 'aaa' The dropdown list should be populated with this new list, and should be selected 3/ Select another patron and click Save again Only 1 list should be created Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #18 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18 will be in 3.18.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org