[Bug 26889] New: Remove extra space from "Damaged :" in item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Bug ID: 26889 Summary: Remove extra space from "Damaged :" in item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The item search displays an extra space between the search label and the following : on the item search form. I did some tracking but was not able to see where it came from. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112828&action=edit Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112828|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 112865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112865&action=edit Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112865|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112881&action=edit Bug 26889: Remove extra space from "Damaged :" in item search This patch adds the chomp shorthand [%- -%] to the BLOCK for showing labels in the item search template. This collapses the whitespace around the label, eliminating the unwanted space around the ":" To test, apply the patch and go to the item search page in the staff interface. There should be no space before the colon in the "Damaged" label. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried adding a few -, but obviously not in the right spots :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26889 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- doesnt clean apply to 20.05.x, no backport please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org