[Bug 32931] New: ERM - (is perpetual) Yes / No options untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Bug ID: 32931 Summary: ERM - (is perpetual) Yes / No options untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The Yes and No radio button options for the "Is perpetual" field when adding an agreement are not translatable (at least, I didn't find the correct strings) To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No The only "Yes" that I found in fr-CA-messages-js.po is in holds. #: koha-tmpl/intranet-tmpl/prog/js/holds.js:241 msgid "Yes" msgstr "Oui" An option would be to change this to a checkbox, since the options are 0 or 1... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Not sure if it is managed in the same place, but the Yes/No in the agreement table, once the agreement is created, is also untranslatable, as well as the filtering drop-down in the table header. https://snipboard.io/QyfStJ.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149727&action=edit Bug 32931: Fix translatability issues on 'new agreement' form This fixes the "Yes" and "No" options and "License info" placeholder. To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No --> At the bottom of the form "License info" with "License info" within the input field 5. Install (complete) language, verify those are not translated 6. Apply patch 7. Update po files 8. Verify strings exist for this file, translate if necessary 9. Re-install language 10. Verify strings are now translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe I found a fix for the form... but I couldn't see where the other Yes/No (from comment 1) might go wrong. Adding Jonathan and attaching my patch. Caroline, maybe you want to test if that fixes the form for you too? The form/label layout is also a bit broken, but I see the same on master without my change. You might need to do a yarn build after applying the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue: <span v-if="agreement.is_perpetual">Yes</span> This one is missing as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm having a bit of unrelated trouble with the form. However, I'm wondering if a checkbox wouldn't be better in this case (rather that yes/no radio buttons). Similar to open baskets in acquisitions (when creating a new a basket, we can check a box is the orders are standing). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I applied the patch and updated/installed translations. I see the line in fr-CA-messages-js.po #: koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue:108 #: koha-tmpl/intranet-tmpl/prog/js/holds.js:241 msgid "Yes" msgstr "Oui" But it's still showing up as Yes in the form. I wonder if my unrelated problem is not related after all. The options are displayed before the question https://snipboard.io/R8i9th.jpg Not sure why, but it's the same in the ByWater sandbox, so it's not something in my installation or something I'm doing/not doing... Also, do we really want it to say "Noes"? XD I thought I was not seeing this correctly, but it's in the diff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Matt pointed me to bug 33355 for my form problems. This one doesn't apply on top of that. So I can't check if it solves my problem. I retested and Yes/No are still in english. (It's not even Yes/Noes, so I have no idea what I'm doing wrong) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #7)
Matt pointed me to bug 33355 for my form problems. This one doesn't apply on top of that. So I can't check if it solves my problem.
I retested and Yes/No are still in english. (It's not even Yes/Noes, so I have no idea what I'm doing wrong)
I guess it was a little too late again that day - I had changed it to noes to verify I was changing things in the right spot - forgot to change back or to commit the changed file... I won't be able to come back to this maybe for a while, if someone else wants to continue/fix this here please do. (I have no idea how to change to a checkbox either with vue) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You always need to build the vue files (yarn build) with every change I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149727|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149834&action=edit Bug 32931: Fix translatability issues on 'new agreement' form This fixes the "Yes" and "No" options and "License info" placeholder. To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No --> At the bottom of the form "License info" with "License info" within the input field 5. Install (complete) language, verify those are not translated 6. Apply patch 7. Update po files 8. Verify strings exist for this file, translate if necessary 9. Re-install language 10. Verify strings are now translated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149835&action=edit Bug 32931: Fix translatability issues on 'show agreement' view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I've fixed Katrin's patch. With this second patch it will work. Test plan: translate update LANG edit po/LANG-messages-js.po translate install LANG restart_all (JS strings are cached!!) Try now the UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #12)
I've fixed Katrin's patch. With this second patch it will work.
Test plan: translate update LANG edit po/LANG-messages-js.po translate install LANG restart_all (JS strings are cached!!) Try now the UI
and ofc `yarn js:build` that is mandatory when you modify vue files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149834|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 150142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150142&action=edit Bug 32931: Fix translatability issues on 'new agreement' form This fixes the "Yes" and "No" options and "License info" placeholder. To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No --> At the bottom of the form "License info" with "License info" within the input field 5. Install (complete) language, verify those are not translated 6. Apply patch 7. Update po files 8. Verify strings exist for this file, translate if necessary 9. Re-install language 10. Verify strings are now translated Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149835|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 150143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150143&action=edit Bug 32931: Fix translatability issues on 'show agreement' view Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #12)
I've fixed Katrin's patch. With this second patch it will work.
Thank you - I was just doing it by trial and error mostly :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #17 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Install a language: - cd misc/translator - ./translate install fr-CA 2. After applying the patch: - yarn js:build - flush_memcached and restart_all 3. Update the po files: - cd misc/translator - ./translate update fr-CA - vi po/fr-CA-messages-js.po - search for Yes, No and License info - should now be entries for ...AgreementsFormAdd.vue and ....AgreementsShow.vue files - reinstall the language: ./translate install fr-CA 4. When installing fr-CA (before and after the patch is applied) I get this message - does this need to be fixed? In file "admin.pref", "Options d'authentification" is a translation for sections "Google OpenID Connect", "Login options" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #18 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to David Nind from comment #17)
4. When installing fr-CA (before and after the patch is applied) I get this message - does this need to be fixed?
In file "admin.pref", "Options d'authentification" is a translation for sections "Google OpenID Connect", "Login options" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184.
It's already fixed in Pootle. However, I don't know how to make it so that the commited files are also corrected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150142|0 |1 is obsolete| | Attachment #150143|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150205&action=edit Bug 32931: Fix translatability issues on 'new agreement' form This fixes the "Yes" and "No" options and "License info" placeholder. To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No --> At the bottom of the form "License info" with "License info" within the input field 5. Install (complete) language, verify those are not translated 6. Apply patch 7. Update po files 8. Verify strings exist for this file, translate if necessary 9. Re-install language 10. Verify strings are now translated Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150206&action=edit Bug 32931: Fix translatability issues on 'show agreement' view Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 [Bug 33355] ERM UI and markup has some issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32030 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org