[Bug 24208] New: Remove change calculation for writeoffs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Bug ID: 24208 Summary: Remove change calculation for writeoffs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: maryse.simard@inlibro.com QA Contact: testopia@bugs.koha-community.org Bug 11373 added change calculation to the payment page. This doesn't work very well when using the "Writeoff selected" button: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 --- Comment #1 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 96173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96173&action=edit Bug 24208: Remove change calculation for writeoffs Bug 11373 added change calculation to the payment page. This doesn't work very well in the case of writeoffs: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. This patch removes these unwanted fields and use the "Writeoff amount" label on the right input. Test plan: 1) Choose a patron who has fees. You can add a manual invoice if necessary. 2) Go to Accounting > Make a payment. 3) Select some fines and click "Write off selected". 4) Note the form has a lot of inputs, not all are necessary for a writeoff. 5) Make a partial writeoff by entering a different amount in the "Writeoff amount" field. => The amount written off is the amount entered in the "Amount paid" field. 6) Apply patch. 7) Repeat steps 1-3. 8) Notice the form only has "Amount outstanding", "Writeoff amount" and "Note" fields, which are enough for a writeoff. 9) Entering any amount lower than or equal to the amount outstanding in the "Writeoff amount" field should create a writeoff of the selected amount. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on| |11373 Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |maryse.simard@inlibro.com |ity.org | CC| |maryse.simard@inlibro.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 96173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96173 Bug 24208: Remove change calculation for writeoffs Review of attachment 96173: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24208&attachment=96173) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +230,5 @@
<span class="debit">[% total | format('%.2f') %]</span> </li> <li> + [% IF type == 'WRITEOFF' %] + <label for="paid">Writeoff amount:</label>
You probably still need the trailing space here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This looks good at a quick glance.. but perhaps we could improve it further whilst we're here. It looks me like the form title is still 'Pay an amount toward selected fines'.. we could add a switch for this too `Writeoff an amount toward selected fines` perhaps? We also still show the 'Payment types' selection dropdown unless I'm mistaken.. that could also go on a writeoff action I imagine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96173|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96571&action=edit Bug 24208: Remove change calculation for writeoffs Bug 11373 added change calculation to the payment page. This doesn't work very well in the case of writeoffs: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. This patch removes these unwanted fields and use the "Writeoff amount" label on the right input. Test plan: 1) Choose a patron who has fees. You can add a manual invoice if necessary. 2) Go to Accounting > Make a payment. 3) Select some fines and click "Write off selected". 4) Note the form has a lot of inputs, not all are necessary for a writeoff. 5) Make a partial writeoff by entering a different amount in the "Writeoff amount" field. => The amount written off is the amount entered in the "Amount paid" field. 6) Apply patch. 7) Repeat steps 1-3. 8) Notice the form only has "Amount outstanding", "Writeoff amount" and "Note" fields, which are enough for a writeoff. 9) Entering any amount lower than or equal to the amount outstanding in the "Writeoff amount" field should create a writeoff of the selected amount. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96572&action=edit Bug 24208: (follow-up) Change page title from payment to writeoff This makes a change requested by the first tester: Also change the page title when a writeoff is done vs a payment. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96571|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96595&action=edit Bug 24208: Remove change calculation for writeoffs Bug 11373 added change calculation to the payment page. This doesn't work very well in the case of writeoffs: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. This patch removes these unwanted fields and use the "Writeoff amount" label on the right input. Test plan: 1) Choose a patron who has fees. You can add a manual invoice if necessary. 2) Go to Accounting > Make a payment. 3) Select some fines and click "Write off selected". 4) Note the form has a lot of inputs, not all are necessary for a writeoff. 5) Make a partial writeoff by entering a different amount in the "Writeoff amount" field. => The amount written off is the amount entered in the "Amount paid" field. 6) Apply patch. 7) Repeat steps 1-3. 8) Notice the form only has "Amount outstanding", "Writeoff amount" and "Note" fields, which are enough for a writeoff. 9) Entering any amount lower than or equal to the amount outstanding in the "Writeoff amount" field should create a writeoff of the selected amount. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96572|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96596&action=edit Bug 24208: (follow-up) Change page title from payment to writeoff This makes a change requested by the first tester: Also change the page title when a writeoff is done vs a payment. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- patchset doesn't clean apply to 19.05.x, please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22359 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 [Bug 22359] Improve usability of 'change calculation' (bug 11373) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 24893 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org