[Bug 18421] New: Make Coce cover images available for staff search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Bug ID: 18421 Summary: Make Coce cover images available for staff search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: arm@hanover.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When turned on, Coce cover images appear in the OPAC only, not staff interface. (Coce Cover images - settings in enhanced content.) Desired setting would be like Amazon cover settings - the ability to turn on Coce images for the OPAC and/or the staff interface separately. Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC. While the Coce server is being populated with links it is desirable to have only the staff interface using Coce. After a time, when the Coce server has accumulated a large collection of links, it would then be turned on for public OPAC and used by both. I have Koha 3.22.07, and am testing with the Bywater Coce server. If this is under way or in more recent versions already, please comment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com, | |eric.begin@inLibro.com Assignee|koha-bugs@lists.koha-commun |charles.farmer@inlibro.com |ity.org | --- Comment #1 from Charles Farmer <charles.farmer@inlibro.com> ---
When turned on, Coce cover images appear in the OPAC only, not staff interface. (Coce Cover images - settings in enhanced content.) Desired setting would be like Amazon cover settings - the ability to turn on Coce images for the OPAC and/or the staff interface separately.
There's a patch developed on our end that would offer just that: giving the option to control Coce's behavior separately between OPAC and the staff intranet. I'll join it to this bug instead of creating a new one.
Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC.
This is false, from what I understand. Coce is queried after the page is loaded, yes, but the results should be dynamically appended to the page if images were found. What might've happened on your end is multiple image providers returning empty results, which were in turn cached by redis and given back every time you made a subsequent request. In that case, it's more related to Coce's backend than Coce itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #2 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71322&action=edit Bug18421 - Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #3 from Agnes Rivers-Moore <arm@hanover.ca> --- (In reply to Charles Farmer from comment #1)
When turned on, Coce cover images appear in the OPAC only, not staff interface. (Coce Cover images - settings in enhanced content.) Desired setting would be like Amazon cover settings - the ability to turn on Coce images for the OPAC and/or the staff interface separately.
There's a patch developed on our end that would offer just that: giving the option to control Coce's behavior separately between OPAC and the staff intranet.
I'll join it to this bug instead of creating a new one.
Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC.
This is false, from what I understand.
Coce is queried after the page is loaded, yes, but the results should be dynamically appended to the page if images were found. What might've happened on your end is multiple image providers returning empty results, which were in turn cached by redis and given back every time you made a subsequent request.
In that case, it's more related to Coce's backend than Coce itself.
I am very glad this is being addressed, thank you! Re the behaviour - I found that none of the images would load when the search was initially done. However, paging forward and then returning, or repeating the search would load all the images (or almost all). If the search had been done before, and was done again, then images loaded right away in the search results, without needing a refresh. This behaviour is not consistent with your description of how Coce & Koha is expected to work - the images were not dynamically appended unless the page was refreshed in some way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #4 from Agnes Rivers-Moore <arm@hanover.ca> --- (In reply to Charles Farmer from comment #1)
When turned on, Coce cover images appear in the OPAC only, not staff interface. (Coce Cover images - settings in enhanced content.) Desired setting would be like Amazon cover settings - the ability to turn on Coce images for the OPAC and/or the staff interface separately.
There's a patch developed on our end that would offer just that: giving the option to control Coce's behavior separately between OPAC and the staff intranet.
I'll join it to this bug instead of creating a new one.
Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC.
This is false, from what I understand.
Coce is queried after the page is loaded, yes, but the results should be dynamically appended to the page if images were found. What might've happened on your end is multiple image providers returning empty results, which were in turn cached by redis and given back every time you made a subsequent request.
In that case, it's more related to Coce's backend than Coce itself.
I am very glad this is being addressed, thank you! Re the behaviour - I found that none of the images would load when the search was initially done. However, paging forward and then returning, or repeating the search would load all the images (or almost all). If the search had been done before, and was done again, then images loaded right away in the search results, without needing a refresh. This behaviour is not consistent with your description of how Coce & Koha is expected to work - the images were not dynamically appended unless the page was refreshed in some way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #5 from Charles Farmer <charles.farmer@inlibro.com> --- Because of the variables involved in the deployment of Coce -- the koha version, the nodejs version, whether passenger is used or not for clustering, the communication with the in-memory cache behind, the webserver that might be used to proxy to the app, etc. -- it can get finicky real quick. Without detailed information about your particular setup, I would recommend opening a new bug ticket, since you feel confident about the reproducibility of this issue on your end. I'd be more than happy to look over your setup :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #6 from Agnes Rivers-Moore <arm@hanover.ca> --- I appreciate the response, many thanks. We are planning an upgrade in the next few months - perhaps the behaviour will change after that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71322|0 |1 is obsolete| | --- Comment #7 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71977&action=edit Bug18421 - Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71977|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 72772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72772&action=edit Bug18421 - Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72772|0 |1 is obsolete| | --- Comment #9 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 73401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73401&action=edit Bug18421 - Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #10 from Charles Farmer <charles.farmer@inlibro.com> --- Rebased C4/Auth.pm over the latest master: conflict over an end-of-line comma. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 73401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73401 Bug18421 - Add Coce to the staff intranet Review of attachment 73401: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18421&attachment=73401) ----------------------------------------------------------------- Hi, I've added comments to the splinter review. The database update doesn't look clean to me, please revise and take a look here: https://wiki.koha-community.org/wiki/Database_updates ::: C4/Auth.pm @@ +504,5 @@
+ useDischarge => C4::Context->preference('useDischarge'), + KOHA_VERSION => C4::Context->preference('Version'), + CoceIntranet => C4::Context->preference('CoceIntranet'), + CoceProviders => C4::Context->preference('CoceProviders'), + CoceHost => C4::Context->preference('CoceHost'),
Please use the TT plugin for dealing with the preferences in the templates instead, like it's already done for the OPAC. ::: installer/data/mysql/atomicupdate/bug_18421_add_coce_intranet.perl @@ +1,4 @@
+#! /usr/bin/perl + +use strict; +use warnings;
Please always use Modern::Perl instead. @@ +2,5 @@
+ +use strict; +use warnings; +use C4::Context; +use Data::Dumper;
Should not be here. @@ +20,5 @@
+ $current_coce_pref = $rows->{Coce}->{value}; +} + +# add two new systempreferences in order to have distinct behavior between intranet and OPAC +$dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES
Please always use INSERT IGNORE when adding system preferences. @@ +26,5 @@
+ ('CoceOPAC','$current_coce_pref', NULL, 'If on, enables cover retrieval from the configured Coce server in the OPAC', 'YesNo') + ;") or die "Impossible d\'executer cam5446_ajouter_coce_intranet: erreur lors de l'ajout des nouvelles prefs: ". $dbh->errstr . "\n"; +$dbh->do("DELETE FROM systempreferences WHERE variable = 'Coce';") + or die "Impossible d\'executer cam5446_ajouter_coce_intranet: erreur lors de la suppression de la préférence 'Coce': ". $dbh->errstr . "\n"; +print "cam5446: Add Coce image cache to the staff intranet.\n";
Please use bugzilla bug numbers in your update message. ::: installer/data/mysql/sysprefs.sql @@ +108,5 @@
('CircControl','ItemHomeLibrary','PickupLibrary|PatronLibrary|ItemHomeLibrary','Specify the agency that controls the circulation and fines policy','Choice'), ('CircSidebar','0',NULL,'Activate or deactivate the navigation sidebar on all Circulation pages','YesNo'), ('ClaimsBccCopy','0','','Bcc the ClaimAcquisition and ClaimIssues alerts','YesNo'), +('CoceIntranet','0', NULL, 'If on, enables cover retrieval from the configured Coce server in the staff intranet', 'YesNo'), +('CoceOPAC','0', NULL, 'If on, enables cover retrieval from the configured Coce server in the OPAC', 'YesNo'),
Please always sort prefs alphabetically in this file. Also to be consistent with other prefs, it would be good to switch that: OpacCoce, IntranetCoce (see other prefs for examples: *AmazonCoverImages, *NumbersPreferPhrase, ..) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73401|0 |1 is obsolete| | --- Comment #12 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 73495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73495&action=edit Bug18421 - Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #13 from Charles Farmer <charles.farmer@inlibro.com> --- I've read your comments and applied them accordingly. Only thing bothering me is the IGNORE. I don't know much about SQL, but aren't we trying to avoid MySQLism? Is this something supported by other database vendors? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Charles Farmer from comment #13)
I've read your comments and applied them accordingly.
Only thing bothering me is the IGNORE. I don't know much about SQL, but aren't we trying to avoid MySQLism? Is this something supported by other database vendors?
The updatedatabase file is mysql specific (it's even lives in a directory called mysql...). But in general you are right of course. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73495|0 |1 is obsolete| | --- Comment #15 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 74252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74252&action=edit Bug18421 - Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Charles, please always add a separate follow-up patch with changes requested by QA and then switch back to 'signed off' if not requested otherwise. This way you often don't need to go through the sign-off process again. But if you change the initial patch like here, it's good to ask for a new sign-off as the old one is basically 'invalid'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- The QA tool shows some issues with this: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 62) forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 890) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 25) I notice in results.tt: [% Asset.js("prog/js/coce.js") %] should be [% Asset.js("js/coce.js") %] I'd also like to see this modified to use the term "staff client" instead of "intranet," according to our terminology guidelines: https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #18 from Charles Farmer <charles.farmer@inlibro.com> --- Thank you very much for you reply Owen. When you asked to change the keyword 'Intranet' to 'Staff client', were you talking about strings in the interface, or did you mean to go all the way and the change the syspref's name? I'll patch this right away. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #19 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 77597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77597&action=edit Bug 18421: (QA follow-up) Use the community's terminology, change coce.js's path, update <script> to Asset, remove forbidden patterns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74252|0 |1 is obsolete| | --- Comment #20 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 77598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77598&action=edit Bug18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77597|0 |1 is obsolete| | --- Comment #21 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 77599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77599&action=edit Bug 18421: (QA follow-up) Use the community's terminology, change coce.js's path, update <script> to Asset, remove forbidden patterns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Looks good to me, but still some complaints from the QA script: FAIL koha-tmpl/intranet-tmpl/prog/js/coce.js FAIL git manipulation The file has been added and deleted in the same patchset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Charles Farmer <charles.farmer@inlibro.com> --- Wait, `git mv` is now seen as an erroneous operation?! What am I supposed to do about that? Delete in one patch and submit the _same exact_ file in another one? I mean, I'm all for the QA script, but this seems questionable, for lack of a better adjective. Putting it back at 'Signed Off', it's an operation that had to be done. If, however, you wring my arm, I'll split it in two distinct patches :/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77598|0 |1 is obsolete| | Attachment #77599|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77764&action=edit Bug18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77765&action=edit Bug 18421: (QA follow-up) Use the community's terminology, change coce.js's path, update <script> to Asset, remove forbidden patterns Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Charles Farmer from comment #23)
Wait, `git mv` is now seen as an erroneous operation?!
I'll leave that up to QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's just a warning about something that could easily be confusing or a mistake: FAIL koha-tmpl/intranet-tmpl/prog/js/coce.js FAIL git manipulation The file has been added and deleted in the same patchset Usually, if it's an option (same authors, sign-offers on the patches) you can resolve that by squashing the patches. Then the file won't ever be added instead of being added to be removed with the next patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #28 from Charles Farmer <charles.farmer@inlibro.com> --- Thanks for the explanation Katrin, it does make sense. Though I feel like in that instance, it begs the question "why should we submit (QA follow-up) patches in the first place"? Either I'm squashing changes, and losing the distinctive history that follow-up patches bring (and signoffs, if any), or I'm breaking the QA script... Sorry for digressing here, it's more a discussion for the dev list :) If I had to make a suggestion, it would be to lower this 'warning' from FAIL to something else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd not insist on squashing per se - there are reasons when it might not make sense. I haven't taken a closer look at those patches (can't test coce), but signed off is good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Charles, you can discuss any "failures" from the QA checks. It is hard to test all the situations without false positives. Here, as Katrin said, we prefer to not add and remove a file in the same patchset. RM or QA will squash the patches if it is really needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick notes: 1. We hit the same problem as local cover on bug 19511 2. FIXME in .js, but copied from the OPAC one (not blocker) 3. Will fail tests bug 13618 is going to add (should be pushed very soon). Filters are missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice@biblibre.com --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Patches do not apply, and fixes are needed (comment 31). Changing status to Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77764|0 |1 is obsolete| | Attachment #77765|0 |1 is obsolete| | --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80137&action=edit Bug 18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80138&action=edit Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path, update <script> to Asset, remove forbidden patterns Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80139&action=edit Bug 18421: (follow-up) Adding missing filters This patch adds template filters as prompted by the QA tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80137|0 |1 is obsolete| | --- Comment #36 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 83633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83633&action=edit Bug 18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80138|0 |1 is obsolete| | --- Comment #37 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 83634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83634&action=edit Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path, update <script> to Asset, remove forbidden patterns Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80139|0 |1 is obsolete| | --- Comment #38 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 83635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83635&action=edit Bug 18421: (follow-up) Adding missing filters This patch adds template filters as prompted by the QA tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #39 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 83636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83636&action=edit Bug 18421: (follow-up) Center image in results table Adds the "thumbnail" class to the image to have it centered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #40 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Nice work, I'd like to sign. But patches have conflicts in : koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt (complex) koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt (trivial) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83633|0 |1 is obsolete| | --- Comment #41 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91552&action=edit Bug 18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83634|0 |1 is obsolete| | --- Comment #42 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91553&action=edit Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path, update <script> to Asset, remove forbidden patterns Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83635|0 |1 is obsolete| | --- Comment #43 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91554&action=edit Bug 18421: (follow-up) Adding missing filters This patch adds template filters as prompted by the QA tool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83636|0 |1 is obsolete| | --- Comment #44 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91555&action=edit Bug 18421: (follow-up) Center image in results table Adds the "thumbnail" class to the image to have it centered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |maryse.simard@inlibro.com --- Comment #45 from Maryse Simard <maryse.simard@inlibro.com> --- Patches rebased and ready to be tested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91552|0 |1 is obsolete| | --- Comment #46 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91786&action=edit Bug 18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91553|0 |1 is obsolete| | --- Comment #47 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91787&action=edit Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path, update <script> to Asset, remove forbidden patterns Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91554|0 |1 is obsolete| | --- Comment #48 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91788&action=edit Bug 18421: (follow-up) Adding missing filters This patch adds template filters as prompted by the QA tool. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91555|0 |1 is obsolete| | --- Comment #49 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91789&action=edit Bug 18421: (follow-up) Center image in results table Adds the "thumbnail" class to the image to have it centered. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alexbuckley@catalyst.net.nz --- Comment #50 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Tested and all works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91786|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93654&action=edit Bug 18421: Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91787|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93655&action=edit Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path, update <script> to Asset, remove forbidden patterns Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91788|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93656&action=edit Bug 18421: (follow-up) Adding missing filters This patch adds template filters as prompted by the QA tool. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91789|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93657&action=edit Bug 18421: (follow-up) Center image in results table Adds the "thumbnail" class to the image to have it centered. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25369 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25369 [Bug 25369] IntranetCoce not displaying Cover Images on Staff Client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25869 [Bug 25869] Coce images not loading for lists (virtualshelves) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25924 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25924 [Bug 25924] Broken link on Coce image in staff interface bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org