[Bug 34572] New: Simplify template logic around check-in input form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Bug ID: 34572 Summary: Simplify template logic around check-in input form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Fridolin writes in Bug 34289 comment 5: Since we have now : [% IF ( exemptfine ) %] <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" type="text" /> [% ELSIF ( dropboxmode ) %] <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" /> [% ELSE %] There is no difference between those two lines since type="text" is default behavior. Maybe merge into [% IF ( exemptfine || dropboxmode ) %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154589&action=edit Bug 34572: Simplify template logic around check-in input form This patch makes a minor simplifying change to the check-in template around how to style the barcode input field in dropbox or fine-exempt mode. To test, apply the patch and go to Circulation. - If necessary, check some items out to patrons so that you have items to check in. - Go to the check-in page and click the icon inside the barcode field to expand the panel of options. - Check the "book drop mode" checkbox. The barcode field should now be highlighted yellow. - Check in an item. When the page redisplays, the barcode field should have the same highlighted style. - If necessary, enable the finesMode system preference. - On the check-in page, in the panel of options, check the "Forgive overdue fines" checkbox. Test checking in again, confirming the same style consistency in the barcode field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154589|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154639&action=edit Bug 34572: Simplify template logic around check-in input form This patch makes a minor simplifying change to the check-in template around how to style the barcode input field in dropbox or fine-exempt mode. To test, apply the patch and go to Circulation. - If necessary, check some items out to patrons so that you have items to check in. - Go to the check-in page and click the icon inside the barcode field to expand the panel of options. - Check the "book drop mode" checkbox. The barcode field should now be highlighted yellow. - Check in an item. When the page redisplays, the barcode field should have the same highlighted style. - If necessary, enable the finesMode system preference. - On the check-in page, in the panel of options, check the "Forgive overdue fines" checkbox. Test checking in again, confirming the same style consistency in the barcode field. Signed-off-by: Inkeri <inkeri.hakulinen@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |inkeri.hakulinen+bugz@helsi | |nki.fi --- Comment #3 from Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> --- Seems to work alright. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154639|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154811&action=edit Bug 34572: Simplify template logic around check-in input form This patch makes a minor simplifying change to the check-in template around how to style the barcode input field in dropbox or fine-exempt mode. To test, apply the patch and go to Circulation. - If necessary, check some items out to patrons so that you have items to check in. - Go to the check-in page and click the icon inside the barcode field to expand the panel of options. - Check the "book drop mode" checkbox. The barcode field should now be highlighted yellow. - Check in an item. When the page redisplays, the barcode field should have the same highlighted style. - If necessary, enable the finesMode system preference. - On the check-in page, in the panel of options, check the "Forgive overdue fines" checkbox. Test checking in again, confirming the same style consistency in the barcode field. Signed-off-by: Inkeri <inkeri.hakulinen@helsinki.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org