[Bug 15847] New: Correct JSHint errors in basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Bug ID: 15847 Summary: Correct JSHint errors in basket.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: hector.hecaxmmx@gmail.com, testopia@bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in basket.js basket.js: line 53, col 36, Use '===' to compare with '0'. basket.js: line 85, col 42, Missing semicolon. basket.js: line 210, col 5, Implied eval. Consider passing a function instead of a string. basket.js: line 219, col 44, Missing semicolon. basket.js: line 243, col 46, Missing semicolon. basket.js: line 251, col 29, Use '===' to compare with '0'. basket.js: line 270, col 13, 'valCookie' is already defined. basket.js: line 305, col 13, Use '===' to compare with 'undefined'. basket.js: line 409, col 25, The array literal notation [] is preferable. basket.js: line 416, col 25, Use '===' to compare with '0'. basket.js: line 432, col 33, Missing semicolon. basket.js: line 1, col 11, Missing semicolon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Correct JSHint errors in |Correct JSHint errors in |basket.js |basket.js in the staff | |client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48195&action=edit Bug 15847 - Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48195|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48197&action=edit [SIGNED-OFF]Bug 15847: Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No warnigns raised with jshint tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48197|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48206&action=edit Bug 15847: Correct JSHint errors in basket.js in the staff client This patch corrects minor errors in the staff client's basket.js according to warnings raised by JSHint. To test, apply the patch and run JSHint on basket.js. No warnings should be raised. To confirm that the behavior of the JS is not changed, clear your browser cache if necessary and: - Test adding multiple titles to the Cart from staff client search results. - Confirm that adding titles to the Cart triggers a message by the Cart link. - Test clicking the "Cart" link in the header menu when the Cart popup is open but behind the main window. - Testing emptying the Cart. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. No warnigns raised with jshint tool Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- pushed to master - should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15847 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org