https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Failed to apply patch Bug 22102 - Markup fixes for OPAC article request page 83802 - Bug 22102: Markup fixes for OPAC article request page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22102: Markup fixes for OPAC article request page fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt). error: could not build fake ancestor Patch failed at 0001 Bug 22102: Markup fixes for OPAC article request page The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22102-Markup-fixes-for-OPAC-article-request-pa-j8mImP.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83802|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83888&action=edit Bug 22102: Markup fixes for OPAC article request page This patch makes a few improvements to the OPAC article request page: - Improve the breadcrumbs menu by adding a link to the title - Add a header with the record's title - Wrap the "no article requests" message in the correct dialog div - Remove obsolete CDATA marker To test, apply the patch and log in to the OPAC - Peform a search which will return multiple results - Click "Request article" on a title for which article requests can be submitted. - Confirm that the breadcrumbs menu looks and works correctly. - Click "Request article" on a title for which article requsts are not allowed. - Confirm that the message is correctly styled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83888|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 84227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84227&action=edit Bug 22102: Markup fixes for OPAC article request page This patch makes a few improvements to the OPAC article request page: - Improve the breadcrumbs menu by adding a link to the title - Add a header with the record's title - Wrap the "no article requests" message in the correct dialog div - Remove obsolete CDATA marker To test, apply the patch and log in to the OPAC - Peform a search which will return multiple results - Click "Request article" on a title for which article requests can be submitted. - Confirm that the breadcrumbs menu looks and works correctly. - Click "Request article" on a title for which article requsts are not allowed. - Confirm that the message is correctly styled. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84227|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84236&action=edit Bug 22102: Markup fixes for OPAC article request page This patch makes a few improvements to the OPAC article request page: - Improve the breadcrumbs menu by adding a link to the title - Add a header with the record's title - Wrap the "no article requests" message in the correct dialog div - Remove obsolete CDATA marker To test, apply the patch and log in to the OPAC - Peform a search which will return multiple results - Click "Request article" on a title for which article requests can be submitted. - Confirm that the breadcrumbs menu looks and works correctly. - Click "Request article" on a title for which article requsts are not allowed. - Confirm that the message is correctly styled. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.