[Bug 6740] New: can add items at ordering but not remove items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Bug #: 6740 Summary: can add items at ordering but not remove items Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=2&ba sketno=5&biblionumber=307096 OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org There used to be a minus sign on the ordering screen to remove your extra items if you clicked the plus too many times. That needs to come back. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 16:02:49 UTC --- Nicole, I just tested on a 3.6.0, and the minus sign is here, and works (I agree it's smaller than the + Also note it appears only when you have the 2nd item created (which is logical) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 22:18:45 UTC --- Created attachment 6067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6067 screenshot Hi Paul, I retested this on 3.6 now and I still can see no minus. I was ordering from a suggestion, see attached screenshot -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-01 04:41:26 UTC --- I tried again, and it works again... What I did : * adding a line from a suggestion, no ACQ framework * adding a line from a suggestion, with ACQ framework * tried in both french and english I attach my screenshot (with the URL) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-01 04:42:30 UTC --- Created attachment 6127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6127 screenshot of working setup this screenshot shows a small minut on the right of the second + -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-01 08:15:17 UTC --- Could it be the MARC flavor? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-01 08:48:56 UTC --- I can't imagine a relation with MARC here. Here is the code : <a style="cursor: pointer; color: grey; font-size: 180%;" onclick="cloneItemBlock('itemblock[% item.itemBlockIndex %]')">+</a> <a style="display:none; cursor: pointer; color: grey; font-size: 180%;" onclick="deleteItemBlock('itemblock[% item.itemBlockIndex %]')">-</a> => the - is not displayed by default (ie : when only 1 item ordered). It's displayed when clicking +, by the cloneItemBlock sub (in js/additem.js) . This sub contains : CloneButtonMinus.setAttribute('onclick',"deleteItemBlock('" + index + random + "')"); CloneButtonMinus.setAttribute('style',"display:inline"); without any specific condition. an idea: is there a javascript error that appears when you click on the + ? (ie: a JS error could stop the js engine, just after duplicating the item) Other idea: could it be a css problem (ie: do you have a css for staff ?) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-01 09:13:30 UTC --- Started retesting... 1) Testing on master, 'almost' fresh database, no customizations 2) AcqCreateItem is set to 'on order' 3) Started a new basket, added one order from suggestion 4) Clicked + 2 times, a total of 3 item forms showing on the page 5) No minus sign shows Source code at the end of my third item form looks like this: <a style="display:none; cursor: pointer; color: grey; font-size: 180%;" onclick="deleteItemBlock('itemblock')">-</a> Firebug shows me no javascript errors or warnings. I am using an ACQ framework and only working with the English templates. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-01 09:20:49 UTC --- Created attachment 6129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6129 screenshot of firebug output I played with the settings for firebug some more and it gave me some warnings. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-01 09:25:16 UTC --- (In reply to comment #7)
Started retesting...
1) Testing on master, 'almost' fresh database, no customizations 2) AcqCreateItem is set to 'on order' 3) Started a new basket, added one order from suggestion same thing when you add an order from another source ? (empty/existing/z3950/imported record ?)
Source code at the end of my third item form looks like this: <a style="display:none; cursor: pointer; color: grey; font-size: 180%;" onclick="deleteItemBlock('itemblock')">-</a> This one is OK. The HTML don't show you what javascript can have done.
Firebug shows me no javascript errors or warnings. that's very bad news... Are you able to track if the cloneItemBlock is called by adding some alert('I am here'); in some places in the code? It should show a popup everytime you click on the +
this is really strange... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-01 09:26:51 UTC --- seen you new comment now... interesting. Please discard my previous comment. The elem[] is probably related to ACQ framework, i'm investigating (not now, at the conference, but that's a strong candidate). It would not be related to MARC flavor but to framework setup. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-01 10:55:17 UTC --- mmm... more and more strange... Katrin, could you try to un-activte firebug and see if it's does not fix the problem ? I (a long time ago) saw firebug introducing a problem that did not exist without it. I still can't reproduce your problem, and the "reference to undefined property fbs.breakOnDebugCall" seems suspicious to me... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-01 11:06:13 UTC --- Hi Paul, that's because I activated lots of things to give me at least some warnings. It does not work with and without firebug. Others like Nicole have been able to reproduce this problem. Perhaps check on a different installation? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-01 11:14:58 UTC --- OK, bywater demo site has the problem as well : http://intranet.bywatersolutions.com/cgi-bin/koha/acqui/neworderempty.pl?booksellerid=3&basketno=4 (login/pwd: bywater/bywater) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> 2011-11-05 19:27:19 UTC --- I've seen the issue on my install as well as several other MARC21 libraries - so it is still an issue for me as well. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-16 08:18:00 UTC --- Paul, is there an update on this? It's an important feature that is broken right now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-05 05:55:00 UTC --- Ok, I think I have the reason and a possible fix. The reason: The function for cloning looks for the first and second <a> element in the <div> block of the item in order to change the parameter to include a unique number and make the minus link show. The problem here is, that you can use an undefined number of plugins within your ACQ framework now, that will create more <a> tags so looking for element number x will no longer work. (Plugins added: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=e5ff05857e5b99ab...) But the good news is, now it all makes sense :) Paul couldn't reproduce this, because he had no plugins in his framework. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-05 06:31:02 UTC --- Created attachment 6571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6571 Bug 6740: can add items at ordering/receiving but not remove The problem was, that the script was looking for the first and second <a> tag in the code. When using plugins in the framework this can't work. The patch changes the script to select the correct <a> tags by using a class. Also changes + and - to 'Add' and 'Delete' to make the meaning clearer and clicking on them a bit easier. To test: 1) AcqCreateItem = order - Create a basket - Create an order line - Create more than one item - Delete items - Check quantity is calculated correctly - Check items are created correctly 2) AcqCreateItem = receive - Create basket - Create 2 order lines, order >1 items - Do a partial item by removing items from the receive form - Receive all missing items - Receive more items than ordered -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|henridamien@koha-fr.org |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6571|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> 2011-12-05 15:36:05 UTC --- Created attachment 6581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6581 Signed-off patch Tested both test plans and found both to be working properly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-05 21:43:48 UTC --- Wonderfull Katrin ! you probably got it ! I'll QA this patch tomorrow, when waiting for my plane to go back home. It's a little bit late for now, heading to bed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 18:09:27 UTC --- QA comment : nothing specific to say. Clean patch, works as announced, no side effect I can see. patch pushed, please test cait, this one is worth a special award ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org