[Bug 8391] New: Cannot view reading record through staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Priority: P5 - low Change sponsored?: --- Bug ID: 8391 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Cannot view reading record through staff client Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall@gmail.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Through the staff client, circulation histroy results in an error message. In circulation, after retrieving a borrower record, click on the "Circulation History" button on the left hand side of the page. The below error message is a result: Software error: The 'month' parameter ("0") to DateTime::new did not pass the 'an integer between 1 and 12' callback at /usr/lib/perl5/DateTime.pm line 194 DateTime::new(undef, 'hour', 00, 'minute', 00, 'month', 0, 'second', 0, ...) called at /usr/share/perl5/DateTime/Format/DateParse.pm line 58 DateTime::Format::DateParse::parse_datetime('DateTime::Format::DateParse', '0000-00-00 00:00:00', 'America/Los_Angeles') called at /usr/share/koha/lib/Koha/DateUtils.pm line 86 Koha::DateUtils::dt_from_string('0000-00-00 00:00:00', 'sql') called at /usr/share/koha/lib/Koha/DateUtils.pm line 160 Koha::DateUtils::format_sqldatetime('0000-00-00 00:00:00') called at /usr/share/koha/intranet/cgi-bin/members/readingrec.pl line 80 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle.m.hall@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10713&action=edit Bug 8391 - Cannot view reading record through staff client This bug reveals itself when attempting to view the reading record of a borrower who currently has items checked out. Readingrec.pl attempts to format the returndate field for both old and current issues, even though current issues have no returndate. This is what is causing the error. Resolved by adding a conditional to check for a valid date before formatting said date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> ---
This bug reveals itself when attempting to view the reading record of a borrower who currently has items checked out.
In the issues table, I have returndate=NULL. How do you manage to fill this value with '0000-00-00 00:00:00' ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- I also have this issue. However, I have what I think is a fix in a more appropriate place (that is, it will sold this problem in more than just a single location.) This occurs for me with some old data when the item was never returned (e.g. lost) and the returndate in old_issues ended up being 0000-00-00 00:00:00. Items checked out correctly have NULL for me. A side effect of this (which is probably best fixed separately) is that things that are lost will say "Checked Out" rather than "Lost" or similar. I will attach my patch (it's more or less the same thing in spirit.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 11155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11155&action=edit Bug 8391: prevent error when viewing circ history with bad dates Sometime the circ history will contain "0000-00-00" as a returndate when an item was lost rather than returned. This currently causes an error when attempting to parse the dates, this patch causes an empty string to be returned instead. Note: a future enhancement should distinguish between "no date provided" and "invalid date provided" to allow distinctions to be made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10713|0 |1 is obsolete| | Attachment #11155|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 11203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11203&action=edit Bug 8391: prevent error when viewing circ history with bad dates Sometime the circ history will contain "0000-00-00" as a returndate when an item was lost rather than returned. This currently causes an error when attempting to parse the dates, this patch causes an empty string to be returned instead. Note: a future enhancement should distinguish between "no date provided" and "invalid date provided" to allow distinctions to be made. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: return undef or an empty string if the argument is empty or equal "0000-00-00" Marking as Passed QA see Bug 8532 (same modification for the routine output_pref). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.4, leaving set to Passed QA so Paul can push to master when he is back -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master Note that it could solve some errors in other places as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org