[Bug 32799] New: ILLSTATUS authorized value category name is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Bug ID: 32799 Summary: ILLSTATUS authorized value category name is confusing Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com Bug 20581 introduced the ability to manually select custom ILL request statuses. These custom ILL request statuses are stored in the ILLSTATUS AV and are then stored in the status_alias column of illrequests. Staff members are lead to believe that ILL statuses are stored in the ILLSTATUS authorized values list when these are just aliases used for display purposes. The actual ILL statuses are fed from the backend or Koha::Illrequest. My suggestion would be rename this to ILL_STATUS_ALIAS or ILL_STATUS_ALIASES -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146452&action=edit Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146452|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146453&action=edit Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias 12) Manage the request again and verify that the ILL request log shows the status descriptions correctly 13) Verify the description of the ILLHiddenRequestStatuses has been updated with the new authorised value category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I hope I thought of everything - please test well! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146453|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 146487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146487&action=edit Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias 12) Manage the request again and verify that the ILL request log shows the status descriptions correctly 13) Verify the description of the ILLHiddenRequestStatuses has been updated with the new authorised value category Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thank you Katrin, yes. I believe your patch also addresses bug 32795. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks, Pedro! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146487|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147171&action=edit Bug 32799: Rename ILLSTATUS authorised value category to ILL_STATUS_ALIAS To test: 1) Activate the IllModule system preference 2) Install a backend (BLDSS or FreeForm) following the wiki instructions: 3) Configure some authorised values for ILLSTATUS 4) Apply patch 5) Run database update 6) Verify your configured values have been updated to ILL_STATUS_ALIAS 7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the categories list 8) Go to the ILL module and add a new request 9) Edit the request, verify that your status alias show in the status list 10) Set one of your status and save 11) Verify that the ILL requests list search filters show your status alias 12) Manage the request again and verify that the ILL request log shows the status descriptions correctly 13) Verify the description of the ILLHiddenRequestStatuses has been updated with the new authorised value category Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 --- Comment #9 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32799 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/685 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org