[Bug 28639] New: Embed see-from headings (from authorities) into bibliographic records at OAI repository level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Bug ID: 28639 Summary: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: julien.sicot@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org Hi, It could be interesting to enrich the bibliographic records exposed in OAI with see-from headings, this would allow users who use koha with a discovery tool to be able to manage, normalize and index some authorities data ? This is something that could be done directly in C4::Biblio::GetMarcBiblio following the same method used for embedding items. We could use an optional parameter like embed_items (embed_seefromheading) and a function similar to C4::Biblio::EmbedItemsInMarcBiblio by reusing what was made for zebra with EmbedSeeFromHeadings (bug #7417). Thanks for feedback, Best Julien Sicot Systems Librarian, Université Rennes 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Julien Sicot (Univ. Rennes 2) <julien.sicot@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julien.sicot@univ-rennes2.f | |r --- Comment #1 from Julien Sicot (Univ. Rennes 2) <julien.sicot@univ-rennes2.fr> --- Created attachment 122500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122500&action=edit Bug 28639 - Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Enable OAI-PMH:EmbedSeeFromInBibRecord 7. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #2 from Ere Maijala <ere.maijala@helsinki.fi> --- I think the setting should be in the oai.conf file instead of a syspref. The conf file would allow you to make it format-specific instead of a global setting. You could e.g. setup a new metadataPrefix marc21_with_auth that would include the see-from headings while keeping the normal marc21 format intact. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Nice. But why not using like rebuild_zebra.pl Koha::RecordProcessor and Koha::Filter::MARC::EmbedSeeFromHeadings ? Code looks the same no ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31286 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122500|0 |1 is obsolete| | --- Comment #4 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 142296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142296&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Enable OAI-PMH:EmbedSeeFromInBibRecord 7. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142296|0 |1 is obsolete| | --- Comment #5 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 142297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142297&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Run perl installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl 7. Enable OAI-PMH:EmbedSeeFromInBibRecord 8. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m --- Comment #6 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Julien Sicot (Univ. Rennes 2) from comment #0)
Hi,
It could be interesting to enrich the bibliographic records exposed in OAI with see-from headings, this would allow users who use koha with a discovery tool to be able to manage, normalize and index some authorities data ?
This is something that could be done directly in C4::Biblio::GetMarcBiblio following the same method used for embedding items. We could use an optional parameter like embed_items (embed_seefromheading) and a function similar to C4::Biblio::EmbedItemsInMarcBiblio by reusing what was made for zebra with EmbedSeeFromHeadings (bug #7417).
Thanks for feedback, Best Julien Sicot Systems Librarian, Université Rennes 2
Thanks to you, I just rebase your proposal on master updated and add a atomic update file. I just call Koha::Filter::MARC::EmbedSeeFromHeadings on OAI server side to show or hide embed see-from headings. I could not test your development due to an error so I hope that the intended behaviour remains the same. Please let me know if not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hi, Atomic update is incorrect : + INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) + VALUES ( + 'EmbedSeeFromInBibRecord', '0', NULL, 'Add embed see-from headings for OAI', 'YesNo' Value should be OAI-PMH:EmbedSeeFromInBibRecord Also : + Koha::Filter::MARC::EmbedSeeFromHeadings->filter($record); Does this work ? Other call use the RecordProcessor : https://git.koha-community.org/Koha-community/Koha/src/commit/a57278f39b8c5b... Best regards, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142297|0 |1 is obsolete| | --- Comment #8 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 144821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144821&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Run perl installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl 7. Enable OAI-PMH:EmbedSeeFromInBibRecord 8. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #9 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 144822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144822&action=edit Bug 28639: (follow_up) changing syspref name on atomic update file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #10 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Fridolin Somers from comment #7)
Hi,
Atomic update is incorrect : + INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) + VALUES ( + 'EmbedSeeFromInBibRecord', '0', NULL, 'Add embed see-from headings for OAI', 'YesNo'
Value should be OAI-PMH:EmbedSeeFromInBibRecord
Also :
+ Koha::Filter::MARC::EmbedSeeFromHeadings->filter($record);
Does this work ? Other call use the RecordProcessor :
https://git.koha-community.org/Koha-community/Koha/src/commit/ a57278f39b8c5b7a82b21671f266dbf32e2d41a0/t/db_dependent/ RecordProcessor_EmbedSeeFromHeadings.t#L60
Best regards,
Hi Fridolin :) Thanks for your reply ! Yes I miss this thing, I fix that by follow-up. And I also rebased on 'fresh' master ^^ For this : + Koha::Filter::MARC::EmbedSeeFromHeadings->filter($record); It works as intended apparently but you put me in doubt.. did you test it ? Maybe I miss something -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Thibaud Guillot from comment #10)
(In reply to Fridolin Somers from comment #7)
For this :
+ Koha::Filter::MARC::EmbedSeeFromHeadings->filter($record);
It works as intended apparently but you put me in doubt.. did you test it ? Maybe I miss something
I did not test it but since other calls are different. We try to have same code syntax for clarity. Great job btw ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #12 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 144857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144857&action=edit Bug 28639: (follow-up) Changes method to embed see-from headings To have same code syntax call of Koha::RecordProcessor class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #13 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Fridolin Somers from comment #11)
(In reply to Thibaud Guillot from comment #10)
(In reply to Fridolin Somers from comment #7)
For this :
+ Koha::Filter::MARC::EmbedSeeFromHeadings->filter($record);
It works as intended apparently but you put me in doubt.. did you test it ? Maybe I miss something
I did not test it but since other calls are different. We try to have same code syntax for clarity.
Great job btw ;)
Oh okay, thanks, you're right, I replace it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- This no longer applies cleanly to current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144821|0 |1 is obsolete| | --- Comment #15 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 171973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171973&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Run perl installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl 7. Enable OAI-PMH:EmbedSeeFromInBibRecord 8. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144822|0 |1 is obsolete| | --- Comment #16 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 171974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171974&action=edit Bug 28639: (follow_up) changing syspref name on atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144857|0 |1 is obsolete| | --- Comment #17 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 171975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171975&action=edit Bug 28639: (follow-up) Changes method to embed see-from headings To have same code syntax call of Koha::RecordProcessor class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #18 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(.. git bz apply 28639 Bug 28639 - Embed see-from headings (from authorities) into bibliographic records at OAI repository level 171973 - Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level 171974 - Bug 28639: (follow_up) changing syspref name on atomic update file 171975 - Bug 28639: (follow-up) Changes method to embed see-from headings Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Using index info to reconstruct a base tree... M Koha/OAI/Server/Repository.pm M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql Auto-merging Koha/OAI/Server/Repository.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171973|0 |1 is obsolete| | --- Comment #19 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186023&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Run perl installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl 7. Enable OAI-PMH:EmbedSeeFromInBibRecord 8. Go again to the OAI record, you should see alternative forms at the end of the record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171974|0 |1 is obsolete| | --- Comment #20 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186024&action=edit Bug 28639: (follow_up) changing syspref name on atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171975|0 |1 is obsolete| | --- Comment #21 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186025&action=edit Bug 28639: (follow-up) Changes method to embed see-from headings To have same code syntax call of Koha::RecordProcessor class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #22 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186026&action=edit Bug 28639: (follow-up) Fix atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #23 from Mathieu Saby <mathsabypro@gmail.com> --- It works as described I added the subject "Liberty" <datafield ind2="0" ind1="" tag="650"> <subfield code="a">Liberty</subfield> <subfield code="9">1708</subfield> </datafield> With the new syspref activated, a supplementary 650 field is added at the end of the record, with the "see from" value, the 1st indicator is "z" <datafield ind2="" ind1="z" tag="650"> <subfield code="a">Freedom</subfield> </datafield> Same behavior with a 2d see from form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186023|0 |1 is obsolete| | --- Comment #24 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 186052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186052&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Run perl installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl 7. Enable OAI-PMH:EmbedSeeFromInBibRecord 8. Go again to the OAI record, you should see alternative forms at the end of the record Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186024|0 |1 is obsolete| | --- Comment #25 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 186053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186053&action=edit Bug 28639: (follow_up) changing syspref name on atomic update file Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186025|0 |1 is obsolete| | --- Comment #26 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 186054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186054&action=edit Bug 28639: (follow-up) Changes method to embed see-from headings To have same code syntax call of Koha::RecordProcessor class Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186026|0 |1 is obsolete| | --- Comment #27 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 186055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186055&action=edit Bug 28639: (follow-up) Fix atomic update file Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- File is not tidy, please run `perl misc/devel/tidy.pl Koha/OAI/Server/Repository.pm` [FAIL] installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl Can this be tidied? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #29 from Mathieu Saby <mathsabypro@gmail.com> --- My library was interested with this feature... Do you think the patch could be revived for the next cycle? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #31 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201866&action=edit Bug 28639: (follow_up) changing syspref name on atomic update file Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #33 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201868&action=edit Bug 28639: (follow-up) Fix atomic update file Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186052|0 |1 is obsolete| | Attachment #186053|0 |1 is obsolete| | Attachment #186054|0 |1 is obsolete| | Attachment #186055|0 |1 is obsolete| | --- Comment #30 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201865&action=edit Bug 28639: Embed see-from headings (from authorities) into bibliographic records at OAI repository level Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Enable OAI-PMH syspref and fill OAI-PMH:archiveID syspref with "oai:sandbox" 4. Go to OAI repository and display the previously created record (at /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=oai:sandbox:{biblionumber} 5. The record should not contain see-from headings 6. Run perl installer/data/mysql/atomicupdate/bug_28639-add_EmbedSeeFromInBibRecord_syspref.pl 7. Enable OAI-PMH:EmbedSeeFromInBibRecord 8. Go again to the OAI record, you should see alternative forms at the end of the record Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #32 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 201867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201867&action=edit Bug 28639: (follow-up) Changes method to embed see-from headings To have same code syntax call of Koha::RecordProcessor class Signed-off-by: Mathieu Saby <mathsabypro@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639 --- Comment #34 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- (In reply to Lucas Gass (lukeg) from comment #28)
File is not tidy, please run `perl misc/devel/tidy.pl Koha/OAI/Server/Repository.pm` [FAIL] installer/data/mysql/atomicupdate/bug_28639- add_EmbedSeeFromInBibRecord_syspref.pl
Can this be tidied?
Hello thanks Lucas for your review, I fixed this normally, the error [FAIL] that you notice no longer exist, I rename the file on a follow-up. Ready to QA (I hope) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org