[Bug 25596] New: "Overpayment refund" is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Bug ID: 25596 Summary: "Overpayment refund" is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 21727 In some cases there might be a refund to the account to balance and overpayment. The description created is "Overpayment refund". This string appears in the accounts table in the patron account and is currently not translatable. Added by commit 11c4cd73e19586ea74a7ac5ba7c88989dd8c4f21 Bug 21727: Add handling for cases requireing patron refunds Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::Line->adjust -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 25833 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109794&action=edit Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109794|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109818&action=edit Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109818|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110551&action=edit Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the issue date early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the overdues script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Tried to test this, but I can't apply the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110551|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111940&action=edit Bug 25596: Identify overpayment refunds for translation This patch ensure we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the date due early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the fines.pl script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've rebased and tested - wouldn't mind another sign-off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The string is added to the .po file. However, when I have the patch on, and I try to backdate check in an item, it gives me a broken FK constraint... 1) Checkout an item to a patron with due date 2020/10/15 2) Run fines.pl 3) Pay fine 4) Checkin with backdate 2020/10/14 With patch, it gives me a software error; without patch, it works... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111940|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111992&action=edit Bug 25596: Identify overpayment refunds for translation This patch ensures we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the date due early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the fines.pl script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I'm struggling to replicate your error Caroline.. did you run the included database update? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Martin Renvoize from comment #11)
Hmm, I'm struggling to replicate your error Caroline.. did you run the included database update?
No, sorry. David Cook pointed this out to me. I was not able to come back and test since then (kohacon talks were too interesting!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Martin Renvoize from comment #11)
Hmm, I'm struggling to replicate your error Caroline.. did you run the included database update?
In my defense, it was not in the test plan, hehe :P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111992|0 |1 is obsolete| | --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 112078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112078&action=edit Bug 25596: Identify overpayment refunds for translation This patch ensures we can uniquely identify automatic overpayment refund credits from the accountlines by introducing a new account credit type and adding appropriate translations for the new code. Test plan 1/ You'll need an overpayment refund to start... 1a/ Issue yourself and item and set the date due early enough to create an overdue fine for at least 2 days worth of overdue fines 1b/ Run the fines.pl script to add the fines 1c/ As a patron, pay off the accruing fine 1d/ Return the item ensuring you backdate it at least a day 1e/ Check that there is an 'Overpayment refund' credit on the patrons account. 2/ Check that the overpayment string is translatable (i.e. it appears in the accounts include file) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- does not apply cleanly to 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could you reconsider if this was rebased? Translation fixes can't be easily backported locally, especially since we support so many libraries with different languages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596 --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #17)
Could you reconsider if this was rebased?
Translation fixes can't be easily backported locally, especially since we support so many libraries with different languages.
Yes, I would be more than happy to. I just will not attempt to rebase this one myself, not comfortable doing so. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org