[Bug 13417] New: New permission to allow staff to remove public lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Bug ID: 13417 Summary: New permission to allow staff to remove public lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9833, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7310 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34233&action=edit Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Files for other languages will be add later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 34249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34249&action=edit [Signed-off] Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34233|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12838 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- *** Bug 12838 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5763 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- I agree with a new permission. What for is this line : + if ( $user > 0 ) { To exclude database user (the one in koha-conf.xml) ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- If not user is logged. This code is used for intranet and opac. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- "If no user is logged in" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #6)
If not user is logged. This code is used for intranet and opac.
Ah, OK. Its because of line 455 in C4/VirtualShelves.pm : $user=0 unless $user; This has an impact : database user as $user=0 so he will not have this permission. Its not a big deal since this database user should be used only to manage staff users. Nice job Jonathan ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #0)
Currently a public list can only be deleted by its owner. This means lists can exist infinitely.
Please look for HandleDelBorrower. When you delete a patron, you delete his lists including the public lists. Please see bug 11889. It was opened to discuss/find a solution where you do not want to delete all his public lists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I would favor a permission for allowing staff to manage lists that they do not own. It was discussed on older reports already. But the solution of this patch is imo little bit too quick. [1] The change of sub ShelfPossibleAction is not very refined and may have side-effects. [2] You allow deletion of public lists now, but what if you want to manage a private or shared list from another user? Would it not be better to show a third tab in staff for Other lists (or even another form?) that allows you to search lists, delete, edit, change ownership, etc.? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Saw a Bug XXXXX: Add permission for shelves -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #9)
(In reply to Jonathan Druart from comment #0)
Currently a public list can only be deleted by its owner. This means lists can exist infinitely.
Please look for HandleDelBorrower. When you delete a patron, you delete his lists including the public lists. Please see bug 11889. It was opened to discuss/find a solution where you do not want to delete all his public lists.
Ha yes, I forgot that! But we don't want to remove public lists. So I could submit a patch to remove private lists only, do you agree with that? (In reply to M. de Rooy from comment #10)
I would favor a permission for allowing staff to manage lists that they do not own. It was discussed on older reports already.
Code from VirtualShelves is really not easy to read/modify, I preferred not to change it to much.
But the solution of this patch is imo little bit too quick. [1] The change of sub ShelfPossibleAction is not very refined and may have side-effects.
I don't think it will introduce side-effects. The change is quite trivial.
[2] You allow deletion of public lists now, but what if you want to manage a private or shared list from another user? Would it not be better to show a third tab in staff for Other lists (or even another form?) that allows you to search lists, delete, edit, change ownership, etc.?
Discussion appended on a lot of bug reports, and no patch has been pushed yet. I propose a quick and easy solution to answer a big and real problem for librarians. Even if it is not perfect. I would not like to add a new tab here, I already have submitted a big change for this page (see bug 13419). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #11)
Saw a Bug XXXXX: Add permission for shelves
Maybe bug 9833? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13)
(In reply to M. de Rooy from comment #11)
Saw a Bug XXXXX: Add permission for shelves
Maybe bug 9833?
No the print message in your own patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34483&action=edit Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #12)
But we don't want to remove public lists. So I could submit a patch to remove private lists only, do you agree with that?
I don't think it will introduce side-effects. The change is quite trivial. To mention one: you allow now a superlibrarian to delete entries from the list of someone else. The manage permission is not on entry level, but on list level. You can moderate a list name, delete the entire list (for a good reason, i hope), change ownership or so. But why allowing librarians to interfere with the list contents? We respect the user here by not allowing that if he defined it likewise. Easy fix: move your change to the elsif(action eq manage)-part.
[2] You allow deletion of public lists now, but what if you want to manage a private or shared list from another user? Would it not be better to show a third tab in staff for Other lists (or even another form?) that allows you to search lists, delete, edit, change ownership, etc.? I propose a quick and easy solution to answer a big and real problem for librarians. Even if it is not perfect. I would not like to add a new tab here, I already have submitted a big change for this page (see bug 13419). Would a new tab really be so much work? And a new form would not interfere with other changes at all. I would prefer a more complete solution.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34485&action=edit Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34249|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #16)
(In reply to Jonathan Druart from comment #12)
But we don't want to remove public lists. So I could submit a patch to remove private lists only, do you agree with that?
I don't think it will introduce side-effects. The change is quite trivial. To mention one: you allow now a superlibrarian to delete entries from the list of someone else. The manage permission is not on entry level, but on list level. You can moderate a list name, delete the entire list (for a good reason, i hope), change ownership or so. But why allowing librarians to interfere with the list contents? We respect the user here by not allowing that if he defined it likewise. Easy fix: move your change to the elsif(action eq manage)-part.
The initial need was to delete shelves. I have just submitted a patch to limit the permission to the shelves deletion. I hope it matches your requirements.
[2] You allow deletion of public lists now, but what if you want to manage a private or shared list from another user? Would it not be better to show a third tab in staff for Other lists (or even another form?) that allows you to search lists, delete, edit, change ownership, etc.? I propose a quick and easy solution to answer a big and real problem for librarians. Even if it is not perfect. I would not like to add a new tab here, I already have submitted a big change for this page (see bug 13419). Would a new tab really be so much work? And a new form would not interfere with other changes at all. I would prefer a more complete solution.
I don't think it's inside the scope of this patch. Switch back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Test plan updated: 4/ You should be able to edit all public lists is 4/ You should be able to delete all public lists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34483|0 |1 is obsolete| | --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34743&action=edit Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34485|0 |1 is obsolete| | --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34744&action=edit Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. Apply both patches before testing, then follow this test plan Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to delete all public lists Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Works well! Some QA concerns: 1) Since the name of the feature has changed from "Virtual Shelves" to "Lists" can you change the permissions to "lists" and "manage_lists"? 2) Since this now only controls deletion, should it not be "delete_lists" instead? I think "delete_public_lists" would be most apt, as you cannot delete a patron's private lists. 3) Could you please add the new permissions to each languages permissions sql file? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34942&action=edit Bug 13417: (qa follow-up) Rename the permission to delete_public_lists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34943&action=edit Bug 13417: Add the permission for all languages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34743|0 |1 is obsolete| | Attachment #34744|0 |1 is obsolete| | Attachment #34942|0 |1 is obsolete| | Attachment #34943|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35083&action=edit [PASSED QA] Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35084&action=edit [PASSED QA] Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. Apply both patches before testing, then follow this test plan Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to delete all public lists Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35085&action=edit [PASSED QA] Bug 13417: (qa follow-up) Rename the permission to delete_public_lists Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35086&action=edit [PASSED QA] Bug 13417: Add the permission for all languages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- QA Note: One koha-qa.pl failure. AFAICT is not introduced by this patch set. FAIL C4/VirtualShelves.pm OK critic OK forbidden patterns OK pod FAIL valid Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS redefined Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #29)
QA Note: One koha-qa.pl failure. AFAICT is not introduced by this patch set.
Hum, actually yes, it comes from this patch set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35089&action=edit Bug 13417: Remove warnings Without this patch perl -wc C4/VirtualShelves.pm failed: Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS redefined at /usr/share/perl/5.20/constant.pm line 156. Subroutine GetShelves redefined at C4/VirtualShelves.pm line 103. Subroutine GetAllShelves redefined at C4/VirtualShelves.pm line 159. Subroutine GetSomeShelfNames redefined at C4/VirtualShelves.pm line 189. Subroutine GetShelf redefined at C4/VirtualShelves.pm line 230. Subroutine GetShelfContents redefined at C4/VirtualShelves.pm line 262. Subroutine AddShelf redefined at C4/VirtualShelves.pm line 315. Subroutine AddToShelf redefined at C4/VirtualShelves.pm line 353. Subroutine ModShelf redefined at C4/VirtualShelves.pm line 394. Subroutine ShelfPossibleAction redefined at C4/VirtualShelves.pm line 454. Subroutine DelFromShelf redefined at C4/VirtualShelves.pm line 545. Subroutine DelShelf redefined at C4/VirtualShelves.pm line 589. Subroutine GetBibliosShelves redefined at C4/VirtualShelves.pm line 603. Subroutine ShelvesMax redefined at C4/VirtualShelves.pm line 628. Subroutine HandleDelBorrower redefined at C4/VirtualShelves.pm line 648. Subroutine AddShare redefined at C4/VirtualShelves.pm line 683. Subroutine AcceptShare redefined at C4/VirtualShelves.pm line 703. Subroutine IsSharedList redefined at C4/VirtualShelves.pm line 731. Subroutine RemoveShare redefined at C4/VirtualShelves.pm line 750. Subroutine _shelf_count redefined at C4/VirtualShelves.pm line 764. Subroutine _CheckShelfName redefined at C4/VirtualShelves.pm line 788. C4/VirtualShelves.pm syntax OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11889 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Could you please rebase? There's a conflict with pl-PL files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35083|0 |1 is obsolete| | Attachment #35084|0 |1 is obsolete| | Attachment #35085|0 |1 is obsolete| | Attachment #35086|0 |1 is obsolete| | Attachment #35089|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35762&action=edit Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35763&action=edit Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. Apply both patches before testing, then follow this test plan Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to delete all public lists Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35764&action=edit Bug 13417: (qa follow-up) Rename the permission to delete_public_lists Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35765&action=edit Bug 13417: Add the permission for all languages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35766&action=edit Bug 13417: Remove warnings Without this patch perl -wc C4/VirtualShelves.pm failed: Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS redefined at /usr/share/perl/5.20/constant.pm line 156. Subroutine GetShelves redefined at C4/VirtualShelves.pm line 103. Subroutine GetAllShelves redefined at C4/VirtualShelves.pm line 159. Subroutine GetSomeShelfNames redefined at C4/VirtualShelves.pm line 189. Subroutine GetShelf redefined at C4/VirtualShelves.pm line 230. Subroutine GetShelfContents redefined at C4/VirtualShelves.pm line 262. Subroutine AddShelf redefined at C4/VirtualShelves.pm line 315. Subroutine AddToShelf redefined at C4/VirtualShelves.pm line 353. Subroutine ModShelf redefined at C4/VirtualShelves.pm line 394. Subroutine ShelfPossibleAction redefined at C4/VirtualShelves.pm line 454. Subroutine DelFromShelf redefined at C4/VirtualShelves.pm line 545. Subroutine DelShelf redefined at C4/VirtualShelves.pm line 589. Subroutine GetBibliosShelves redefined at C4/VirtualShelves.pm line 603. Subroutine ShelvesMax redefined at C4/VirtualShelves.pm line 628. Subroutine HandleDelBorrower redefined at C4/VirtualShelves.pm line 648. Subroutine AddShare redefined at C4/VirtualShelves.pm line 683. Subroutine AcceptShare redefined at C4/VirtualShelves.pm line 703. Subroutine IsSharedList redefined at C4/VirtualShelves.pm line 731. Subroutine RemoveShare redefined at C4/VirtualShelves.pm line 750. Subroutine _shelf_count redefined at C4/VirtualShelves.pm line 764. Subroutine _CheckShelfName redefined at C4/VirtualShelves.pm line 788. C4/VirtualShelves.pm syntax OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13632 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #39 from Nicole C. Engard <nengard@gmail.com> --- I'm seeing two new permissions - Lists and then the permission to delete under that. Does the lists permission do anything? Does it control who can use lists? I'm looking for the manual. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Nicole C. Engard from comment #39)
I'm seeing two new permissions - Lists and then the permission to delete under that. Does the lists permission do anything? Does it control who can use lists? I'm looking for the manual.
Hi Nicole, This patchset only introduced 1 'manage_shelves' permission. If set, the librarian will be able to manage all shelves. There is no specific permission for deletion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #41 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 37051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37051&action=edit permissions I see two new permissions - and I see that one of the patches here is to rename the delete permission. So my question is why are there 2 permission checkboxes? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Sorry yes, it's delete_public_lists (not manage). And, there is 1 permission in the group of permissions "Lists". It's the first permission of the "List" module, we can imagine other permissions for this module. Have a look at the userflags and permissions tables: 1 "flag" can have several permissions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it would be more clean to say 'lists' is general list permission with 'manage public lists' and 'remaining list permissions' as the sub permissions - that way it would work like the other module permissions. There is a mismatch there now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, have added bug 13888 with my thoughts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Pete Edwards <koha@jsense.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@jsense.co.uk --- Comment #45 from Pete Edwards <koha@jsense.co.uk> --- This isn't working as I would expect. I just upgraded from 3.18.03 to 3.20.01 and can see the new permissions. I cannot set them since I have superlibrarian permission but that is expected. However, when I go to public lists I still cannot edit or delete them. If I try another user without superlibrarian permission and add the new permission, still nothing changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Pete Edwards from comment #45)
This isn't working as I would expect. I just upgraded from 3.18.03 to 3.20.01 and can see the new permissions. I cannot set them since I have superlibrarian permission but that is expected. However, when I go to public lists I still cannot edit or delete them. If I try another user without superlibrarian permission and add the new permission, still nothing changes.
Hi Pete, There is a bug, I will provide a patch soon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14529 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 [Bug 14529] Cannot delete a list even if the permission is set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- See bug 14529. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org