http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9627 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15380&action=edit Bug 9627 - Replace YUI buttons and menus on serials pages with Bootstrap This patch converts the toolbar include file used by Serials pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in serials/ which uses serials-toolbar.inc (subscription-detail.pl, serials-home.pl, etc). Buttons and menus should look correct and work correctly, including: - New subscription - Edit subscription - Edit as new (duplicate) - Delete subscription - Renew - Receive - Close -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9627 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15389|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15448&action=edit [PASSED QA] Bug 9627 - Replace YUI buttons and menus on serials pages with Bootstrap This patch converts the toolbar include file used by Serials pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in serials/ which uses serials-toolbar.inc (subscription-detail.pl, serials-home.pl, etc). Buttons and menus should look correct and work correctly, including: - New subscription - Edit subscription - Edit as new (duplicate) - Delete subscription - Renew - Receive - Close Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. For me it would be better to use icon-remove, because icon-remove-circle shows a little cross, think that a bigger cross is more clear. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. I think there is a point in differentiating between closing and deleting, so the icon-remove-circle is maybe not ideal, but the icon-remove would falsely indicate a delete. Maybe we can find another icon that expresses the functionality a bit better later on. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9627 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.