[Bug 10441] New: Testing AddShare in VirtualShelves.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Bug ID: 10441 Summary: Testing AddShare in VirtualShelves.t Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: m.de.rooy@rijksmuseum.nl Reporter: m.de.rooy@rijksmuseum.nl Depends on: 9032, 10386 Builds upon bug 10386 and bug 9032. Adds a unit test for routine AddShare. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18822&action=edit Bug 10441: Testing AddShare in VirtualShelves.t Builds upon 10386 and 9032. Adds a unit test for routine AddShare. Test plan: Run the test. All passed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Testing AddShare in |UT: Testing AddShare in |VirtualShelves.t |VirtualShelves.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I'm not disputing the test itself, but wouldn't it be nice if AddShare returned something to indicate sucsess/failure? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #2)
I'm not disputing the test itself, but wouldn't it be nice if AddShare returned something to indicate sucsess/failure?
Thanks for testing. First of all, you are right of course. By far, we are not testing the success of mysql insert statements in Koha. In some cases it is done (saw one when e.g. adding a biblio); note that AddShare is not the most critical operation :) AddShare could however simply check DBI's err and return a boolean. Will leave the two reports as they are now for the moment, but will later handle this in a followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- See also report 10499. This patch removed the DelShelf code. Will include it again in rebasing this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18822|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19721&action=edit Bug 10441: Testing AddShare in VirtualShelves.t Builds upon 10386 and 9032. Adds a unit test for routine AddShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test. All passed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19721|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 19736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19736&action=edit [SIGNED-OFF] Bug 10441: Testing AddShare in VirtualShelves.t Builds upon 10386 and 9032. Adds a unit test for routine AddShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test. All passed? Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Just an idea, maybe use SKIP block rather than if(). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Srdjan Jankovic from comment #7)
Just an idea, maybe use SKIP block rather than if().
Thanks for testing, Srdjan. Yes, could have used skip here too. Can imagine cases where skip would really be a better choice. In this case fairly arbitrary.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Quick review: Please prefer "is" instead of "ok": ok(1 == $status, "deleted shelf $shelfnumber and its contents"); is( $status, 1, "deleted shelf $shelfnumber and its contents"); and for my $i ( 0 .. 9 ) { instead of for(my $i=0; $i<10;$i++){ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10386 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19936&action=edit Bug 10441: QA Followup for Virtualshelves.t As requested by Jonathan: Replace a i++ construct by 0..9; added a space to similar constructs. Change ok-calls by is-calls where applicable. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> 83 tests still pass, no complaints from koha-qa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10389 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20505&action=edit Bug 10441: UT: Create patrons for Virtualshelves.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch this depends on is currently 'failed qa' - using blocked to indicate that this can't be QA'd right now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |MOVED --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I will move this code to bug 9032. Close this report now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10389 | Depends on|9032 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19736|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19936|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20505|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org