[Bug 13109] New: Serial failure for received and general viewing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Bug ID: 13109 Summary: Serial failure for received and general viewing Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: librarian@sasaki.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com For Log Magazine, also still an issue for Sports Business Journal Received the following message Software error: Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at /usr/share/koha/lib/C4/Serials.pm line 2379. For help, please send mail to the webmaster (staff@bywatersolutions.com), giving this error message and the time and date of the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #1 from Mason James <mtj@kohaaloha.com> --- (In reply to Aliza from comment #0)
For Log Magazine, also still an issue for Sports Business Journal
Received the following message
Software error:
Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at /usr/share/koha/lib/C4/Serials.pm line 2379. For help, please send mail to the webmaster (staff@bywatersolutions.com), giving this error message and the time and date of the error.
hmm, we just hit this bug on 3.16.7 i'll do a little more digging on this one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|3.14 |3.16 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- (In reply to Aliza from comment #0)
For Log Magazine, also still an issue for Sports Business Journal
Received the following message
Software error:
Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at /usr/share/koha/lib/C4/Serials.pm line 2379. For help, please send mail to the webmaster (staff@bywatersolutions.com), giving this error message and the time and date of the error.
aah, i see the problem here... the abouttoexpire() sub tries to compare 2 dates, but doesnt check that both dates actually exist i'll send a patch for this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 37356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37356&action=edit Bug 13109 - Serial failure for received and general viewing. modified: C4/Serials.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37356|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 37357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37357&action=edit Bug 13109 - Serial failure for received and general viewing. to test... 1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate' an example url would be... http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscr... observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325' 2/ apply patch 3/ repeat step 1/ observe that detail page displays OK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.16 |master Keywords| |rel_3_16_candidate --- Comment #5 from Mason James <mtj@kohaaloha.com> --- ..bug confirmed on master, and 3.18.5 too -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|normal |major CC| |chris@bigballofwax.co.nz Keywords| |rel_3_18_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Mason James from comment #4)
1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate'
The date picker forces it or a length to be entered. How do you get this situation without messing with data in the back end?
an example url would be...
http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail. pl?subscriptionid=1
observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325'
2/ apply patch 3/ repeat step 1/ observe that detail page displays OK
Could you just confirm test steps more explicitly, assuming fresh install with one superlibrarian created and defaults all installed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37357|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37716&action=edit Bug 13109 - Serial failure for received and general viewing. to test... 1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate' an example url would be... http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscr... observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325' 2/ apply patch 3/ repeat step 1/ observe that detail page displays OK Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I confirm the issue if startdate is null (can exist with old data, before the js check on the form). Amended patch: Remove trailing space char and the link to the bz number (can be found using git log). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 --- Comment #8 from Mason James <mtj@kohaaloha.com> --- (In reply to M. Tompsett from comment #6)
(In reply to Mason James from comment #4)
1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate'
The date picker forces it or a length to be entered. How do you get this situation without messing with data in the back end?
hmm, i'm really not sure but, we hit this bug in a prod koha, with no messing of data -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37716|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37915&action=edit [PASSED QA] Bug 13109 - Serial failure for received and general viewing. to test... 1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate' an example url would be... http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscr... observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325' 2/ apply patch 3/ repeat step 1/ observe that detail page displays OK Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I confirm the issue if startdate is null (can exist with old data, before the js check on the form). Amended patch: Remove trailing space char and the link to the bz number (can be found using git log). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14036 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rolando.isidoro@gmail.com --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 14036 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Rolando Isidoro <rolando.isidoro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14036 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #10)
*** Bug 14036 has been marked as a duplicate of this bug. ***
Correction, it isn't. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mason! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #14 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle@bywatersolutions.c | |om --- Comment #15 from Danielle Elder <danielle@bywatersolutions.com> --- (In reply to Mason James from comment #14)
Pushed to 3.16.x, will be in 3.16.11
I just wanted to say THANK YOU for adding the version that this is pushed to in the post! So helpful. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org