[Bug 13419] New: Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Bug ID: 13419 Summary: Add filters and server-side processing to the shelves list view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This will be a new enhancement: Search and filter the lists on the intranet side. The OPAC won't be affected by this patch set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34241&action=edit Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34242&action=edit Bug 13419: Add filters on the list table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34243&action=edit Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13421 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #4 from Marc Véron <veron@veron.ch> --- The filter behaves as follows: Edit / change 'List name' Result: List is filtered: OK Edit /change 'Author': Result: List is filtered: OK Change selection in drop box 'Sort by' Result: No change in list. You have to change 'List name' or 'Author' to trigger filtering. - This is confusing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 34504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34504&action=edit [Signed-off] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34504|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Comment on attachment 34504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34504 [Signed-off] Bug 13421: Add the creation time for virtual shelves Sorry, attached to wrong bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #4)
Change selection in drop box 'Sort by' Result: No change in list. You have to change 'List name' or 'Author' to trigger filtering. - This is confusing.
Looks good here. Did you see the "processing" message? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 34514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34514&action=edit [Signed-off] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34242|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 34515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34515&action=edit Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34515|Bug 13419: Add filters on |[Signed-off] Bug 13419: Add description|the list table |filters on the list table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #10 from Marc Véron <veron@veron.ch> --- For patch #3 "Add tests" I get errors # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 199. # got: '15' # expected: '12' # Failed test 'There should be 12 private shelves' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 202. # got: '15' # expected: '12' # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 214. # got: '15' # expected: '12' # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 230. # got: '15' # expected: '12' # Looks like you failed 4 tests of 13. However if I remove all public lists, it passes OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34516&action=edit Bug 13419: (follow-up) Add tests - remove existing shelves -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Marc Véron from comment #10)
For patch #3 "Add tests" I get errors
Good catch Marc, thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34243|0 |1 is obsolete| | --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 34517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34517&action=edit Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34517|Bug 13419: Add tests |[Signed-off] Bug 13419: Add description| |tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 34518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34518&action=edit [Signed-off] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34514|0 |1 is obsolete| | Attachment #34515|0 |1 is obsolete| | Attachment #34516|0 |1 is obsolete| | Attachment #34517|0 |1 is obsolete| | Attachment #34518|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34577&action=edit [PASSED QA] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34578&action=edit [PASSED QA] Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34579&action=edit [PASSED QA] Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34580&action=edit [PASSED QA] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34577|0 |1 is obsolete| | Attachment #34578|0 |1 is obsolete| | Attachment #34579|0 |1 is obsolete| | Attachment #34580|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38188&action=edit Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38189&action=edit Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38190&action=edit Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38191&action=edit Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38188|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38193&action=edit Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38189|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38194&action=edit Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38190|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38195&action=edit Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38191|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38196&action=edit Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38347&action=edit Bug 13419: (follow-up) fix call to set_userenv -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 38355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38355&action=edit Bug 13419: (QA followup) remove useless warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org