[Bug 14760] New: Disabled courses display in the course reserves list for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Bug ID: 14760 Summary: Disabled courses display in the course reserves list for items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: kyle.m.hall@gmail.com QA Contact: testopia@bugs.koha-community.org If an item is on reserve for two courses but one of those courses is disabled, both courses are still listed on opac-detail.pl! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |kyle.m.hall@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42121&action=edit Bug 14760 - Disabled courses display in the course reserves list for items If an item is on reserve for two courses but one of those courses is disabled, both courses are still listed on opac-detail.pl! Test Plan: 1) Enable course reserves 2) Create two courses 3) Place one item on reserve for both courses 4) Disable one of the two courses 5) View the record details for that record/item 6) You should see both courses listed in the course reserves column 7) Apply this patch 8) Reload the page 9) You should now only see the active course in the course reseves column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 42328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42328&action=edit [Signed-off] Bug 14760 - Disabled courses display in the course reserves list for items If an item is on reserve for two courses but one of those courses is disabled, both courses are still listed on opac-detail.pl! Test Plan: 1) Enable course reserves 2) Create two courses 3) Place one item on reserve for both courses 4) Disable one of the two courses 5) View the record details for that record/item 6) You should see both courses listed in the course reserves column 7) Apply this patch 8) Reload the page 9) You should now only see the active course in the course reseves column Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #42121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42328|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42347&action=edit Bug 14760 - Disabled courses display in the course reserves list for items If an item is on reserve for two courses but one of those courses is disabled, both courses are still listed on opac-detail.pl! Test Plan: 1) Enable course reserves 2) Create two courses 3) Place one item on reserve for both courses 4) Disable one of the two courses 5) View the record details for that record/item 6) You should see both courses listed in the course reserves column 7) Apply this patch 8) Reload the page 9) You should now only see the active course in the course reseves column Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that this already works at the intranet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org