[Bug 27852] New: Link YES_NO authorized value category to 942$n in Default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Bug ID: 27852 Summary: Link YES_NO authorized value category to 942$n in Default framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When OpacSuppression is set to Hide, a value of 1 in 942$n will hide the record from the OPAC, whereas a value of 0 or empty will show the record in the OPAC. I think it would be logical to link the authorized value category "YES_NO" to the 942$n field in the Default framework. I usually add the link manually for all new installations (and sometimes I forget), but I feel like it's a normal use. Maybe we could add it to master? And also add 0 as default value, just to make sure the Yes is not selected by default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 117623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117623&action=edit Bug 27852: Link YES_NO authorized value category to 942dev in Default framework This patch add the YES_NO authorised value category to 942dev in the Default framework and sets the default value to 0 (No). To test: 1) Load the yaml file (I used the load_yaml.pl script after deleting the values from my database) 2) Go to cataloging and open an empty cataloging form using the Default framework 3) Go to 942$n: the value should read No and there should be a drop down choice between Yes and No -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- After rereading the test plan, I realize it's not very clear... For step 1, I first deleted everything from the default (and ACQ) framework in marc_subfield_structure and marc_tag_structure delete from marc_subfield_structure where frameworkcode = ""; delete from marc_subfield_structure where frameworkcode = "ACQ"; delete from marc_tag_structure where frameworkcode = ""; delete from marc_tag_structure where frameworkcode = "ACQ"; Then, I used the load_yaml script to reload the marc21_framework_DEFAULT.yml file ./misc/load_yaml.pl -f ../installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hi Caroline. I had a go at testing this, and thanks for the clarification for step 1! I get this message after deleting the entries in the database and reloading the yaml file: root@kohadevbox:koha(bz27852)$ ./misc/load_yaml.pl -f ./installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load C4::Installer::load_sql returned the following errors while attempting to load ./installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml: DBD::mysql::db do failed: Duplicate entry 'ACQ' for key 'PRIMARY' at /kohadevbox/koha/C4/Installer.pm line 572. It does seem to work though as the$942n now has a Yes/ or No option, with No as the default. Not sure what affect the error message will have... David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi David! Thanks for testing this! I think I forgot to add that you have to also delete the frameworks... sorry about that Here's the updated test plan, hopefully this time it works! 1) Apply patch 2) In the database delete from marc_subfield_structure where frameworkcode = ""; delete from marc_subfield_structure where frameworkcode = "ACQ"; delete from marc_tag_structure where frameworkcode = ""; delete from marc_tag_structure where frameworkcode = "ACQ"; delete from biblio_framework where frameworkcode in ("", "ACQ"); 2) Load the yaml file ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 3) In Koha, go to cataloging and open an empty cataloging form using the Default framework 4) Go to 942$n: the value should read No and there should be a drop down choice between Yes and No -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Caroline for the updated test plan, everything is working now - sign off on the way! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117623|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 119141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119141&action=edit Bug 27852: Link YES_NO authorized value category to 942dev in Default framework This patch add the YES_NO authorised value category to 942dev in the Default framework and sets the default value to 0 (No). To test: 1) Load the yaml file 1) Load the yaml file (I used the load_yaml.pl script after deleting the values from my database) 2) Go to cataloging and open an empty cataloging form using the Default framework 2) Go to 942dev: the value should read No and there should be a drop down choice between Yes and No Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119141|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119829&action=edit Bug 27852: Link YES_NO authorized value category to 942dev in Default framework This patch add the YES_NO authorised value category to 942dev in the Default framework and sets the default value to 0 (No). To test: 1) Load the yaml file 1) Load the yaml file (I used the load_yaml.pl script after deleting the values from my database) 2) Go to cataloging and open an empty cataloging form using the Default framework 2) Go to 942dev: the value should read No and there should be a drop down choice between Yes and No Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's nice to see how our new .yml approach makes it easier to do these kinds of improvements. Note: I know that in order to have a complete change we'd need to update the sql installer files as well. But I feel that this would be forgiveable in this case as this has the character of an enhancement and can be easily fixed for other languages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a Yes/No release notes| |drop-down menu in the | |default bibliographic | |framework for field 942$n | |(MARC21). This field | |controls whether or not the | |record is hidden in the | |OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24594 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 [Bug 24594] Rewrite MARC21 mandatory data to YAML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org