[Bug 33247] New: Deleted authority still on results list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Bug ID: 33247 Summary: Deleted authority still on results list Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fribeiro@keep.pt QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl After deleting an authority from authorities home, the page loaded after the operation still contains the deleted authority. To reproduce: 1 - Go to authorities home and perform a search; 2 - Delete any authority; 3 - After the confirmation, the page is refreshed but still contains the deleted authority; If you reload the page, that row disappear. It seems that the authorities search is performed before the index is deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm this behavior in current master. The index update usually happens almost immediately, but only almost and the page load/search appears to be a little faster. I am really not sure how this could be helped. Maybe we could show a "success" dialog page first to gain some time, but then we lose a bit of usability. Waiting for the index also seems like a bad idea as it could be stuck for a little when a lot of operations need to be done. Maybe someone else has a good idea? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151070&action=edit Bug 33247: Flag the authority pending deletion in the result list When an authority is removed from the result list it is not removed from the search engine yet. This patch suggests to add a note in the summary column to tell the user that the deletion is pending. Test plan: 1 - Go to authorities home and perform a search; 2 - Delete any authority; 3 - After the confirmation, the page is refreshed but still contains the deleted authority, with a red note explaining that the deletion is pending. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Quick an dirty fix. Would it be enough? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Enough for people who never delete more than one between index updates, maybe. I routinely have 5-10 deleted between updates multiple times a day. We actually already have a dirty indication of deleted records if your search didn't specify an authority type, since in that case we can't look up the authority type to display it above the heading in the search results. So already-deleted headings are the ones with a slightly shorter row because they don't have the authority type part of the display. Maybe try to look up the authority type even when it's specified in the search, and when the record isn't found, mark it as deleted/missing? I'd be surprised if that made a noticeable perf hit, what with everything else we have to do to assemble a page of search results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151070|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 151162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151162&action=edit Bug 33247: Flag the authority pending deletion in the result list When an authority is removed from the result list it is not removed from the search engine yet. This patch suggests to add a note in the summary column to tell the user that the deletion is pending. Test plan: 1 - Go to authorities home and perform a search; 2 - Delete any authority; 3 - After the confirmation, the page is refreshed but still contains the deleted authority, with a red note explaining that the deletion is pending. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This does not cover cases where another user just removed an authority before it got reindexed. So it feels like a partial solution. Should we build the list from the database, or just live with the time frame between action and reindex? Instead of marking it as pending deletion, I would suggest to not display it since it was deleted after all. Please provide feedback why the current solution is better than doing that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Phil Ringnalda from comment #4)
We actually already have a dirty indication of deleted records if your search didn't specify an authority type, since in that case we can't look up the authority type to display it above the heading in the search results. So already-deleted headings are the ones with a slightly shorter row because they don't have the authority type part of the display.
Do not understand this argument. I removed a PERSO_NAME record. It is marked with Pending deletion, but I still see the heading type Personal name. Or do you mean something else ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #6)
Instead of marking it as pending deletion, I would suggest to not display it since it was deleted after all. Please provide feedback why the current solution is better than doing that.
Easy and simple to implement, that was my only motivation to try to resolve this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |koha-bugs@lists.koha-commun |com |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
(In reply to Marcel de Rooy from comment #6)
Instead of marking it as pending deletion, I would suggest to not display it since it was deleted after all. Please provide feedback why the current solution is better than doing that.
Easy and simple to implement, that was my only motivation to try to resolve this bug.
Would it be so hard to hide a row instead of marking it with an additional string then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Marcel de Rooy from comment #7)
(In reply to Phil Ringnalda from comment #4)
We actually already have a dirty indication of deleted records if your search didn't specify an authority type, since in that case we can't look up the authority type to display it above the heading in the search results. So already-deleted headings are the ones with a slightly shorter row because they don't have the authority type part of the display.
Do not understand this argument. I removed a PERSO_NAME record. It is marked with Pending deletion, but I still see the heading type Personal name. Or do you mean something else ?
Turns out not to be what I thought it was: rather than the result of hitting the db for the authority type, it must be the result of index differences (either a missing index, or speed at updating an index) between Zebra and Elasticsearch, since it's Zebra-only that the type in the Summary column disappears, and the one in the Heading type column switches to Default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151162|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151974&action=edit Bug 33247: Flag the authority pending deletion in the result list When an authority is removed from the result list it is not removed from the search engine yet. This patch suggests to add a note in the summary column to tell the user that the deletion is pending. Test plan: 1 - Go to authorities home and perform a search; 2 - Delete any authority; 3 - After the confirmation, the page is refreshed but still contains the deleted authority, with a red note explaining that the deletion is pending. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151975&action=edit Bug 33247: (QA follow-up) Remove pending deletion from results array Both Elastic and Zebra search_auth_compat return a hash key authid for a result. Test plan: Remove an authority that should be in your results list. Note that it is no longer marked as pending, but just not displayed. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- But then you refresh and the auth popup again (if index not updated already)? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13)
But then you refresh and the auth popup again (if index not updated already)? :)
If you are fast enough :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org