[Bug 35648] New: Allow sorting of patron categories in Overdue notice/status triggers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Bug ID: 35648 Summary: Allow sorting of patron categories in Overdue notice/status triggers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: jheltibridle@rcplib.org QA Contact: testopia@bugs.koha-community.org It would be really helpful to be able to choose the sorting method on the Overdue notice/status triggers page. Currently, the patron categories are sorted by Code. We include the branch name at the start of the Category name. If we could sort by that instead of the Code, we could find our branch's patron categories much quicker in order to make changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160455&action=edit Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers This patch adds a basic DataTables configuration to the table of patron categories on the Overdue notice/status triggers page. The table can be sorted by patron category and can be filtered. To test, apply the patch and go to Tools -> Overdue notice/status triggers. - Confirm that the table of patron categories is sorted by default by patron category - Other columns should not be sortable - You should see a search field above the table which works to filter by patron category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, This is nice but the dataTable only applies to the first table. The 2nd and 3rd table do not become dataTables. We actually have invalid HTML on this page because the table ID is reused ( #overduerulest ) Should a separate bug be filed for that? Or can we deal with it here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Thanks Lucas, that was a dumb oversight. I will redo the patch and correct the ID error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160455|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160495&action=edit Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers This patch adds a basic DataTables configuration to the table of patron categories on the Overdue notice/status triggers page. The table can be sorted by patron category and can be filtered. To test, apply the patch and go to Tools -> Overdue notice/status triggers. - Confirm that the table of patron categories is sorted by default by patron category - Other columns should not be sortable - You should see a search field above the table which works to filter by patron category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160495|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 160498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160498&action=edit Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers This patch adds a basic DataTables configuration to the table of patron categories on the Overdue notice/status triggers page. The table can be sorted by patron category and can be filtered. To test, apply the patch and go to Tools -> Overdue notice/status triggers. - Confirm that the table of patron categories is sorted by default by patron category - Other columns should not be sortable - You should see a search field above the table which works to filter by patron category. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Data loss possible. If you submit the form while at least one of the table is filtered, you will lose the rows that are not displayed. IIRC we had the same problem when saving the ES mappings. A solution was to remove search, redraw and finally submit the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163702&action=edit Bug 35648: (follow-up) Clear table filter before submitting This patch takes advise from elasticsearch-mappings.js and adds an onsubmit event to clear any DataTables filter before submitting. This should prevent hidden fields from being overwritten. To test, filter the table and make a change to one of the visible rows. After submitting, confirm that the previously-hidden rows retain the same settings as before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- The transport columns appear to be sortable but do not actually sort. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166153&action=edit Bug 35648: (follow-up) Remove sorting from transport columns There's not a simple way to handle sorting of a column containing only checkboxes, so I think it makes sense to remove the sorting unless someone feels strongly about it being necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160498|0 |1 is obsolete| | Attachment #163702|0 |1 is obsolete| | Attachment #166153|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166312&action=edit Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers This patch adds a basic DataTables configuration to the table of patron categories on the Overdue notice/status triggers page. The table can be sorted by patron category and can be filtered. To test, apply the patch and go to Tools -> Overdue notice/status triggers. - Confirm that the table of patron categories is sorted by default by patron category - Other columns should not be sortable - You should see a search field above the table which works to filter by patron category. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166313&action=edit Bug 35648: (follow-up) Clear table filter before submitting This patch takes advise from elasticsearch-mappings.js and adds an onsubmit event to clear any DataTables filter before submitting. This should prevent hidden fields from being overwritten. To test, filter the table and make a change to one of the visible rows. After submitting, confirm that the previously-hidden rows retain the same settings as before. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166314&action=edit Bug 35648: (follow-up) Remove sorting from transport columns There's not a simple way to handle sorting of a column containing only checkboxes, so I think it makes sense to remove the sorting unless someone feels strongly about it being necessary. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow sorting of patron |Allow sorting of patron |categories in Overdue |categories in overdue |notice/status triggers |notice/status triggers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org