https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132358|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 134660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134660&action=edit Bug 30388: Fix some errors in the template for ordering from a MARC file This patch fixes a few markup errors in the addorder2709 template. The modal dialog markup is corrected and moved out of the loop of records so that it doesn't create repeating id attributes. Obsolete CSS is removed, fixing the width of the MARC preview modal. The calendar include is added, fixing a Flatpickr error in the console. Double ID attributes are removed from the Statistics 1 and Statistics 2 fields. To test, apply the patch and test the process of adding an order to a basket from a staged MARC file. Test in particular: - The MARC and Card previews - The "Date acquired" field under the "Item information" tab should trigger a Flatpickr widget. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Did you try testing this with the patch for Bug 30514 applied? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I've tried this a few times and just can't reproduce the problem Katrin describes. If someone could re-check it I'd be grateful. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe a side effect of another fix or just sun spots... but it works now :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134660|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134951&action=edit Bug 30388: Fix some errors in the template for ordering from a MARC file This patch fixes a few markup errors in the addorder2709 template. The modal dialog markup is corrected and moved out of the loop of records so that it doesn't create repeating id attributes. Obsolete CSS is removed, fixing the width of the MARC preview modal. The calendar include is added, fixing a Flatpickr error in the console. Double ID attributes are removed from the Statistics 1 and Statistics 2 fields. To test, apply the patch and test the process of adding an order to a basket from a staged MARC file. Test in particular: - The MARC and Card previews - The "Date acquired" field under the "Item information" tab should trigger a Flatpickr widget. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Bug 30388 depends on bug 30384, which changed state. Bug 30384 Summary: Reindent template for ordering from a MARC file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.