[Bug 7888] New: Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 Priority: P4 Change sponsored?: --- Bug ID: 7888 CC: gmcharlt@gmail.com Assignee: wizzyrea@gmail.com Summary: Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess" QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: wizzyrea@gmail.com Hardware: All Status: ASSIGNED Version: rel_3_6 Component: Patrons Product: Koha The "set password" button in the circ-toolbar.inc is now hidden from users that do not have can_user_staffaccess - I don't think this makes sense - a user with edit borrowers permission can change the password from "edit patron," so for consistency, the button should work on the same permission level. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 Sharon Moreland <smoreland@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smoreland@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8822&action=edit Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess" Patch changes permisison for "change password" button in circ-toolbar.inc from staffaccess to borrowers. To test: - With a staff user with borrowers permission, verify the change password button is shown for a normal patron. - With a staff user without borrowers permission, verify the change password button does not appear. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8822|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8824&action=edit [SIGNED-OFF] Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess" Patch changes permisison for "change password" button in circ-toolbar.inc from staffaccess to borrowers. To test: - With a staff user with borrowers permission, verify the change password button is shown for a normal patron. - With a staff user without borrowers permission, verify the change password button does not appear. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Enforces consistency on this permissions. No other changes, easy to read, marking Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Wow, that was fast! Thanks! Will close when it has made it to stable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7888 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch will be included in 3.6.5. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org