https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 69180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69180&action=edit Bug 19636: Hold priority changes incorrectly via dropdown select This patch sorts holds in UI after priority is changed via "Priority" dropdown. It fixes confusion where the form is posted and each row is individually processed one by one - and due to conflict in priority value, the latter row always gets the chosen value instead of what the user actually might have wanted to change. To reproduce: 1. Place 3 holds on a record 2. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX) 3. By using the dropdown menu under "Priority" column, change the first hold's priority to last (3). Do not touch other priorities. 4. Click Update hold(s) 5. Observe the hold did not get your selected priority 3, but 2 instead. To test: 1. Apply patch 2. Place 3 holds on a record 3. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX) 4. By using the dropdown menu under "Priority" column, change the first hold's priority to last (3). Do not touch other priorities. 5. Observe this hold was automatically moved to the last row in the user interface. 6. Click Update hold(s) 7. Observe the hold has your selected priority 3. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69180|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69195&action=edit Bug 19636: Hold priority changes incorrectly via dropdown select This patch sorts holds in UI after priority is changed via "Priority" dropdown. It fixes confusion where the form is posted and each row is individually processed one by one - and due to conflict in priority value, the latter row always gets the chosen value instead of what the user actually might have wanted to change. To reproduce: 1. Place 3 holds on a record 2. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX) 3. By using the dropdown menu under "Priority" column, change the first hold's priority to last (3). Do not touch other priorities. 4. Click Update hold(s) 5. Observe the hold did not get your selected priority 3, but 2 instead. To test: 1. Apply patch 2. Place 3 holds on a record 3. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX) 4. By using the dropdown menu under "Priority" column, change the first hold's priority to last (3). Do not touch other priorities. 5. Observe this hold was automatically moved to the last row in the user interface. 6. Click Update hold(s) 7. Observe the hold has your selected priority 3. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69195|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69917&action=edit Bug 19636: Hold priority changes incorrectly via dropdown select This patch sorts holds in UI after priority is changed via "Priority" dropdown. It fixes confusion where the form is posted and each row is individually processed one by one - and due to conflict in priority value, the latter row always gets the chosen value instead of what the user actually might have wanted to change. To reproduce: 1. Place 3 holds on a record 2. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX) 3. By using the dropdown menu under "Priority" column, change the first hold's priority to last (3). Do not touch other priorities. 4. Click Update hold(s) 5. Observe the hold did not get your selected priority 3, but 2 instead. To test: 1. Apply patch 2. Place 3 holds on a record 3. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX) 4. By using the dropdown menu under "Priority" column, change the first hold's priority to last (3). Do not touch other priorities. 5. Observe this hold was automatically moved to the last row in the user interface. 6. Click Update hold(s) 7. Observe the hold has your selected priority 3. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.