https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167658&action=edit Bug 37076: Fix incorrect needsconfirmation code This patch corrects two instances of RESERVED_WAITING to RESERVE_WAITING Test plan: 1) Navigate to system preferences and search for AllowItemsOnHoldCheckoutSCO 2) Observe from the description that the correct status code is RESERVE_WAITING 3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js 4) Apply patch 5) Repeat step 3 - there should be 0 instances -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 Lucas <lchirlias@ville-roubaix.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lchirlias@ville-roubaix.fr --- Comment #3 from Lucas <lchirlias@ville-roubaix.fr> ---

3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js

I checked in git.koha-community.org

5) Repeat step 3 - there should be 0 instances

I looked at the patch and it applied -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov Patch complexity|--- |Trivial patch Severity|enhancement |trivial --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Good catch! Passing QA and upgrading this to a bug, since it fixes a wrong error message in OPAC self-checkout (not the SCO module). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |30979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 [Bug 30979] Add ability for OPAC users to checkout to themselves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes an incorrect release notes| |value used in the OPAC | |self-checkout code (this | |new feature was added to | |Koha 23.11 by Bug 30979 - | |Add ability for OPAC users | |to checkout to themselves). | | | | | |Because of the incorrect | |value in the code | |(RESERVED_WAITING instead | |of RESERVE_WAITING - the | |'D' is incorrect), patrons | |could self check out an | |item on hold for another | |patron, instead of getting | |an error message "This item | |appears to be on hold for | |another patron, please | |return it to the desk". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37076 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00.24.05.06,23.11.11 |24.11.00,24.05.06,23.11.11 released in| | CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.