[Bug 23222] New: Fix DISABLE/ENABLE plugin label in plugins home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Bug ID: 23222 Summary: Fix DISABLE/ENABLE plugin label in plugins home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: agustinmoyano@theke.io QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Fix bug introduced in bug 21073 When you install a plugin, it shows as disables, even though it's enabled in database. Before 21073 that flag was called "enabled", after that bug it is called "is_enabled", but tt was never updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 91111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91111&action=edit Bug 23222: Update plugins-home.tt with new ENABLE/DISABLE flag name At some point of history, the flag to indicate if a plugin was enabled/disabled was called "enabled", now it's called "is_enabled" To test: 1) get a fresh master copy 2) Enable plugins 3) Install any plugin CHECK => plugin appears as disabled => If you try to enable it, it just appears as disabled just the same 4) Apply this patch 5) Reload page SUCCESS => plugin appears as enabled => enable / disable action works again 6) Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 [Bug 21073] Improve plugin performance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com | |, kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91111|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 91129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91129&action=edit Bug 23222: Update plugins-home.tt with new ENABLE/DISABLE flag name At some point of history, the flag to indicate if a plugin was enabled/disabled was called "enabled", now it's called "is_enabled" To test: 1) get a fresh master copy 2) Enable plugins 3) Install any plugin CHECK => plugin appears as disabled => If you try to enable it, it just appears as disabled just the same 4) Apply this patch 5) Reload page SUCCESS => plugin appears as enabled => enable / disable action works again 6) Sign off Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91129|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91163&action=edit Bug 23222: Update plugins-home.tt with new ENABLE/DISABLE flag name At some point of history, the flag to indicate if a plugin was enabled/disabled was called "enabled", now it's called "is_enabled" To test: 1) get a fresh master copy 2) Enable plugins 3) Install any plugin CHECK => plugin appears as disabled => If you try to enable it, it just appears as disabled just the same 4) Apply this patch 5) Reload page SUCCESS => plugin appears as enabled => enable / disable action works again 6) Sign off Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Passed QA |Pushed to master --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work, thanks!! Pushed to master to 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- *** Bug 23300 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org