[Bug 23302] New: Allow faster access to Card and MARC view in Z3950 search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Bug ID: 23302 Summary: Allow faster access to Card and MARC view in Z3950 search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In older versions it was possible to click Card view or MARC view directly. Now we must click twice (open menu first). When comparing different records, our users click Card or MARC repeatedly and would love to need only one click. What are our options to achieve that? ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Instead of reverting to three buttons/links: Could we add a Default action left to the dropdown menu like addbooks shows New Z3950 search and a menu? And perhaps remember which we action (Card or MARC) we chose last and offer that as default action again ? Any ideas? Owen ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
From IRC:
[14:57] <oleonard> marcelr: That interface has been contentious for a long time now. I think the core of the problem might be the small size of the window leading to solutions to conserve space [14:58] <marcelr> what about a default button? [14:58] <marcelr> instead of showing Actions? [14:58] <marcelr> the caret does not take much space [14:58] <oleonard> We had a discussion about default buttons in another context and there was no agreement about which should be the default [14:59] <marcelr> default could be governed by js and cookie ? [15:00] <oleonard> I wonder if we shouldn't just go back to individual buttons and try to address the space problem [15:00] <marcelr> that would be fine for us; i am doing that in our staff version now [15:00] <marcelr> bit uglier but it works [15:01] <marcelr> Card Marc Import are just short words ;) [15:01] <oleonard> I don't know if there is any consensus on it though... It would be worth taking to the Koha mailing list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #2)
[15:01] <oleonard> I don't know if there is any consensus on it though... It would be worth taking to the Koha mailing list
Sent a mail to the general list now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Paul A. <paul.a@navalmarinearchive.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.a@navalmarinearchive.c | |om --- Comment #4 from Paul A. <paul.a@navalmarinearchive.com> --- Excluding spiders, our logs show very few requests for 'cards' but many more for 'MARC'. I can only guess that at item level the data is more complete. Was there a good reason to remove this functionality? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Paul A. from comment #4)
Was there a good reason to remove this functionality?
I don't understand this question. No functionality was removed. The question is whether the actions should be grouped in a dropdown menu or displayed as individual buttons. Generally speaking, groups of three or more "actions" in a table like this are grouped into a dropdown menu in order to conserve horizontal space and make it easier to see the data in the table. That can be reversed in this case if there is enough call for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #6 from Paul A. <paul.a@navalmarinearchive.com> --- In reply to Owen L. Apologies -- bad wording, "functionality" was misleading, maybe "two clicks instead of one"? User friendliness? Ease of a GUI? The *line* "Normal view MARC view ISBD view" (I don't see it as a *table*) is extremely short, appears without breaks even on very small tablets rotated vertically upright. A "drop-down" might save a tad of horizontal screen space (but is probably, pixel-wise, a little taller than a text line), but is less explanatory unless you click it or know ahead of time what you're looking for. That's my (lame) excuse for misusing "functionality." I totally agree that "longer" lists of choices should be "drop down" -- just questioning the user experience of deciding "three textually short" options should be visually, quasi-hidden. At some point (intrinsically if a small screen can't get them all on one line), let's go for it.... Just not at all sure that it's required here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #7 from Paul A. <paul.a@navalmarinearchive.com> --- In reply to Owen L. Apologies -- bad wording, "functionality" was misleading, maybe "two clicks instead of one"? User friendliness? Ease of a GUI? The *line* "Normal view MARC view ISBD view" (I don't see it as a *table*) is extremely short, appears without breaks even on very small tablets rotated vertically upright. A "drop-down" might save a tad of horizontal screen space (but is probably, pixel-wise, a little taller than a text line), but is less explanatory unless you click it or know ahead of time what you're looking for. That's my (lame) excuse for misusing "functionality." I totally agree that "longer" lists of choices should be "drop down" -- just questioning the user experience of deciding "three textually short" options should be visually, quasi-hidden. At some point (intrinsically if a small screen can't get them all on one line), let's go for it.... Just not at all sure that it's required here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #8 from Paul A. <paul.a@navalmarinearchive.com> --- In reply to Owen L. Apologies -- bad wording, "functionality" was misleading, maybe "two clicks instead of one"? User friendliness? Ease of a GUI? The *line* "Normal view MARC view ISBD view" (I don't see it as a *table*) is extremely short, appears without breaks even on very small tablets rotated vertically upright. A "drop-down" might save a tad of horizontal screen space (but is probably, pixel-wise, a little taller than a text line), but is less explanatory unless you click it or know ahead of time what you're looking for. That's my (lame) excuse for misusing "functionality." I totally agree that "longer" lists of choices should be "drop down" -- just questioning the user experience of deciding "three textually short" options should be visually, quasi-hidden. At some point (intrinsically if a small screen can't get them all on one line), let's go for it.... Just not at all sure that it's required here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91468&action=edit Example screenshot (In reply to Paul A. from comment #8)
The *line* "Normal view MARC view ISBD view" (I don't see it as a *table*) is extremely short, appears without breaks even on very small tablets rotated vertically upright.
This attachment shows what the Z39.50 popup looks like on my test system, Firefox on Windows 10. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #10 from Paul A. <paul.a@navalmarinearchive.com> --- Created attachment 91470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91470&action=edit screenshot Here is mine in Firefox 60.7.0esr (Ubuntu 18.04) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Our most common use case is: search by union catalog ID (controlnumber) and import as only one result is returned. But I am aware that most of the time there will be a number of result that requires you to take a closer look. I'd vote for bringing back the 3 separate links/butons. I am not opposed to get rid of the pop-up. It often causes issues. An example: People ask why the pop-up no longer appears, not realizing there have minified it before and it's just still open. We have also hidden column in this view in the past. Maybe column configuration would be nice to have here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Paul A. from comment #4)
Excluding spiders, our logs show very few requests for 'cards' but many more for 'MARC'. I can only guess that at item level the data is more complete.
Some of our users find it helpful to look at Card first, since the MARC preview is much more detailed, lengthy and not always sorted. After that they may not pick the record, or in another case look at MARC after all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #13 from Paul A. <paul.a@navalmarinearchive.com> --- (In reply to Marcel de Rooy from comment #12) The comment covered the case of using a "drop-down" box, instead of 3 short html tags which "save a click" -- user ergonomics, office efficiency, GUI ease, whatever. So we're probably not disagreeing, whether it's Z39-50, staff or opac, as it has nothing to do with the user's final choice, just how she gets there. Your users go for "cards", mine for "MARC" -- they'll all be clicking twice instead of once. My suggestion is (if there is reasonable screen space) that the lower limit of "drop-down" choices should be above three (I'm not certain of an exact, immutable value -- it is surely a fairly low number.) Maybe there are logical | practical exceptions, but this is IMHO not one of them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23334 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Patch complexity|--- |Small patch Status|NEW |ASSIGNED --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Ok. Lets try to get this move again.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow faster access to Card |Less clicks on Z3950 search |and MARC view in Z3950 |results |search results | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108285&action=edit Bug 23302: Less clicks on Z3950 search results Functional change: Instead of requiring two clicks for each option in the Actions menu, we add a default action based on previous activity. NOTE: In order to prioritize MARC and Card preview actions, we will only remember Import and Order when it is not preceded by a preview. In other words: If you directly click Import, Import comes back. If you click Card and Import, Card comes back. Technical changes: [1] Combine Preview and Order button on Acquisition Z3950 search. [2] Use Actions link as default action and add button with caret to open the dropdown. [3] Keep last action in localStorage (sessionStorage makes not much sense for the popups), prioritizing previews. [4] Where needed, add title attributes to dropdown links. Use class 'chosen' to differentiate preview popups from import/order actions. [5] Replace previewMARC by previewData in Authority Z3950 search. Remove duplicate code. [6] Use link href from template instead of constructing link in javascript. [7] Removing unused linktools markup from acqui template. Test plan: [1] Start on acqui Z3950. Choose Card once from the menu and then Order. [2] Start auth Z3950. Verify that Default is MARC now. Close popup. (Since Card is no option here.) [3] Start cataloguing Z3950. Verify that you have Card as default. Click Import rightaway. [4] Back to auth Z3950. Verify that Import is default. Click Import. [5] Back to acqui Z3950. Verify that MARC is default (no Import here). Click Order. Go back and verify that Order is now default. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hope this "compromise" meets the most consensus. See commit message of the patch. Ready for testing. One TODO still: we need to facilitate translation of the button text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108285|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 111472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111472&action=edit Bug 23302: Less clicks on Z3950 search results Functional change: Instead of requiring two clicks for each option in the Actions menu, we add a default action based on previous activity. NOTE: In order to prioritize MARC and Card preview actions, we will only remember Import and Order when it is not preceded by a preview. In other words: If you directly click Import, Import comes back. If you click Card and Import, Card comes back. Technical changes: [1] Combine Preview and Order button on Acquisition Z3950 search. [2] Use Actions link as default action and add button with caret to open the dropdown. [3] Keep last action in localStorage (sessionStorage makes not much sense for the popups), prioritizing previews. [4] Where needed, add title attributes to dropdown links. Use class 'chosen' to differentiate preview popups from import/order actions. [5] Replace previewMARC by previewData in Authority Z3950 search. Remove duplicate code. [6] Use link href from template instead of constructing link in javascript. [7] Removing unused linktools markup from acqui template. Test plan: [1] Start on acqui Z3950. Choose Card once from the menu and then Order. [2] Start auth Z3950. Verify that Default is MARC now. Close popup. (Since Card is no option here.) [3] Start cataloguing Z3950. Verify that you have Card as default. Click Import rightaway. [4] Back to auth Z3950. Verify that Import is default. Click Import. [5] Back to acqui Z3950. Verify that MARC is default (no Import here). Click Order. Go back and verify that Order is now default. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased. Please test ! Owen or anyone else ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #19 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Marcel de Rooy from comment #18)
Rebased. Please test ! Owen or anyone else ?
Hi Marcel ! I've got an issue with the patch using Google Chrome (last version 86.0.4240.75), Marc button doesn't work for none of the module (ok when I use the option from the dropdown list). It works fine with Firefox. Could the problem come from my side or from the patch ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Séverine Queune from comment #19)
Hi Marcel ! I've got an issue with the patch using Google Chrome (last version 86.0.4240.75), Marc button doesn't work for none of the module (ok when I use the option from the dropdown list). It works fine with Firefox. Could the problem come from my side or from the patch ?
Séverine, thx for testing. I will try Chrome too to check behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Séverine: Tested on Chrome version 86.0.4240.75 (Official Build) (64-bit) Same version as yours. But all seems to work fine. I can select MARC or Card from the dropdown and it responds. And after that I can click on the button and it works too. Could you verify if the browser cache is not causing it? Use Ctrl+F5 to refresh the page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111472|0 |1 is obsolete| | --- Comment #22 from Michal Denar <black23@gmail.com> --- Created attachment 113910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113910&action=edit Bug 23302: Less clicks on Z3950 search results Functional change: Instead of requiring two clicks for each option in the Actions menu, we add a default action based on previous activity. NOTE: In order to prioritize MARC and Card preview actions, we will only remember Import and Order when it is not preceded by a preview. In other words: If you directly click Import, Import comes back. If you click Card and Import, Card comes back. Technical changes: [1] Combine Preview and Order button on Acquisition Z3950 search. [2] Use Actions link as default action and add button with caret to open the dropdown. [3] Keep last action in localStorage (sessionStorage makes not much sense for the popups), prioritizing previews. [4] Where needed, add title attributes to dropdown links. Use class 'chosen' to differentiate preview popups from import/order actions. [5] Replace previewMARC by previewData in Authority Z3950 search. Remove duplicate code. [6] Use link href from template instead of constructing link in javascript. [7] Removing unused linktools markup from acqui template. Test plan: [1] Start on acqui Z3950. Choose Card once from the menu and then Order. [2] Start auth Z3950. Verify that Default is MARC now. Close popup. (Since Card is no option here.) [3] Start cataloguing Z3950. Verify that you have Card as default. Click Import rightaway. [4] Back to auth Z3950. Verify that Import is default. Click Import. [5] Back to acqui Z3950. Verify that MARC is default (no Import here). Click Order. Go back and verify that Order is now default. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113910|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115030&action=edit Bug 23302: Less clicks on Z3950 search results Functional change: Instead of requiring two clicks for each option in the Actions menu, we add a default action based on previous activity. NOTE: In order to prioritize MARC and Card preview actions, we will only remember Import and Order when it is not preceded by a preview. In other words: If you directly click Import, Import comes back. If you click Card and Import, Card comes back. Technical changes: [1] Combine Preview and Order button on Acquisition Z3950 search. [2] Use Actions link as default action and add button with caret to open the dropdown. [3] Keep last action in localStorage (sessionStorage makes not much sense for the popups), prioritizing previews. [4] Where needed, add title attributes to dropdown links. Use class 'chosen' to differentiate preview popups from import/order actions. [5] Replace previewMARC by previewData in Authority Z3950 search. Remove duplicate code. [6] Use link href from template instead of constructing link in javascript. [7] Removing unused linktools markup from acqui template. Test plan: [1] Start on acqui Z3950. Choose Card once from the menu and then Order. [2] Start auth Z3950. Verify that Default is MARC now. Close popup. (Since Card is no option here.) [3] Start cataloguing Z3950. Verify that you have Card as default. Click Import rightaway. [4] Back to auth Z3950. Verify that Import is default. Click Import. [5] Back to acqui Z3950. Verify that MARC is default (no Import here). Click Order. Go back and verify that Order is now default. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115031&action=edit Bug 23302: (QA follow-up) Fix filters Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- I worry that this is slightly confusing as buttons can change depending on what you do - perhaps you only get one result so import directly even though you normally look at the marc view? It works though, and it decreases clicks for user in many instances so passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #25)
I worry that this is slightly confusing as buttons can change depending on what you do - perhaps you only get one result so import directly even though you normally look at the marc view?
It works though, and it decreases clicks for user in many instances so passing QA
Thanks. But even if there is one result, you might want to view it before importing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Add release notes please, also highlight the new localstorage use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a conflict with bug 11299. Can you rebase please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #28)
There is a conflict with bug 11299. Can you rebase please?
Nasty stuff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115030|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 115661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115661&action=edit Bug 23302: Less clicks on Z3950 search results Functional change: Instead of requiring two clicks for each option in the Actions menu, we add a default action based on previous activity. NOTE: In order to prioritize MARC and Card preview actions, we will only remember Import and Order when it is not preceded by a preview. In other words: If you directly click Import, Import comes back. If you click Card and Import, Card comes back. Technical changes: [1] Combine Preview and Order button on Acquisition Z3950 search. [2] Use Actions link as default action and add button with caret to open the dropdown. [3] Keep last action in localStorage (sessionStorage makes not much sense for the popups), prioritizing previews. [4] Where needed, add title attributes to dropdown links. Use class 'chosen' to differentiate preview popups from import/order actions. [5] Replace previewMARC by previewData in Authority Z3950 search. Remove duplicate code. [6] Use link href from template instead of constructing link in javascript. [7] Removing unused linktools markup from acqui template. Test plan: [1] Start on acqui Z3950. Choose Card once from the menu and then Order. [2] Start auth Z3950. Verify that Default is MARC now. Close popup. (Since Card is no option here.) [3] Start cataloguing Z3950. Verify that you have Card as default. Click Import rightaway. [4] Back to auth Z3950. Verify that Import is default. Click Import. [5] Back to acqui Z3950. Verify that MARC is default (no Import here). Click Order. Go back and verify that Order is now default. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115031|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 115663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115663&action=edit Bug 23302: (QA follow-up) Fix filters Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebase notes: // var data_index = $( this ).data( "index" ); // Import( data_breedingid, data_authid, data_headingcode, "", data_index ); - opener.document.location="../authorities/authorities.pl?breedingid="+Breeding+"&authtypecode="+AuthType+"&authid="+recordid; + opener.document.location="../authorities/authorities.pl?breedingid="+Breeding+"&authtypecode="+AuthType+"&authid="+recordid+"&index="+index; AFAICS The new index parameters should be in the href too already. So this should work. <li><a href="#" class="import_record" data-breedingid="[% breeding_loo.breedingid | html %]" data-heading_code="[% breeding_loo.heading_code | html %]" data-authid="[% breeding_loo.authid | html %]" data-index="[% index | html %]" ><i class="fa fa-download"></i> Import</a></li> Do not really understand why we import with an data-authid value here? I have added the index parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Tested the three forms where we use the Card, Marc, Import or Order buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |On the three forms where we release notes| |use Z3950 search results, | |in acquisitions and | |cataloguing for authorities | |as well as biblios, the | |form remembers your last | |choice for Card or MARC | |view. | | | |Note that this adds | |a new key in localStorage | |of your browser: | |z3950search_last_action. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #27)
Add release notes please, also highlight the new localstorage use.
Do we have a common place for keeping a record of all cookies and localstorage keys Koha is using currently? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27338 [Bug 27338] Use current window as fallback, if no opener window available during importing record from Z39.50 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Marcel de Rooy from comment #34)
(In reply to Jonathan Druart from comment #27)
Add release notes please, also highlight the new localstorage use.
Do we have a common place for keeping a record of all cookies and localstorage keys Koha is using currently?
According guidelines, I think it is here: https://wiki.koha-community.org/wiki/Use_of_Cookies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Isn't it something we actually want to implement for all the dropdown-menu's we have in the "actions" column of our tables? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #37)
Isn't it something we actually want to implement for all the dropdown-menu's we have in the "actions" column of our tables?
Thanks for pushing. Yeah we could make further progress, although it may not be the most important job in Koha now.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #40 from Aleisha Amohia <aleisha@catalyst.net.nz> --- *** Bug 22579 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 [Bug 28773] Aquisitions from external source not working for non english language -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30161 [Bug 30161] Remove duplicate z3950_search include lines -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org