https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143644&action=edit Bug 32145: Fix style of buttons with class .btn-danger This patch adds style to the staff client's global SCSS which adds correct styling to buttons classed with .btn-danger. This isn't the correct way to fix this, but it's the fast way. Rebuilding Bootstrap with custom colors is the correct way, but Bootstrap 3.x doesn't use SCSS. I consider this is a FIXME for an upgrade of Bootstrap in the staff interface. To test, apply the patch and rebuild the staff interface CSS. Test instances where the .btn-danger class is used. Two examples: Holds: - Locate a bibliographic records with holds and view the holds. - Click the "trash" icon to delete one of the holds. - In the confirmation modal, check that the "Confirm cancellation" button looks correct in its default, hover, and active ("clicked") state. Cataloging: - Open a new blank record in the basic MARC editor. - Click "Save" without filling any mandatory fields. - You should see a warning about the empty fields. - Scroll down until the warning is offscreen. An "Errors" button should appear in the toolbar. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143644|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143673&action=edit Bug 32145: Fix style of buttons with class .btn-danger This patch adds style to the staff client's global SCSS which adds correct styling to buttons classed with .btn-danger. This isn't the correct way to fix this, but it's the fast way. Rebuilding Bootstrap with custom colors is the correct way, but Bootstrap 3.x doesn't use SCSS. I consider this is a FIXME for an upgrade of Bootstrap in the staff interface. To test, apply the patch and rebuild the staff interface CSS. Test instances where the .btn-danger class is used. Two examples: Holds: - Locate a bibliographic records with holds and view the holds. - Click the "trash" icon to delete one of the holds. - In the confirmation modal, check that the "Confirm cancellation" button looks correct in its default, hover, and active ("clicked") state. Cataloging: - Open a new blank record in the basic MARC editor. - Click "Save" without filling any mandatory fields. - You should see a warning about the empty fields. - Scroll down until the warning is offscreen. An "Errors" button should appear in the toolbar. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32145 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.