[Bug 12426] New: Allow resending of emails from the notices tab in the patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Bug ID: 12426 Summary: Allow resending of emails from the notices tab in the patron account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Add a link to allow resending a notice from the notices tab in the patron account. Sometimes the email address in the patron record is wrong and the library wants to resend the notices after correcting the email address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #1 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42295&action=edit Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::_set_message_status() to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larit@student.uef.fi Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |larit@student.uef.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 42346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42346&action=edit [Signed-off] Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::_set_message_status() to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #42295|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lari, I really would prefer to see a new subroutine added to C4::Letters covered by tests. Something like C4::Letters::ResendMessage($message_id). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #4 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42401&action=edit Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #5 from Marc Véron <veron@veron.ch> --- Lari, is the first patch obsolete? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42346|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #6 from Lari Taskula <larit@student.uef.fi> --- Marc, yes! Sorry, I forgot to do that. I made some modifications by Jonathan's wish. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42401|0 |1 is obsolete| | --- Comment #7 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42409&action=edit Bug 12426: Allow resending of messages from the notices tab in the patron account Changed return value of ResendMessage() to 1 on success, otherwise 0. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 42418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42418&action=edit [Signed-off] Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42409|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42512&action=edit Bug 12426: Simplify the code adding a new subroutine GetMessage The C4::Letters module does not have a GetMessage subroutine, which could be quite useful. This patch adds it and simplifies the code added by the previous patch. It also adds a few tests and fixes POD typos. Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lari, can I get your opinion on the second patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #11 from Lari Taskula <larit@student.uef.fi> --- Jonathan, I agree we need indeed a way to get messages by id. In fact this will be very useful for me right now because of another bug that requires to get messages by id. Simplifying the code in notices.pl is well done. It is a good idea to move the status "failed" check into ResendMessage() so that it cannot be accidentally called for sent messages. I originally thought it would be up to the programmer to take care of the status check, and allow if he is sure he wants to resend a sent message, but I don't really see why anyone would want to do this. Maybe it is best to make the check inside ResendMessage(). Thanks for the help! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it could be very useful for a library to be able to resent messages that don't have a "failed" status - for example: the library has typoed in the email address. In this cases the email is sent, but bounced back to the library's email address (email account doesn't exist at this provider etc.) and it's up to the library to correct the email address. But the status will be sent. I have been asked a lot if there is a way to trigger a notice again - which is why I filed this bug :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #13 from Lari Taskula <larit@student.uef.fi> --- (In reply to Katrin Fischer from comment #12)
I think it could be very useful for a library to be able to resent messages that don't have a "failed" status - for example: the library has typoed in the email address. In this cases the email is sent, but bounced back to the library's email address (email account doesn't exist at this provider etc.) and it's up to the library to correct the email address. But the status will be sent. I have been asked a lot if there is a way to trigger a notice again - which is why I filed this bug :)
That's a very good point. For some reason I had been ignoring this :) With the current patch it is a bit risky, however. As Jonathan mentioned problems with browser history, (In reply to Jonathan Druart from comment #9)
Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance).
I suggest we change the method of request from GET and make it via AJAX calls to avoid problems caused by browser history. I have been working on REST API for Notices and have done all basic operations including resend. It would be nice to see this feature use the REST API via AJAX calls. Any support for this idea? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm not sure if I understand the browser history problem. Why would a link in the notices table to resend (with old fashioned reload or Ajax) not work? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Mostly asking because the REST API is not there yet - it would be nice if this small but great improvement would not be blocked by the bigger development. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lari Taskula from comment #13)
I suggest we change the method of request from GET and make it via AJAX calls to avoid problems caused by browser history. I have been working on REST API for Notices and have done all basic operations including resend. It would be nice to see this feature use the REST API via AJAX calls. Any support for this idea?
(In reply to Katrin Fischer from comment #15)
Mostly asking because the REST API is not there yet - it would be nice if this small but great improvement would not be blocked by the bigger development.
Exactly what I was going to answer :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #14)
Hm not sure if I understand the browser history problem. Why would a link in the notices table to resend (with old fashioned reload or Ajax) not work?
Clicking on the resend link, will call /cgi-bin/koha/script.pl?op=resend&message_id=42 (or equivalent). If you don't limit the resend to fail messages, a user could unexpectedly recall this url, and resend again the message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So AJAX call or via POST could solved the issue -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #19 from Lari Taskula <larit@student.uef.fi> --- Katrin, As Jonathan mentioned, AJAX would work fine but (with current patch) the following link cgi-bin/koha/members/notices.pl?borrowernumber=1&resendnotice=4 would stay in your browser history. Let's imagine we clicked the link and the message was resent perfectly fine and we want to forget about it. But since it's in the browser history, a staff member can accidentally get back on this page by using the address bar, without realizing that this will resend the message once again. And yes, I understand your concern - it is very problematic that it would be blocked by the REST API since it's not there yet. So what would be the point to use it for such a small feature? But here we are very optimistic and excited about the REST API. I think it is a great opportunity to keep pushing it forward by making features already dependant on it. To use this nice feature you would need to use the REST API - great way to encourage other people to check it out and learn about it :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Everyone is very excited - but woudl be good to have at least the base patches in Koha first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lari Taskula from comment #19)
But here we are very optimistic and excited about the REST API. I think it is a great opportunity to keep pushing it forward by making features already dependant on it. To use this nice feature you would need to use the REST API - great way to encourage other people to check it out and learn about it :)
I personally just mark these patches as BLOCKED since the base is not accepted/validated/etc. It just makes me think "this work will have to rebase for ages". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #22 from Tom Misilo <misilot@fit.edu> --- Would a possible compromise be, accept as is without using the REST API and without being able to resend failed messages? With the understanding that a new bug # be created that enhances this one by using the REST API? That way the functionality libraries have been looking for more then a year is added. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Misilo, I think failed will only cover a really small percentage. I think making it work for all status using a POST could be a little nicer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #24 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42615&action=edit Bug 12426: Allow resend for sent messages This patch allows to resend both sent and failed messages. With messages in 'sent' status, we have to be careful not to accidentally send sent messages again. With the previous patch using GET request, this was likely to happen because of browser storing the GET parameters. This patch changes request method from GET to POST. Instead of a simple link, we now have a form element. In notices.pl we redirect back to notices.pl, because with POST there is a risk of resending the message accidentally by form resubmission at refresh. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42615|0 |1 is obsolete| | --- Comment #25 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42618&action=edit Bug 12426: Allow resend for sent messages To test, find/create a Patron that has sent or failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the sent or failed message 4. Observe that there is nothing for resending the sent or failed message 5. Apply the patches. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 42618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42618 Bug 12426: Allow resend for sent messages Review of attachment 42618: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12426&attachment=42618) ----------------------------------------------------------------- + Your patch introduces trailing whitespaces. ::: members/notices.pl @@ +58,5 @@
my $message = C4::Letters::GetMessage( $message_id ); if ( $message->{borrowernumber} = $borrowernumber ) { C4::Letters::ResendMessage( $message_id ); + # redirect to self to avoid form submission on refresh + print $input->redirect("/cgi-bin/koha/members/notices.pl?borrowernumber=$borrowernumber");
Not sure this is useful, what will happen if the form is resubmit? That will change the status from pending to pending? :) ::: t/db_dependent/Letters.t @@ +18,4 @@
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl; +use Test::More tests => 68;
I'd say we can keep the test you have removed, and adapt it. So we check a message can be resend independently of its status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (I should reread my comments before sending them...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #28 from Lari Taskula <larit@student.uef.fi> --- (In reply to Jonathan Druart from comment #26)
Comment on attachment 42618 [details] [review] Bug 12426: Allow resend for sent messages
Review of attachment 42618 [details] [review]: -----------------------------------------------------------------
+ Your patch introduces trailing whitespaces.
::: members/notices.pl @@ +58,5 @@
my $message = C4::Letters::GetMessage( $message_id ); if ( $message->{borrowernumber} = $borrowernumber ) { C4::Letters::ResendMessage( $message_id ); + # redirect to self to avoid form submission on refresh + print $input->redirect("/cgi-bin/koha/members/notices.pl?borrowernumber=$borrowernumber");
Not sure this is useful, what will happen if the form is resubmit? That will change the status from pending to pending? :)
Without this, when refreshing the page, the browser will ask for resending the form. Some staff member can click refresh to see if the resent message is now in sent status and accidentally put it for resend once again. When we redirect back to notices.pl, form cannot be resent again (at least this was the behavior on my Firefox) even if he/she clicks refresh. It will simply refresh the page without asking/sending any form data again.
::: t/db_dependent/Letters.t @@ +18,4 @@
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl; +use Test::More tests => 68;
I'd say we can keep the test you have removed, and adapt it. So we check a message can be resend independently of its status.
Okay, I'll update it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm one idea - should we exclude pending from being resent? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42618|0 |1 is obsolete| | --- Comment #30 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42620&action=edit Bug 12426: Allow resend for sent messages Keeps the test and checks that resend is successful regardless of message status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42620|0 |1 is obsolete| | --- Comment #31 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42621&action=edit Bug 12426: Allow resend for sent messages Doesn't allow resend for pending messages. It does not make sense. Also keep Jonathan's original tests as they were. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14723 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14843 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 [Bug 14843] Notifications and messages via REST API -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14723 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14855 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14855 [Bug 14855] Resend notices in Notices tab with AJAX + REST -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14964 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would be really nice to see a sign-off for this asap! Please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #33 from Marc Véron <veron@veron.ch> --- I'm sorry, conflict with first patch: CONFLICT (content): Merge conflict in t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15417 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14791 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8688 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org