[Bug 41982] New: Linked items resulting from EasyAnalyticalRecords are not shown on OPAC results page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Bug ID: 41982 Summary: Linked items resulting from EasyAnalyticalRecords are not shown on OPAC results page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org When using EasyAnalyticalRecords, "virtual" items originating from host records are shown in: 1) staff detail, 2) staff results, 3) OPAC detail, but not on OPAC results page. To reproduce (in ktd): 1) Turn EasyAnalyticalRecords on. 2) Link the item 3999900000001 (originating from biblio #1) to biblio #2 (with New > Link to host record). 3) Check that you are able to see the linked item in staff detail and OPAC detail (biblio record #2) and also on the staff results page (make a search with the word 'behind'). Verify that on the OPAC results page (with the same search) you get: "Availability: No items available." This is confusing and inconsistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 194411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194411&action=edit Bug 41982: Linked items resulting from EasyAnalyticalRecords are not shown on OPAC results page When using EasyAnalyticalRecords, "virtual" items originating from host records are shown in: 1) staff detail, 2) staff results, 3) OPAC detail, but not on OPAC results page. This is confusing and inconsistent. To reproduce (in ktd): 1. Turn EasyAnalyticalRecords on. 2. Link the item 3999900000001 (originating from biblio #1) to biblio #2 (with New > Link to host record). 3. Check that you are able to see the linked item in staff detail and OPAC detail (biblio record #2) and also on the staff results page (make a search with the word 'behind'). Verify that on the OPAC results page (with the same search) you get: "Availability: No items available." 4. Apply the patch ; restart_all 5. Repeat p. 3. You should now be able to see information from the linked item on OPAC results page. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 194412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194412&action=edit Bug 41982: Unit tests Caveat, errors from QA script about 'http://' are misleading. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Sponsorship status|--- |Sponsored Comma delimited| |Pontificia Università di list of Sponsors| |San Tommaso d'Aquino | |(Angelicum) Assignee|oleonard@myacpl.org |januszop@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194411|0 |1 is obsolete| | Attachment #194412|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194431&action=edit Bug 41982: Linked items resulting from EasyAnalyticalRecords are not shown on OPAC results page When using EasyAnalyticalRecords, "virtual" items originating from host records are shown in: 1) staff detail, 2) staff results, 3) OPAC detail, but not on OPAC results page. This is confusing and inconsistent. To reproduce (in ktd): 1. Turn EasyAnalyticalRecords on. 2. Link the item 3999900000001 (originating from biblio #1) to biblio #2 (with New > Link to host record). 3. Check that you are able to see the linked item in staff detail and OPAC detail (biblio record #2) and also on the staff results page (make a search with the word 'behind'). Verify that on the OPAC results page (with the same search) you get: "Availability: No items available." 4. Apply the patch ; restart_all 5. Repeat p. 3. You should now be able to see information from the linked item on OPAC results page. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194432&action=edit Bug 41982: Unit tests Caveat, errors from QA script about 'http://' are misleading. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Needs Signoff --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Could we have another signoff here please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|Pontificia Università di |Pontificia Università di list of Sponsors|San Tommaso d'Aquino |San Tommaso d'Aquino |(Angelicum) |(Angelicum), Pontificia | |Università di San Tommaso | |d'Aquino (Angelicum) Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 198218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198218&action=edit Bug 41982: Linked items resulting from EasyAnalyticalRecords are not shown on OPAC results page When using EasyAnalyticalRecords, "virtual" items originating from host records are shown in: 1) staff detail, 2) staff results, 3) OPAC detail, but not on OPAC results page. This is confusing and inconsistent. To reproduce (in ktd): 1. Turn EasyAnalyticalRecords on. 2. Link the item 3999900000001 (originating from biblio #1) to biblio #2 (with New > Link to host record). 3. Check that you are able to see the linked item in staff detail and OPAC detail (biblio record #2) and also on the staff results page (make a search with the word 'behind'). Verify that on the OPAC results page (with the same search) you get: "Availability: No items available." 4. Apply the patch ; restart_all 5. Repeat p. 3. You should now be able to see information from the linked item on OPAC results page. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 198219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198219&action=edit Bug 41982: Unit tests Caveat, errors from QA script about 'http://' are misleading. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Adriana Delgado <adelgado@dma.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adelgado@dma.org --- Comment #8 from Adriana Delgado <adelgado@dma.org> --- +1. We're also experiencing this issue in our catalog. We feel it can create confusion for our users and is misleading. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #9 from koverland@dma.org --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 jstone@dma.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jstone@dma.org --- Comment #10 from jstone@dma.org --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from David Nind <david@davidnind.com> --- The patches still apply, however the tests are failing (from running the qa script): [FAIL] t/db_dependent/XSLT.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 340) forbidden pattern: Use https:// instead of http:// for URLs (line 348) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15851 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26480, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43113 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Comma delimited|Pontificia Università di |Pontificia Università di list of Sponsors|San Tommaso d'Aquino |San Tommaso d'Aquino |(Angelicum), Pontificia |(Angelicum) |Università di San Tommaso | |d'Aquino (Angelicum) | --- Comment #12 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to David Nind from comment #11)
The patches still apply, however the tests are failing (from running the qa script):
[FAIL] t/db_dependent/XSLT.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 340) forbidden pattern: Use https:// instead of http:// for URLs (line 348)
This is possibly a false positive. Checking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 gmartinez@dma.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmartinez@dma.org --- Comment #13 from gmartinez@dma.org --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Confirmed: the xmlns uses `http` across the board and we cannot change. It is correct as-is. False positive error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #15 from David Nind <david@davidnind.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #14)
Confirmed: the xmlns uses `http` across the board and we cannot change. It is correct as-is. False positive error.
Thanks Tomás! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34482 CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|Pontificia Università di |Pontificia Università di list of Sponsors|San Tommaso d'Aquino |San Tommaso d'Aquino |(Angelicum) |(Angelicum), Pontificia | |Università di San Tommaso | |d'Aquino (Angelicum) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198218|0 |1 is obsolete| | Attachment #198219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #16 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203886&action=edit Bug 41982: Linked items resulting from EasyAnalyticalRecords are not shown on OPAC results page When using EasyAnalyticalRecords, "virtual" items originating from host records are shown in: 1) staff detail, 2) staff results, 3) OPAC detail, but not on OPAC results page. This is confusing and inconsistent. To reproduce (in ktd): 1. Turn EasyAnalyticalRecords on. 2. Link the item 3999900000001 (originating from biblio #1) to biblio #2 (with New > Link to host record). 3. Check that you are able to see the linked item in staff detail and OPAC detail (biblio record #2) and also on the staff results page (make a search with the word 'behind'). Verify that on the OPAC results page (with the same search) you get: "Availability: No items available." 4. Apply the patch ; restart_all 5. Repeat p. 3. You should now be able to see information from the linked item on OPAC results page. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #17 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203887&action=edit Bug 41982: Unit tests Caveat, errors from QA script about 'http://' are misleading. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #18 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203888&action=edit Bug 41982: (QA follow-up) Use existing get_hostitemnumbers_of Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41982 --- Comment #19 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I added a patch to use an existing subroutine - in the future we should rethink this to avoid the extra record fetches, but I think it is okay See also bug 27138 - which will need reworked on top of this. Janusz can you check my work and then move to PQA? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org