[Bug 17101] New: Confirm a question before check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Bug ID: 17101 Summary: Confirm a question before check in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: T.Reimann95@gmx.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Here should be a new option for checkin message by itemtypes implemented. This new option required a confirmation from the user (over a question which is written there) bevor the item is checked in. The only possible answer for the question are yes or no. By yes the item is checked in, by no it's not checked in. To give an example what is meant here: If you create the item type audiobook, you then can add the Check in Message : "Does envelope and content match?" and for the check in message type: question. So if now a item with the item type audiobook is checked in, the user is ask : "Does envelope and content match?" and got the answer possibiltys yes and no. At this moment he can't read a new barcode, so he must answer the question. If he answer yes the item is check in, if he answer no the item is not check in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |T.Reimann95@gmx.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #1 from Tobias Reimann <T.Reimann95@gmx.de> --- Created attachment 54380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54380&action=edit Bug 17101 - Confirm a question before check in This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in. Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in 6. Check in the item from 3 7. Click yes ==> item should be check in Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54380|0 |1 is obsolete| | --- Comment #2 from Tobias Reimann <T.Reimann95@gmx.de> --- Created attachment 54381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54381&action=edit Bug 17101 - Confirm a question before check in This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in. Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in 6. Check in the item from 3 7. Click yes ==> item should be check in Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. Sponsored-by: Bücherei Maichingen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54381|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 54386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54386&action=edit Bug 17101 - Confirm a question before check in This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in. Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in 6. Check in the item from 3 7. Click yes ==> item should be check in Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. Sponsored-by: Bücherei Maichingen Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Followed the testplan, works for me. It would be nice to have some kind of message about not checking in the item after hitting cancel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #5 from Tobias Reimann <T.Reimann95@gmx.de> --- Created attachment 54388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54388&action=edit Bug 17101 - Confirm a question before check in This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in. Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in and a message should be displayed 6. Check in the item from 3 7. Click yes ==> item should be check in and a message should be displayed Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. Sponsored-by: Bücherei Maichingen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54386|0 |1 is obsolete| | Attachment #54388|0 |1 is obsolete| | --- Comment #6 from Tobias Reimann <T.Reimann95@gmx.de> --- Created attachment 54389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54389&action=edit Bug 17101 - Style up Added a messag when an item is not checked in, becaus of answer no. (new) Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in and a message should be displayed 6. Check in the item from 3 7. Click yes ==> item should be check in Optional: Before step 4 check others item in, to check if the prevouis check in's are still shown. Sponsored-by: Bücherei Maichingen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54388|-Bug-17101---Confirm-a-ques |Style up 1 filename|tion-before-check-in.patch | Attachment #54388|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54386|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54388|Bug 17101 - Confirm a |Bug 17101 - Style up 1 description|question before check in | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54389|Bug 17101 - Style up |Bug 17101 - Style up 2 description| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #7 from Tobias Reimann <T.Reimann95@gmx.de> --- Created attachment 54390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54390&action=edit Bug 17101 - Confirm a question before check in This patch enable a message for the user after he hit no, by the question in the check in window (new) Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in and a message should be displ ayed 6. Check in the item from 3 7. Click yes ==> item should be check in ed Optional: Before step 4 check others item in, to check if the prevouis check in's Sponsored-by: Bücherei Maichingen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54388|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54389|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54390|Bug 17101 - Confirm a |Bug 17101 - Style up description|question before check in | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Mirko Tietgen <mirko@abunchofthings.net> --- With the second patch, I see a message when the item was not checked in, but there are no messages anymore for the other options besides "Question". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #9 from Tobias Reimann <T.Reimann95@gmx.de> --- Created attachment 54425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54425&action=edit Bug 17101 - Confirm a question before check in This patch enable a message for the user after he hit no, by the question in the check in window. Fixed the bug that no other message are displayed (new) Test plan: 1. Create an itemtype, with the checkinmsgtype question 2. Create an item with the itemtype from 1 3. Check out the item from 2 4. Check in the item from 3 5. Click no ==> item shouldn't be check in and a message should be displ ayed 6. Check in the item from 3 7. Click yes ==> item should be check in ed Optional: Before step 4 check others item in, to check if the prevouis check in's Sponsored-by: Bücherei Maichingen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54425|Bug 17101 - Confirm a |Bug 17101 - Style Up fix description|question before check in | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Tobias Reimann <T.Reimann95@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 54495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54495&action=edit Problem with workflow if hold found There is a problem with the workflow if a hold is found. What should users do first first, confirm hold etc. or confirm question? Confirming hold leads to an internal server error, plack error log says: Fatal: unexpected operator 'cancellationdate' with undef operand at ....Koha/Objects.pm line 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16942 --- Comment #11 from Marc Véron <veron@veron.ch> --- Internal server error when confirming might be related to Bug 16942 See IRC: http://irc.koha-community.org/koha/2016-08-16#i_1849391 Regarding the work flow: It is confusing to have two things to confirm. Maybe two steps are better: First the question about checking in and only after confirming this question the qeustion about holds. What do you think about? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8451 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #12 from Marc Véron <veron@veron.ch> --- Added Bug 8451 as related ("Confusing and problematic double prompt for processing transfers") Setting to "In Discussion" because the whole check in process needs clarification. See: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451#c10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13945 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16884 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15085 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we get this moving again? Maybe put it on the agenda of the next dev meeting? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17150 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17150 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #14 from Tobias Reimann <T.Reimann95@gmx.de> --- Hey, to solve the problem with the order of the information i would suggest following solution: Only one message is shown to the user. The message with the highest priority, is shown first. When it was handeln the next massage is shown. Following priority order should be made: 1. Question 2. Holds 3. Transportation ( only if not treated by holds) Feel free to disscuss it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11063 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sounds good to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #16 from Lisette <lisetteslatah@gmail.com> --- That seems like the correct order to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #17 from Joy Nelson <joy@bywatersolutions.com> --- *** Bug 14525 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Veronica <vgolden@vtc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vgolden@vtc.edu -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org