[Bug 30772] New: Terminology: No reserves are allowed on this item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Bug ID: 30772 Summary: Terminology: No reserves are allowed on this item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Reserves should be holds: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:659 No reserves are allowed on this item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: No reserves |Terminology: Replace |are allowed on this item |instances of "reserve" with | |"hold" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 28578 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135066&action=edit Bug 30772: Terminology: Replace instances of "reserve" with "hold" There were several templates where we were still using the term "reserve" instead of "hold." This patch corrects the ones I found, including in a couple of HTML comments. To test, apply the patch and confirm that the changes look correct and affect only the relevant term. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- For the last change in the patch "Sorry, you are too young to reserve this material.", I think this should read as "Sorry, you are too young to place a hold for this item." instead of "Sorry, you are too young to hold this material." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135066|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 135438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135438&action=edit Bug 30772: Terminology: Replace instances of "reserve" with "hold" There were several templates where we were still using the term "reserve" instead of "hold." This patch corrects the ones I found, including in a couple of HTML comments. To test, apply the patch and confirm that the changes look correct and affect only the relevant term. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 135439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135439&action=edit Bug 30772: (follow-up) Age restriction message Improve age restriction message. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 --- Comment #6 from David Nind <david@davidnind.com> --- I added a follow-up for the age restriction message - hope I have actually improved the message! For testing, I just reviewed the diff, rather than generating these in the user interfaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135438|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 135450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135450&action=edit Bug 30772: Terminology: Replace instances of "reserve" with "hold" There were several templates where we were still using the term "reserve" instead of "hold." This patch corrects the ones I found, including in a couple of HTML comments. To test, apply the patch and confirm that the changes look correct and affect only the relevant term. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135439|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 135451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135451&action=edit Bug 30772: (follow-up) Age restriction message Improve age restriction message. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Code looks good, qa script happy, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30772 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org