[Bug 13521] New: Auth.pm code issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Bug ID: 13521 Summary: Auth.pm code issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org, mtompset@hotmail.com Depends on: 13499 Blocks: 12548, 12954, 13503 Whilst working on bug #13499 a number of minor code issues were highlighted by perltidy. I'll collect patches in here to fix various issues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34975&action=edit Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34976&action=edit Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I believe that's all the semicolin issues caught now.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34975|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 35339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35339&action=edit Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34976|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 35340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35340&action=edit Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35339|0 |1 is obsolete| | Attachment #35340|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35410&action=edit Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35411&action=edit Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch Severity|enhancement |trivial Assignee|gmcharlt@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m, mtj@kohaaloha.com Keywords| |rel_3_14_candidate, | |rel_3_16_candidate --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.16 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org