[Bug 41017] New: Show if item is on hold even if OverduesBlockRenewing is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Bug ID: 41017 Summary: Show if item is on hold even if OverduesBlockRenewing is on Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com I've had a comment by a library that uses OverduesBlockRenewing as well as AllowRenewalLimitOverride (and AllowRenewalOnHoldOverride) that when the item is overdue, the fact that it's on hold is not displayed in the patron's checkouts. Their issue is that while they don't want patrons renewing overdue items from the OPAC, they sometimes override the renewal in the staff interface, but end up unknowingly renewing something that is on hold... To recreate in main: 1. Go to a patron's account and checkout with a past date to create an overdue checkout 2. Place a hold for the same item for another patron 3. View the first patron's checkouts --> In the "Renew" column, it says "On hold" 4. Enable AllowRenewalOnHoldOverride 5. Go back to the patron's checkouts --> The "Renew" column should still say "On hold" 6. Check the "Override renewal restrictions" box --> A check box appears in the "Renew" column, which still displays "On hold" nonetheless 7. Enable OverduesBlockRenewing ("block renewing for all the patron's items") (I think both blocks should work in this scenario, but the library has it set to all) 8. Enable AllowRenewalLimitOverride 9. Go back to the patron's checkouts --> The "Renew" column displays "Not allowed: overdue" (OK) No mention of on hold (NOT OK?) 10. Check the "Override renewal restrictions" box --> A check box appears in the "Renew" column (OK), still no mention of on hold (NOT OK?) The "On hold" mention should be displayed whether or not the item is overdue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #1 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Just adding a bit of background: this behaviour was also present in versions 22.05 and earlier. At that time, Koha prioritised the "no renewal" message when reaching the renewal limit or overdue instead of showing the "hold" alert. It was fixed in 23.05 but seems to have reappeared in 24.05. others bugs mentioning this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36331 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34809 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jyorio@equinoxinitiative.or | |g --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 26440 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown@bywatersolutions.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 40900 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187980&action=edit Bug 41017: Show if item is on hold even if OverduesBlockRenewing is on "On hold" is useful for librarians and we should show it whether or not the item is overdue. There has been several attempts to fix this problem, in C4::Circulation::CanBookBeRenewed, but this patch suggests to have a dedicated (ugly) test for this specific situation. Test plan (from Caroline comment 0): 1. Go to a patron's account and checkout with a past date to create an overdue checkout 2. Place a hold for the same item for another patron 3. View the first patron's checkouts --> In the "Renew" column, it says "On hold" 4. Enable AllowRenewalOnHoldOverride 5. Go back to the patron's checkouts --> The "Renew" column should still say "On hold" 6. Check the "Override renewal restrictions" box --> A check box appears in the "Renew" column, which still displays "On hold" nonetheless 7. Enable OverduesBlockRenewing ("block renewing for all the patron's items") (I think both blocks should work in this scenario, but the library has it set to all) 8. Enable AllowRenewalLimitOverride 9. Go back to the patron's checkouts --> The "Renew" column displays "Not allowed: overdue" with mention of on hold 10. Check the "Override renewal restrictions" box --> A check box appears in the "Renew" column with mention of on hold The "On hold" mention is displayed whether or not the item is overdue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried the patch, but it looks the same as before... I don't see a mention of oh hold at step 9 or 10. Is there something i should have done after applying the patch? I only did reset_all, but maybe there's something else? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Caroline Cyr La Rose from comment #5)
I tried the patch, but it looks the same as before... I don't see a mention of oh hold at step 9 or 10.
Is there something i should have done after applying the patch? I only did reset_all, but maybe there's something else?
There is nothing else. restart_all should be enough. I have retried following the test plan and it still works for me: https://snipboard.io/tzNIbT.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I have retried again and I don't see it... I stopped and restarted my KTD in case that was it (also pulled just in case). I tried three times with a variation of the following ktd down git reset --hard origin/main (in koha) git pull (in koha) git pull (in koha-testing-docker) ktd pull ktd up git bz apply 41017 reset_all With AllowRenewalOnHoldOverride I see the "On hold" message (normal) With OverduesBlockRenewing set to either blocking options and AllowRenewalLimitOverride set to allow I don't see the "On hold" message https://snipboard.io/1kL0Zw.jpg I notice yours doesn't have the same columns as mine. I don't have an extra column where it says "On hold" and I don't have the Claimed returned option. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187980|0 |1 is obsolete| | --- Comment #8 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Created attachment 188105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188105&action=edit Bug 41017: Show if item is on hold even if OverduesBlockRenewing is on "On hold" is useful for librarians and we should show it whether or not the item is overdue. There has been several attempts to fix this problem, in C4::Circulation::CanBookBeRenewed, but this patch suggests to have a dedicated (ugly) test for this specific situation. Test plan (from Caroline comment 0): 1. Go to a patron's account and checkout with a past date to create an overdue checkout 2. Place a hold for the same item for another patron 3. View the first patron's checkouts --> In the "Renew" column, it says "On hold" 4. Enable AllowRenewalOnHoldOverride 5. Go back to the patron's checkouts --> The "Renew" column should still say "On hold" 6. Check the "Override renewal restrictions" box --> A check box appears in the "Renew" column, which still displays "On hold" nonetheless 7. Enable OverduesBlockRenewing ("block renewing for all the patron's items") (I think both blocks should work in this scenario, but the library has it set to all) 8. Enable AllowRenewalLimitOverride 9. Go back to the patron's checkouts --> The "Renew" column displays "Not allowed: overdue" with mention of on hold 10. Check the "Override renewal restrictions" box --> A check box appears in the "Renew" column with mention of on hold The "On hold" mention is displayed whether or not the item is overdue. Signed-off-by: Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Marie-Luce was able to see the change on a "vintage" installation after restarting apache. I tried reset_all AND restart_all on ktd and I still don't see it. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- I wanted to test the patch in a sandbox, but unfortunately it won't apply. Even after restarting all services (including Apache), Koha still isn't displaying "on hold". KTD and Open Fifth Sandbox aren't displaying "on hold", whereas my old "vintage" main is. Here is the sandbox in case anyone is interested in checking. https://staff-mlinlibro.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/circ/circul... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marie-Luce Laflamme from comment #10)
I wanted to test the patch in a sandbox, but unfortunately it won't apply. Even after restarting all services (including Apache), Koha still isn't displaying "on hold". KTD and Open Fifth Sandbox aren't displaying "on hold", whereas my old "vintage" main is. Here is the sandbox in case anyone is interested in checking. https://staff-mlinlibro.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/circ/ circulation.pl?borrowernumber=3
At which steps? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #12 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Sorry, I've forgot to mention that it doesn't work in step 9 and 10 after enabling all system preferences in the test plan: - AllowRenewalOnHoldOverride - OverduesBlockRenewing ("block renewing for all the patron's items") - AllowRenewalLimitOverride. Unfortunately, Koha isn't displaying the "on hold" mention in the 'renew' column whether or not you check the override check box. Have a look at this example: https://staff-mlinlibro.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/circ/circul... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Mikko Liimatainen <mikko.liimatainen@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikko.liimatainen@turku.fi --- Comment #13 from Mikko Liimatainen <mikko.liimatainen@turku.fi> --- Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 had a suggestion to show "On hold" with no remaining renewals. It seems to me that could be accomplished here by checking if $can_renew_error is "too_many" and doing the same thing that this fix is doing. Could we get that as well here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41873 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 41873 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, late to the party :( I filed the third duplicate bug for this today - what do we need to get this moving again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #16 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- We received feedback from clients about this. It's impacting library staff and slowing down their workflow. Ideally, "On hold" should take priority over other messages in the renewal column to avoid confusion and ensure smoother processing. Thanks for looking into this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- I have retried and everything is working for me. I see that at step 10: https://snipboard.io/zP03ko.jpg https://snipboard.io/qFHhTL.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193501&action=edit Bug 41017: (bug 41484 follow-up) Adjust 'on hold' Patch from commit f63ae1e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41484 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #19 from David Nind <david@davidnind.com> --- I attempted to test, but found the test plan confusing because of: 1. The wording changes from bug 41484. 2. It's not clear to me what the current behavour is (allowing or not allowing staff to override the renewal), and what it should be after the patch. Could the test plan be updated to reflect the before and after behavour, along with the updated wording? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, the override should not be allowed, if you also have AllowRenewalOnHoldOverride set to "Allow", but the hold information should always be visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #20)
Hi David, the override should not be allowed, if you also have AllowRenewalOnHoldOverride set to "Allow", but the hold information should always be visible.
I'll try to have a go in a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but this still doesn't work as expected and the text was changed to the simpler 'on hold' before in the cases it did show. Can you please have another look? 1) QA checks Is this something in my config not being right? [FAIL] svc/checkouts FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl svc/checkouts` 2) Testing Test cases: - Patron A with 3 checkouts from different records, all on hold for others 1) renewal still possible 2) overdue, renewals possible 3) renewals maxed out Expectation: - We want the system to ALWAYS show "on hold" for these checkouts, independent of system preference settings. - in the list of checkouts initially - after override renewal is clicked - Renewals of 'on hold' should be blocked with AllowRenewalOnHoldOverride "not allow" Testing: Combination A: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Not allow - OverduesBlockRenewing = block renewing for all FAIL - All items show "no renewal allowed: overdue, 'on hold' is missing. - Items can be renewed with override. Combination B: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Not allow - OverduesBlockRenewing = only this item FAIL - On hold information is only shown for 1 out of 3. 1) OK renewal still possible 2) FAIL overdue, renewals possible 3) FAIL renewals maxed out - Overdue item and maxed out renewals don't show 'hold' info (2 + 3) - FAIL Item with option to renew shows 'hold info' (1), but new text "Item on hold for another patron" is too long. Please change back to the "On hold" previously used. Combination C: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Not allow - OverduesBlockRenewing = allow renewing FAIL - On hold inforation is only shown for 2 out of 3 1) OK renewal still possible 2) OK overdue, renewals possible 3) FAIL renewals maxed out - override renewal doesn't activate checkbox for visible 'on holds' Combination D: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Allow - OverduesBlockRenewing = allow renewing FAIL - On hold inforation is only shown for 2 out of 3 1) OK renewal still possible 2) OK overdue, renewals possible 3) FAIL renewals maxed out - override renewal does activate checkboxes for visible 'on holds' (OK, but should be all 3) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #23 from David Nind <david@davidnind.com> --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #24 from Aude Charillon <aude.charillon@openfifth.co.uk> --- I am coming to this bug after a librarian raised an issue. In their case, the only difference to the examples already mentioned is that they use automatic renewals. Once all renewals allowed have been used, we lose the "On hold" message: the Renew column only says "Not renewable". This is a problem as staff will renew manually using the override option, not realising there is a hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Aude Charillon from comment #24)
I am coming to this bug after a librarian raised an issue. In their case, the only difference to the examples already mentioned is that they use automatic renewals. Once all renewals allowed have been used, we lose the "On hold" message: the Renew column only says "Not renewable".
This is a problem as staff will renew manually using the override option, not realising there is a hold.
Did you test the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #22)
I am sorry, but this still doesn't work as expected and the text was changed to the simpler 'on hold' before in the cases it did show. Can you please have another look?
Same for me! :D I have applied the patches, reset_all. 3 overdue checkouts for edna MariaDB [koha_kohadev]> select borrowernumber, itemnumber, date_due from issues; +----------------+------------+---------------------+ | borrowernumber | itemnumber | date_due | +----------------+------------+---------------------+ | 5 | 1 | 2026-05-01 23:59:00 | | 5 | 12 | 2026-05-01 23:59:00 | | 5 | 19 | 2026-05-01 23:59:00 | +----------------+------------+---------------------+ On hold for Henry: MariaDB [koha_kohadev]> select itemnumber, borrowernumber from reserves; +------------+----------------+ | itemnumber | borrowernumber | +------------+----------------+ | 19 | 19 | | 12 | 19 | | 1 | 19 | +------------+----------------+ The sysprefs: +----------------------------+-------+ | variable | value | +----------------------------+-------+ | AllowRenewalLimitOverride | 1 | | AllowRenewalOnHoldOverride | 0 | | OverduesBlockRenewing | block | +----------------------------+-------+ So we are in ``` Combination A: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Not allow - OverduesBlockRenewing = block renewing for all - All items show "no renewal allowed: overdue, 'on hold' is missing. ``` => I do see the "on hold": https://snipboard.io/MGSpz0.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't see the difference in our testing currently :( I am short on time this week, maybe someone else would be willing to run the test plan to see if there is a difference we might have missed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #28 from Mikko Liimatainen <mikko.liimatainen@turku.fi> --- I tried if this solves our issue with hold not showing if renewals were maxed out, but doesn't seem like it. I don't think I'll have enough time to do thorough testing until next week at the earliest, but I would like to see this go forward so I'll try to find time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Mikko Liimatainen from comment #28)
I tried if this solves our issue with hold not showing if renewals were maxed out, but doesn't seem like it. I don't think I'll have enough time to do thorough testing until next week at the earliest, but I would like to see this go forward so I'll try to find time.
Thanks Mikko, another set of eyes would help a lot I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017 --- Comment #30 from Mikko Liimatainen <mikko.liimatainen@turku.fi> --- I followed Katrins testplan as the earlier plan didn't include testing for maxed out renewals. Test cases: - Patron A with 3 checkouts from different records, all on hold for others 1) renewal still possible 2) overdue, renewals possible 3) renewals maxed out Expectation: - We want the system to ALWAYS show "on hold" for these checkouts, independent of system preference settings. - in the list of checkouts initially - after override renewal is clicked - Renewals of 'on hold' should be blocked with AllowRenewalOnHoldOverride "not allow" Testing: Combination A: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Not allow - OverduesBlockRenewing = block renewing for all FAIL - Renewable items show "not allowed: overdue", maxed out shows "not renewable", 'on hold' is missing. - Maxed out item can be renewed with override. I guess this thecnically works correctly, since the item isn't shown being on hold, but this really is the biggest problem we have with this so I interpret this as a fail. Combination B: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Not allow - OverduesBlockRenewing = only this item FAIL - On hold information is only shown for 1 out of 3. 1) OK renewals possible 2) FAIL overdue, renewals possible 3) FAIL renewals maxed out - Overdue item and maxed out renewals don't show 'hold' info (2 + 3) - Maxed out item can be renewed with override. Combination C: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Not allow - OverduesBlockRenewing = allow renewing FAIL renewals maxed out Combination D: - AllowRenewalLimitOverride = Allow - AllowRenewalOnHoldOverride = Allow - OverduesBlockRenewing = allow renewing FAIL renewals maxed out -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org