https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91038&action=edit Bug 23224: Fix inconsistent behaviour of memberentry.pl When editing a child patron (in memberentry.pl) and changing their patron category to a non-child patron category Koha does not set the guarantorid to 0. This means we end up with non-child patrons with guarantors, which is currently not allowed by Koha. Whereas the behaviour in child-update.pl (which can be accessed from a patrons summary page by clicking 'More'->Update child to adult patron') sets the borrowers guarantorid value to 0. This is the correct behaiviour and is what memberentry.pl should be doing. This patch fixes that. Test plan: See how memberentry.pl currently behaves 1. Create a adult patron and select 'Add child' and create the child record. 2. Enter the Koha MySQL terminal and select the guarantorid value for the child record you just created: SELECT guarantorid FROM borrowers WHERE userid=<username>; 3. Notice the guarantorid is set to the adult patrons borrowernumber 4. On the child record select 'Edit' and in the memberentry.pl page change the category to any non-child patron category (for example 'Patron') and save 5. Repeat step 2 and notice the guarantorid value has not changed ---- See how child-update.pl currently behaves 6. Repeat steps 1-3 and on the child record select More > Update child to adult patron 7. In the child-update.pl window that loads select any patron category and save 8. Repeat step 2 and notice the guarantorid is now 0 ---- See how the patch fixes the behaviour of memberentry.pl 9. Apply patch 10. Repeat steps 1-5 and notice the guarantorid is now 0 Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91041&action=edit Bug 23224: Fix inconsistent behaviour of memberentry.pl When editing a child patron (in memberentry.pl) and changing their patron category to a non-child patron category Koha does not set the guarantorid to 0. This means we end up with non-child patrons with guarantors, which is currently not allowed by Koha. Whereas the behaviour in child-update.pl (which can be accessed from a patrons summary page by clicking 'More'->Update child to adult patron') sets the borrowers guarantorid value to 0. This is the correct behaiviour and is what memberentry.pl should be doing. This patch fixes that. Test plan: See how memberentry.pl currently behaves 1. Create a adult patron and select 'Add child' and create the child record. 2. Enter the Koha MySQL terminal and select the guarantorid value for the child record you just created: SELECT guarantorid FROM borrowers WHERE userid=<username>; 3. Notice the guarantorid is set to the adult patrons borrowernumber 4. On the child record select 'Edit' and in the memberentry.pl page change the category to any non-child patron category (for example 'Patron') and save 5. Repeat step 2 and notice the guarantorid value has not changed ---- See how child-update.pl currently behaves 6. Repeat steps 1-3 and on the child record select More > Update child to adult patron 7. In the child-update.pl window that loads select any patron category and save 8. Repeat step 2 and notice the guarantorid is now 0 ---- See how the patch fixes the behaviour of memberentry.pl 9. Apply patch 10. Repeat steps 1-5 and notice the guarantorid is now empty Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91042&action=edit Bug 23224: Fix inconsistent behaviour of memberentry.pl When editing a child patron (in memberentry.pl) and changing their patron category to a non-child patron category Koha does not set the guarantorid to 0. This means we end up with non-child patrons with guarantors, which is currently not allowed by Koha. Whereas the behaviour in child-update.pl (which can be accessed from a patrons summary page by clicking 'More'->Update child to adult patron') sets the borrowers guarantorid value to 0. This is the correct behaiviour and is what memberentry.pl should be doing. This patch fixes that. Test plan: See how memberentry.pl currently behaves 1. Create a adult patron and select 'Add child' and create the child record. 2. Enter the Koha MySQL terminal and select the guarantorid value for the child record you just created: SELECT guarantorid FROM borrowers WHERE userid=<username>; 3. Notice the guarantorid is set to the adult patrons borrowernumber 4. On the child record select 'Edit' and in the memberentry.pl page change the category to any non-child patron category (for example 'Patron') and save 5. Repeat step 2 and notice the guarantorid value has not changed ---- See how child-update.pl currently behaves 6. Repeat steps 1-3 and on the child record select More > Update child to adult patron 7. In the child-update.pl window that loads select any patron category and save 8. Repeat step 2 and notice the guarantorid is now 0 ---- See how the patch fixes the behaviour of memberentry.pl 9. Apply patch 10. Repeat steps 1-5 and notice the guarantorid is now empty Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91043&action=edit Bug 23224: Fix inconsistent behaviour of memberentry.pl When editing a child patron (in memberentry.pl) and changing their patron category to a non-child patron category Koha does not set the guarantorid to 0. This means we end up with non-child/non-professional patrons with guarantors, which is currently not allowed by Koha. Whereas the behaviour in child-update.pl (which can be accessed from a patrons summary page by clicking 'More'->Update child to adult patron') sets the borrowers guarantorid value to 0. This is the correct behaiviour and is what memberentry.pl should be doing. This patch fixes that. Test plan: See how memberentry.pl currently behaves 1. Create a adult patron and select 'Add child' and create the child record. 2. Enter the Koha MySQL terminal and select the guarantorid value for the child record you just created: SELECT guarantorid FROM borrowers WHERE userid=<username>; 3. Notice the guarantorid is set to the adult patrons borrowernumber 4. On the child record select 'Edit' and in the memberentry.pl page change the category to any non-child/non-professional patron category (for example 'Patron') and save 5. Repeat step 2 and notice the guarantorid value has not changed ---- See how child-update.pl currently behaves 6. Repeat steps 1-3 and on the child record select More > Update child to adult patron 7. In the child-update.pl window that loads select any patron category and save 8. Repeat step 2 and notice the guarantorid is now 0 ---- See how the patch fixes the behaviour of memberentry.pl 9. Apply patch 10. Repeat steps 1-5 and notice the guarantorid is now empty ---- Confirm the guarantorid is not removed when editing a patrons category to a patron category with the category type of 'professional' as in Koha professional patron categories can have guarantors 11. Repeat steps 1-3 and select 'Edit' on the childs record and change the patron category to a 'professional' patron category and then save 12. Check the database and confirm that the guarantorid is unchanged Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inconsistent behaviour |Inconsistent behaviour |between memberentry.pl and |between memberentry.pl and |the update-member.pl when |the update-child.pl when |updating child patron to |updating child patron to |Adult |Adult -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Liz Rea (ByWater) <liz@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91043|0 |1 is obsolete| | --- Comment #6 from Liz Rea (ByWater) <liz@bywatersolutions.com> --- Created attachment 91109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91109&action=edit Bug 23224: Fix inconsistent behaviour of memberentry.pl When editing a child patron (in memberentry.pl) and changing their patron category to a non-child patron category Koha does not set the guarantorid to 0. This means we end up with non-child/non-professional patrons with guarantors, which is currently not allowed by Koha. Whereas the behaviour in child-update.pl (which can be accessed from a patrons summary page by clicking 'More'->Update child to adult patron') sets the borrowers guarantorid value to 0. This is the correct behaiviour and is what memberentry.pl should be doing. This patch fixes that. Test plan: See how memberentry.pl currently behaves 1. Create a adult patron and select 'Add child' and create the child record. 2. Enter the Koha MySQL terminal and select the guarantorid value for the child record you just created: SELECT guarantorid FROM borrowers WHERE userid=<username>; 3. Notice the guarantorid is set to the adult patrons borrowernumber 4. On the child record select 'Edit' and in the memberentry.pl page change the category to any non-child/non-professional patron category (for example 'Patron') and save 5. Repeat step 2 and notice the guarantorid value has not changed ---- See how child-update.pl currently behaves 6. Repeat steps 1-3 and on the child record select More > Update child to adult patron 7. In the child-update.pl window that loads select any patron category and save 8. Repeat step 2 and notice the guarantorid is now 0 ---- See how the patch fixes the behaviour of memberentry.pl 9. Apply patch 10. Repeat steps 1-5 and notice the guarantorid is now empty ---- Confirm the guarantorid is not removed when editing a patrons category to a patron category with the category type of 'professional' as in Koha professional patron categories can have guarantors 11. Repeat steps 1-3 and select 'Edit' on the childs record and change the patron category to a 'professional' patron category and then save 12. Check the database and confirm that the guarantorid is unchanged Sponsored-By: Brimbank Library, Australia Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Liz Rea (ByWater) <liz@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91109|0 |1 is obsolete| | --- Comment #8 from Liz Rea (ByWater) <liz@bywatersolutions.com> --- Created attachment 91110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91110&action=edit Bug 23224: Fix inconsistent behaviour of memberentry.pl When editing a child patron (in memberentry.pl) and changing their patron category to a non-child patron category Koha does not set the guarantorid to 0. This means we end up with non-child/non-professional patrons with guarantors, which is currently not allowed by Koha. Whereas the behaviour in child-update.pl (which can be accessed from a patrons summary page by clicking 'More'->Update child to adult patron') sets the borrowers guarantorid value to 0. This is the correct behaiviour and is what memberentry.pl should be doing. This patch fixes that. Test plan: See how memberentry.pl currently behaves 1. Create a adult patron and select 'Add child' and create the child record. 2. Enter the Koha MySQL terminal and select the guarantorid value for the child record you just created: SELECT guarantorid FROM borrowers WHERE userid=<username>; 3. Notice the guarantorid is set to the adult patrons borrowernumber 4. On the child record select 'Edit' and in the memberentry.pl page change the category to any non-child/non-professional patron category (for example 'Patron') and save 5. Repeat step 2 and notice the guarantorid value has not changed ---- See how child-update.pl currently behaves 6. Repeat steps 1-3 and on the child record select More > Update child to adult patron 7. In the child-update.pl window that loads select any patron category and save 8. Repeat step 2 and notice the guarantorid is now 0 ---- See how the patch fixes the behaviour of memberentry.pl 9. Apply patch 10. Repeat steps 1-5 and notice the guarantorid is now empty ---- Confirm the guarantorid is not removed when editing a patrons category to a patron category with the category type of 'professional' as in Koha professional patron categories can have guarantors 11. Repeat steps 1-3 and select 'Edit' on the childs record and change the patron category to a 'professional' patron category and then save 12. Check the database and confirm that the guarantorid is unchanged Sponsored-By: Brimbank Library, Australia Signed-off-by: Liz Rea <liz@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91110|0 |1 is obsolete| | --- Comment #9 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 91115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91115&action=edit Bug 23224: Fix inconsistent behaviour of memberentry.pl When editing a child patron (in memberentry.pl) and changing their patron category to a non-child patron category Koha does not set the guarantorid to 0. This means we end up with non-child/non-professional patrons with guarantors, which is currently not allowed by Koha. Whereas the behaviour in child-update.pl (which can be accessed from a patrons summary page by clicking 'More'->Update child to adult patron') sets the borrowers guarantorid value to 0. This is the correct behaiviour and is what memberentry.pl should be doing. This patch fixes that. Test plan: See how memberentry.pl currently behaves 1. Create a adult patron and select 'Add child' and create the child record. 2. Enter the Koha MySQL terminal and select the guarantorid value for the child record you just created: SELECT guarantorid FROM borrowers WHERE userid=<username>; 3. Notice the guarantorid is set to the adult patrons borrowernumber 4. On the child record select 'Edit' and in the memberentry.pl page change the category to any non-child/non-professional patron category (for example 'Patron') and save 5. Repeat step 2 and notice the guarantorid value has not changed ---- See how child-update.pl currently behaves 6. Repeat steps 1-3 and on the child record select More > Update child to adult patron 7. In the child-update.pl window that loads select any patron category and save 8. Repeat step 2 and notice the guarantorid is now 0 ---- See how the patch fixes the behaviour of memberentry.pl 9. Apply patch 10. Repeat steps 1-5 and notice the guarantorid is now empty ---- Confirm the guarantorid is not removed when editing a patrons category to a patron category with the category type of 'professional' as in Koha professional patron categories can have guarantors 11. Repeat steps 1-3 and select 'Edit' on the childs record and change the patron category to a 'professional' patron category and then save 12. Check the database and confirm that the guarantorid is unchanged Sponsored-By: Brimbank Library, Australia Signed-off-by: Liz Rea <liz@bywatersolutions.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I've managed to make this explode :( 1) Searched for a child patron 2) Added a guarantor 3) Edit patron 4) Switch patron category to "Patron" (Adult) 5) No property guarantorid for Koha::Patron at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes.