[Bug 35198] New: Sort database column names alphabetically on automatic item modification page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 Bug ID: 35198 Summary: Sort database column names alphabetically on automatic item modification page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In Cataloging -> Automatic item modifications by age, when adding or editing a rule there are several dropdowns for selecting which column in the items or biblioitems tables to use. These lists are currently not in alphabetical order, making it hard to locate the field you want. We can add the Template::Toolkit "sort" method to sort them alphabetically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158120&action=edit Bug 35198: Sort database column names alphabetically on automatic item modification page This patch modifies the automatic item modification by age page so that the rule entry form sorts <select>s alphabetically, making it easier to find the entry you need. The [% FOR field IN... %] directives now include the "sort" method, e.g. [% FOR field IN agefields.sort %] To test, apply the patch and go to Cataloging -> Item modifications by age - Click the "Add rules" button, then the "Add rule" button. - Check the "Age field," "Conditions," and "Substitutions" dropdowns to confirm that the choices are listed alphabetically. - Fill in the form and save the rule. - Go back and edit the rule you created. Check that the dropdowns are still correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158120|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 158176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158176&action=edit Bug 35198: Sort database column names alphabetically on automatic item modification page This patch modifies the automatic item modification by age page so that the rule entry form sorts <select>s alphabetically, making it easier to find the entry you need. The [% FOR field IN... %] directives now include the "sort" method, e.g. [% FOR field IN agefields.sort %] To test, apply the patch and go to Cataloging -> Item modifications by age - Click the "Add rules" button, then the "Add rule" button. - Check the "Age field," "Conditions," and "Substitutions" dropdowns to confirm that the choices are listed alphabetically. - Fill in the form and save the rule. - Go back and edit the rule you created. Check that the dropdowns are still correct. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off CC| |andrew.auld@ptfs-europe.com --- Comment #3 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Brilliant job Owen, works perfectly! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158176|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158225&action=edit Bug 35198: Sort database column names alphabetically on automatic item modification page This patch modifies the automatic item modification by age page so that the rule entry form sorts <select>s alphabetically, making it easier to find the entry you need. The [% FOR field IN... %] directives now include the "sort" method, e.g. [% FOR field IN agefields.sort %] To test, apply the patch and go to Cataloging -> Item modifications by age - Click the "Add rules" button, then the "Add rule" button. - Check the "Age field," "Conditions," and "Substitutions" dropdowns to confirm that the choices are listed alphabetically. - Fill in the form and save the rule. - Go back and edit the rule you created. Check that the dropdowns are still correct. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport. Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35198 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org