http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5929 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |savitra.sirohi@osslabs.biz Assignee|henridamien@koha-fr.org |savitra.sirohi@osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9491&action=edit Bug 5544 - All Notices from Branch Email Address Right now overdues from from the branch, but the others come from the admin email address - this is a problem in multi-branch systems because they have to come up with one email address that all branches have access to. C4::Letters::_send_message_by_email currently sets the from address in the following order: 1) Address specified in message 2) Koha admin email address The order will now be: 1) Address specified in message 2) Borrowers home library email address 3) Koha admin email address -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: I think you can rewrite + my $branch = GetBranchDetail( $member->{'branchcode'} ); + From => $message->{'from_address'} || $branch->{'branchemail'} || C4::Context->preference('KohaAdminEmailAddress'), With: From => $message->{'from_address'} || GetBranchDetail( $member->{'branchcode'} )->{'branchemail'} || C4::Context->preference('KohaAdminEmailAddress'), In order to bypassed an useless call (GetBranchDetail) in some cases ($message->{from_address} not defined). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I tested this and it worked as expected when processing item checkout notices. I'm not sure how to test case 1) Address specified in message. Where does that arise? Does comment 2 imply that this has failed QA? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9491|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12164&action=edit Bug 5544 - All Notices from Branch Email Address Right now overdues from from the branch, but the others come from the admin email address - this is a problem in multi-branch systems because they have to come up with one email address that all branches have access to. C4::Letters::_send_message_by_email currently sets the from address in the following order: 1) Address specified in message 2) Koha admin email address The order will now be: 1) Address specified in message 2) Borrowers home library email address 3) Koha admin email address -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #3)

I tested this and it worked as expected when processing item checkout notices. I'm not sure how to test case 1) Address specified in message. Where does that arise?

I checked the code, and as far as I can tell, there is no code in Koha the currently uses case 1. _send_message_by_email is only called by SendQueuedMessages, which is only used in misc/cronjobs/process_message_queue.pl I'm guessing that it is vestigial. We could remove but, but it does provide some flexibility that may be useful in the future. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12164|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14888&action=edit Bug 5544 - All Notices from Branch Email Address Right now overdues from from the branch, but the others come from the admin email address - this is a problem in multi-branch systems because they have to come up with one email address that all branches have access to. C4::Letters::_send_message_by_email currently sets the from address in the following order: 1) Address specified in message 2) Koha admin email address The order will now be: 1) Address specified in message 2) Borrowers home library email address 3) Koha admin email address -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |liz@catalyst.net.nz --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- No test plan, failed for now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- This works as advertised, however, it may introduce a warning in the case where $member is not defined. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18036|0 |1 is obsolete| | --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19437&action=edit Bug 5544 - All Notices from Branch Email Address Right now overdues come from the branch, but the others come from the admin email address - this is a problem in multi-branch systems because they have to come up with one email address that all branches have access to. C4::Letters::_send_message_by_email currently sets the from address in the following order: 1) Address specified in message 2) Koha admin email address The order will now be: 1) Address specified in message 2) Borrowers home library email address 3) Koha admin email address Test Plan: 1) Set your branch email addresses, and the KohaAdminEmailAddress Make sure each of them are unqiue 2) Choose a borrower, enable the enhanced messaging and enable the checkout and checkin email notices. Use your email address for the borrower's email so you can recieve the emails. 3) Check out an item, check the from address of the email, it should be the email addres set in KohaAdminEmailAddress 4) Apply the patch 5) Return the item, check the from address of the email, it should match the email address set for the borrowers home library. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #14)

(In reply to Chris Cormack from comment #12)

...

This works as advertised, however, it may introduce a warning in the case where $member is not defined.

Bit worried about this comment - we tend to forget that we have a message that goes to the library and therefore has no borrowernumber in message_queue - overdues digest for patrons without email address.

I agree with that, the undefined borrowernumber case should be take into account. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20807&action=edit Bug 5544 - All Notices from Branch Email Address - QA Followup -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20807|0 |1 is obsolete| | --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 21353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21353&action=edit Bug 5544 - All Notices from Branch Email Address - QA Followup Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Works as advertised. No complaints from qa tools. Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes.