[Bug 28161] New: Allow Koha::Patron->extended_attributes be passed a library_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28161 Bug ID: 28161 Summary: Allow Koha::Patron->extended_attributes be passed a library_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Koha::Patron::Attributes->filter_by_branch_limitations accepts the parameter, and falls back to C4::Context->userenv->{branch} if omitted. Lacking the parameter in Koha::Patron->extended_attributes makes it always fallback to userenv, thus forcing the caller to deal with that instead of just passing the parameter. Examples: - A CLI script with a --library_id param for setting extended attributes would be forced to mock a userenv for checks to work - An API route would need to deal with that as well. A minor and harmless change adding this parameter would allow more straight-forward use of this method. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28161 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23666 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 [Bug 23666] Add routes for extended patron attributes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28161 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion Blocks|23666 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23666 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- With bug 28157 I'm not going forward with this one. Not closing it, as it might be handy in a near future. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 [Bug 23666] Add routes for extended patron attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28161 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sure this can't be closed? Or moved out of "In discussion" if it would be deemed useful? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org