[Bug 40575] New: Transferring order will reload the page and its form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Bug ID: 40575 Summary: Transferring order will reload the page and its form Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org Test plan: 1 - Create two baskets: "Source Basket" and "Dest Basket" 2 - Add one command line to "Source Basket" 3 - Close the basket 4 - Receive shipment 5 - Receive order 6 - Cancel the order receive 7 - Transfer the order to the Dest Basket -> When clicking on chose, you will be asked if you want to send again infos (which were sent to cancel the order receive), and if accepting, you will be printed an error. 8 - Apply patch 9 - Repeat the process with another source Basket and notice the page is simply reloaded without sending form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184988&action=edit Bug 40575: Transferring order will reload the page and its form Test plan: 1 - Create two baskets: "Source Basket" and "Dest Basket" 2 - Add one command line to "Source Basket" 3 - Close the basket 4 - Receive shipment 5 - Receive order 6 - Cancel the order receive 7 - Transfer the order to the Dest Basket -> When clicking on chose, you will be asked if you want to send again infos (which were sent to cancel the order receive), and if accepting, you will be printed an error. 8 - Apply patch 9 - Repeat the process with another source Basket and notice the page is simply reloaded without sending form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Ludovic <ludovic.julien@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ludovic.julien@inLibro.com --- Comment #2 from Ludovic <ludovic.julien@inLibro.com> --- Hello, I tried to test the patch for Bug 40575, but currently all links to vendors "http://master-intranet/cgi-bin/koha/acquisition/vendors/add" return a 404 error. This issue is unrelated to your patch, so it’s not a fault of your work. Once the major problem with the vendor links is resolved, I will be able to properly test the patch. For now, it will require another look at that time. Thank you for your understanding. Best regards :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Component|About |Acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I attempted to test. The good news is that the patch still applies! The not so good news, is that I'm not sure exactly what this is fixing or what I am supposed to see, particularly for Step 7 of the test plan. (I have some screenshots, but I don't think they will help.) Can you break down Step 7 some more? Everything is okay up until choosing the destination basket: 1. I get the browser message “Transfer order to this basket?”, with Cancel and OK as options. 2. If I click OK, I end up at the "Receive orders from My Vendor" page, which lists the destination basket. - The order is now shown for this basket. - I don't get any error. 3. If I reset everything, apply the patch, and repeat the steps, I don't see any changes. Not sure what I should be seeing, what the error is, or what the expected behavour is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hi, On main there is no breaking error, but I could still experience an error. Assuming you are on ktd. After 6, you should be on On /cgi-bin/koha/acqui/parcel.pl, with one line in Pending orders, and no line in "already received". The line is in "source basket", of basket group "source basket": 7.1 - click "transfer" of the line 7.2 - Click search, choose "My vendor" 7.3 - Click on the "Choose" button in the "dest basket". 7.4 - There is a first alert: "Transfer order to this basket?", click ok 7.5 - There is a second alert, which should not be displayed. Since it depends on browser I don't have the exact wording, but it asks you if you want to send again the information to firefox. If you click "send again", it sends again the cancellation form which was sent to display this page during 6-, so there is an error "Cannot cancel receipt. Possible reasons: The order line you are trying to cancel was created from a partial receipt of another order line which is already received. Try to cancel this one first and retry. The order line you are trying to cancel was created from a partial receipt of another order line which has been deleted. Cancellation is not possible." Note: After 6, you can try and reload and see if you have a notification. If you have some, cancel and proceed to 7.1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried testing, but I am currently blocked by my installation giving an error on the pending orders table that blocks me from getting to the transfer link: [ERROR] GET /api/v1/acquisitions/orders: unhandled exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'biblio.biblionumber' in 'WHERE' at /kohadevbox/koha/Koha/Objects.pm line 401>> This is without the patch - posted to Mattermost as well. Maybe someone else could give it a try? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #5)
I tried testing, but I am currently blocked by my installation giving an error on the pending orders table that blocks me from getting to the transfer link:
[ERROR] GET /api/v1/acquisitions/orders: unhandled exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'biblio.biblionumber' in 'WHERE' at /kohadevbox/koha/Koha/Objects.pm line 401>>
This is without the patch - posted to Mattermost as well. Maybe someone else could give it a try?
Can confirm that I get the same error when attempting to receive a shipment (before the patch): 1. Add an order to the bask for My Vendor. 2. Close the basket 3. Go the vendor page 4. Click 'Receive shipments' 5. Enter an invoice number 6. Click 'Next' 7. You get a "Something went wrong when loading the table. 500: Internal Server Error." Click OK 8. The 'Receive orders from My Vendor" page sits on "Processing ....". 9. There is the error above in the plack-api-error.log I tried a yarn build and restart_all, but that made no difference. Discussion on Mattermost at https://chat.koha-community.org/koha-community/pl/718z5ut7pirqmmz7ywufdge8er -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks David! I've filed it: Bug 42995 - Error in table of pending orders prevents receiving orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42995 [Bug 42995] Error in table of pending orders prevents receiving orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Since bug 42995 was fixed, we can continue testing here... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tested both behaviors with and without the patch with Firefox and didn't see the described error, the behavior was the same. I am signing off as there is no visible regression and it will probably be useful for some browsers as Baptiste has seen the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 202024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202024&action=edit Bug 40575: Transferring order will reload the page and its form Test plan: 1 - Create two baskets: "Source Basket" and "Dest Basket" 2 - Add one command line to "Source Basket" 3 - Close the basket 4 - Receive shipment 5 - Receive order 6 - Cancel the order receive 7 - Transfer the order to the Dest Basket -> When clicking on chose, you will be asked if you want to send again infos (which were sent to cancel the order receive), and if accepting, you will be printed an error. 8 - Apply patch 9 - Repeat the process with another source Basket and notice the page is simply reloaded without sending form. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|david@davidnind.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40575 Bug 40575 depends on bug 42995, which changed state. Bug 42995 Summary: Error in table of pending orders prevents receiving orders https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42995 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org