[Bug 25852] New: If a layout is edited, the Layout Type will revert to Barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Bug ID: 25852 Summary: If a layout is edited, the Layout Type will revert to Barcode Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If a label is set to have the layout as Barcode/Biblio - and edits are made, the layout type will change to just Barcode. To Recreate: 1. Create a layout type for Barcode/Biblio 2. Choose fields to print and size of font. 3. Save and Exit. 4. Test print this label and realize that font is too large. 5. Edit existing Layout and change font. 6. Save and then see that the layout type is now set to Barcode. This is extremely confusing and frustrating since one might not notice that the type has changed and prepared to print a sheet of labels and they are now wrong as they are only creating barcode labels instead of barcode/biblio labels. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|cnighswonger@foundations.ed |jonathan.druart@bugs.koha-c |u |ommunity.org Version|19.11 |master Severity|minor |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107571&action=edit Bug 25852: Improve C4::Creators::Lib reliability under plack This is certainly a major issue that leads to many side-effects. Under plack, the structure of the default values are not handled correctly. Package variables are used to store stuff like the "layout type". They are complex structures (arrays of hashes) and returned without being copied. When the caller (the controller script) retrieve them then modify the returned structures, it actually modifies the package's variables. One of the issue is: Create a new layout The script retrieve a structure with all "selected" flags are set to 0 It select the first one as default (BAR as selected => 1) The user creates the new layout and will selected BIBBAR (for instance) If you then edit this new layout, the script will retrieve the "label_types" and set "selected" for BIBBAR. However BAR is still selected! The UI receives 2 selected and display the first selected one that has the selected option. Test plan: 1. Create a layout type for Barcode/Biblio 2. Choose fields to print and size of font 3. Save 4. Edit existing Layout => Withtout this patch "Barcode" is the preselected option => With this patch applied, the correct "Barcode/Biblio" option is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107572&action=edit Bug 25852: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107571|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 107573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107573&action=edit Bug 25852: Improve C4::Creators::Lib reliability under plack This is certainly a major issue that leads to many side-effects. Under plack, the structure of the default values are not handled correctly. Package variables are used to store stuff like the "layout type". They are complex structures (arrays of hashes) and returned without being copied. When the caller (the controller script) retrieve them then modify the returned structures, it actually modifies the package's variables. One of the issue is: Create a new layout The script retrieve a structure with all "selected" flags are set to 0 It select the first one as default (BAR as selected => 1) The user creates the new layout and will selected BIBBAR (for instance) If you then edit this new layout, the script will retrieve the "label_types" and set "selected" for BIBBAR. However BAR is still selected! The UI receives 2 selected and display the first selected one that has the selected option. Test plan: 1. Create a layout type for Barcode/Biblio 2. Choose fields to print and size of font 3. Save 4. Edit existing Layout => Withtout this patch "Barcode" is the preselected option => With this patch applied, the correct "Barcode/Biblio" option is selected Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107572|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 107574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107574&action=edit Bug 25852: Add tests Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107574|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107607&action=edit Bug 25852: Add tests Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107573|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107608&action=edit Bug 25852: Improve C4::Creators::Lib reliability under plack This is certainly a major issue that leads to many side-effects. Under plack, the structure of the default values are not handled correctly. Package variables are used to store stuff like the "layout type". They are complex structures (arrays of hashes) and returned without being copied. When the caller (the controller script) retrieve them then modify the returned structures, it actually modifies the package's variables. One of the issue is: Create a new layout The script retrieve a structure with all "selected" flags are set to 0 It select the first one as default (BAR as selected => 1) The user creates the new layout and will selected BIBBAR (for instance) If you then edit this new layout, the script will retrieve the "label_types" and set "selected" for BIBBAR. However BAR is still selected! The UI receives 2 selected and display the first selected one that has the selected option. Test plan: 1. Create a layout type for Barcode/Biblio 2. Choose fields to print and size of font 3. Save 4. Edit existing Layout => Withtout this patch "Barcode" is the preselected option => With this patch applied, the correct "Barcode/Biblio" option is selected Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107607|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107609&action=edit Bug 25852: Add tests Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|If a layout is edited, the |If a layout is edited, the |Layout Type will revert to |layout type will revert to |Barcode |barcode --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a little worried that other parts of the layout creator/patron card creator follow similar patterns and have similar issues... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.03 released in| | CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in| |19.11.09 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #8)
I am a little worried that other parts of the layout creator/patron card creator follow similar patterns and have similar issues...
After reviewing this code/issue, I'm actually more concerned for other parts of Koha. I wonder how many related issues are sleeping throughout the codebase... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.03, |20.11.00, 20.05.03, released in|19.11.09 |19.11.09, 19.05.15 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org