[Bug 37274] New: Improvements needed for heading of Agreements and Licenses in the ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Bug ID: 37274 Summary: Improvements needed for heading of Agreements and Licenses in the ERM Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Created attachment 168609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168609&action=edit License header example I wonder if the title of a License or Agreement should be changed from License #1 to the License name? Example: License #1 -> Ancestry The reference to the license ID number does not hold a lot of significance. If a library has a lot of licenses/agreements, then the ID numbers are less useful. If a library did have multiple agreements/licenses with a particular vendor the license name could make the distinction instead. The two icons for edit and delete could be a bit bigger with some space in-between. My first instinct was to look for the words Edit or Delete rather than an icon. Perhaps creating an Action drop down button would be better and Edit, Close, and Delete could be listed under one button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Keywords| |Academy --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I'd like to add here that we have a good opportunity to improve consistency in VueJS apps here going forward with this. If you do some testing with the preservation module, (enable preservation syspref, and then create some processings at http://localhost:8081/cgi-bin/koha/preservation/settings) and you then create a new Train, and edit that same record, you'll notice there is a top toolbar with options like 'edit', 'delete', etc. The above differs from what is currently happening in ERM, and I believe answers Esther's original comment. We have a standard toolbar component added in bug 33417 that is being utilized by TrainsShow.vue but not by AgreementsShow.vue, and imo it should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168646&action=edit Bug 37274: Use the Toolbar component in all Vue components We have a Toolbar component that must be used everywhere for consistency. This patch adds it when missing: * ERM/AgreementsShow Show an agreement * ERM/EHoldingsLocalPackagesShow Show a local package * ERM/EHoldingsLocalTitlesShow Show a local title * ERM/LicensesShow Show a license * ERM/UsageStatisticsDataProvidersShow Show a data provider * Preservation/SettingsProcessingsShow Show the the settings of a processing (Preservation module) Confirm that the "Edit" and "Delete" icons are now replaced with buttons (in a toolbar) on those views. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168646|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168706&action=edit Bug 37274: Use the Toolbar component in all Vue components We have a Toolbar component that must be used everywhere for consistency. This patch adds it when missing: * ERM/AgreementsShow Show an agreement * ERM/EHoldingsLocalPackagesShow Show a local package * ERM/EHoldingsLocalTitlesShow Show a local title * ERM/LicensesShow Show a license * ERM/UsageStatisticsDataProvidersShow Show a data provider * Preservation/SettingsProcessingsShow Show the the settings of a processing (Preservation module) Confirm that the "Edit" and "Delete" icons are now replaced with buttons (in a toolbar) on those views. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37301 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 [Bug 37301] Further improve ERM ToolbarButton component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we simplify the bug description a bit? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improvements needed for |Standardize the toolbar in |heading of Agreements and |Vue components |Licenses in the ERM | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168706|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169041&action=edit Bug 37274: Use the Toolbar component in all Vue components We have a Toolbar component that must be used everywhere for consistency. This patch adds it when missing: * ERM/AgreementsShow Show an agreement * ERM/EHoldingsLocalPackagesShow Show a local package * ERM/EHoldingsLocalTitlesShow Show a local title * ERM/LicensesShow Show a license * ERM/UsageStatisticsDataProvidersShow Show a data provider * Preservation/SettingsProcessingsShow Show the the settings of a processing (Preservation module) Confirm that the "Edit" and "Delete" icons are now replaced with buttons (in a toolbar) on those views. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a good consistency improvement.. but the code is rather wet... I'm really looking forward to the work on bug 37301 to DRY is out a lot and made this a more re-usable piece. Passing QA on this one though to keep the ball rolling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37929 [Bug 37929] Cypress tests for Agreements aren't all running -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, | |release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org