http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6371 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6371 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4178|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-05-19 04:57:31 UTC --- Created attachment 4179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4179 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6371 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4214|proposed patch |signed off patch description| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6371 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-11 09:26:55 UTC --- The problem exists, and the patch works, but i have a question about it. Let me explain: itemtypes are also accessed through C4/Koha.pm, sub GetItemTypes that is sub GetItemTypes { # returns a reference to a hash of references to itemtypes... my %itemtypes; my $dbh = C4::Context->dbh; my $query = qq| SELECT * FROM itemtypes |; my $sth = $dbh->prepare($query); $sth->execute; while ( my $IT = $sth->fetchrow_hashref ) { $itemtypes{ $IT->{'itemtype'} } = $IT; } return ( \%itemtypes ); } As a reminder, the sub in C4/ItemTypes.pm is : sub all { my ($class) = @_; my $dbh = C4::Context->dbh; return map { $class->new($_) } @{$dbh->selectall_arrayref( # The itemtypes table is small enough for # `SELECT *` to be harmless. "SELECT * FROM itemtypes ORDER BY description", { Slice => {} }, )}; } I don't see any "utf8::encode" in the GetItemTypes, the sub is quite similar, except one uses selectall_arrayref, the other fetchrow_hashref. Why the hell is it needed to utf8::encode the ItemTypes.pm and not the GetItemTypes ? What I fear is that the utf8::encode solves this problem, but another problem will happen later. If anyone has an idea... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6371 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 14:27:02 UTC --- Created attachment 5772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5772 Bug 6371 Item Types description not properly displayed if not pure ASCII In several places, C4::ItemType module is used to retrieve item types and their description. If the description text contains non-ASCII characters, those characters are not properly displayed. This bug can be seen in: - 4xx plugin of a UNIMARC DB - Home > Admin > Item circulation alerts - others?... Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - Fixes display probems in circulation alerts and 4xx UNIMARC plugin - display in other places looks ok with and without patch Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6371 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Signed Off |Passed QA AssignedTo|gmcharlt@gmail.com |frederic@tamil.fr --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 14:31:26 UTC --- QA comment * good test plan * small patch * no code comment to do, it's only a few lines long * works as expected => passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6371 --- Comment #10 from Frédéric Demians <frederic@tamil.fr> 2011-10-08 13:41:07 UTC ---

Pushed please test

It works now in HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.