[Bug 34308] New: Item->store tests on itemlost>0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 Bug ID: 34308 Summary: Item->store tests on itemlost>0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Should store test itemlost > 0 or !itemlost (truth test) ? In most code it seems to be tested with truth already. It looks like we do not have any special meaning for negative itemlost values. There is normally just 1 to 5. So I think that the >0 test just stems from seeing values 1 and higher. So imo we can just test truth to see if something is lost. Do you have any feedback about these negative lost values? Please add it here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33608 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Discussion comes actually from 33608 btw. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I can't recall ever running into any lost item functionality that depended on positive vs negative itemlost values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- History is: commit dd1eec2715b465 commit 0005f6bad36319 which does not make a lot of sense at the end. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is current MASTER: # If item was lost and has now been found, # reverse any list item charges if necessary. if ( exists $updated_columns{itemlost} and $updated_columns{itemlost} <= 0 and $pre_mod_item->itemlost > 0 ) { $self->_set_found_trigger($pre_mod_item); } I actually do not understand the test here for <= 0 too. Imo should be =0 only. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
History is:
commit dd1eec2715b465 commit 0005f6bad36319
which does not make a lot of sense at the end.
$charge eq $lostvalue Strange test? Not reading the definitive answer here for making the distinction? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #5)
$charge eq $lostvalue Strange test?
This seems correct. misc/cronjobs/longoverdue.pl 60 'c|charge=s' => \$charge, 146 =item B<--charge | -c> 147 148 This specifies what lost value triggers Koha to charge the account for the lost item. 238 $PERL5LIB/misc/cronjobs/longoverdue.pl --lost 60=2 --charge 2 239 Would set LOST=2 after 60 days (up to one year), and charge the account when setting LOST=2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34308 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
(In reply to Marcel de Rooy from comment #5)
$charge eq $lostvalue Strange test?
This seems correct.
Ah thanks. Bit of confusing parameter. I was thinking of an amount or so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org